OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [NETCONF-514] Spurious reads before put in 8040 implementation across a mounted resource https://jira.opendaylight.org/browse/NETCONF-514 netconf <p>8040 code does unnecessary reads when a PUT is given via restconf.</p> <p>A PUT according to RFC is a "create or modify". There is absolutely no need to perform a read here. This is not a POST where ODL needs to verify if the resource exists beforehand.</p> <p>This is purely a performance penalty issue, it does not effect functionality</p> <p>Observed with JSON RPC, should be observable using any mounted data resource broker.</p> NETCONF-514 Spurious reads before put in 8040 implementation across a mounted resource Bug Low Resolved Done Unassigned Anton Ivanov Fri, 23 Feb 2018 18:03:28 +0000 Wed, 28 Feb 2018 19:09:05 +0000 Wed, 28 Feb 2018 19:09:05 +0000 restconf-nb 0 2 <p>The read is done to satisfy RFC8040 section 4.5 (<a href="https://tools.ietf.org/html/rfc8040#section-4.5):" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/rfc8040#section-4.5):</a> "Consistent with <span class="error">&#91;RFC7231&#93;</span>, if the PUT request creates a new resource, a "201 Created" status-line is returned. If an existing resource is modified, a "204 No Content" status-line is returned.". So the read result is used to initialize the response status in ResponseFactory.prepareStatus:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> return readData != null ? Status.OK : Status.CREATED; </pre> </div></div> <p>However, according to the RFC, Status.OK should be Status.NO_CONTENT.</p> <p>This makes more sense. However, in that case it may be worth it to consider using exist() - this is the same cost internally and for mount points it does not incur the penalty of transferring all the data under this node.</p> <p>Agreed. Also the exists call can be done in parallel with the submit.</p> <p>Actually doing it in parallel when accessing the data store would be OK but we can't be sure about mount points.</p> <p>Submitted <a href="https://git.opendaylight.org/gerrit/#/c/68782/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/68782/</a></p> Development Rank 0|i03aqn: