https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-57 netconf <p>sal-netconf-connector has a base schema context that has base netconf schemas in case a device does not provide these, but no ietf-netconf-notificatons. This would be a nice addition, since we already encountered devices that do not provide this schema.</p> <p>Operating System: All<br/> Platform: All</p> NETCONF-57

Extend sal-netconf-connector base schema context to include ietf-netconf-notifications

Bug Resolved Done Andrej Mak Tomas Cere Thu, 6 Aug 2015 14:28:16 +0000 Fri, 15 Mar 2019 22:22:13 +0000 Fri, 12 Feb 2016 09:02:54 +0000 netconf 0 6 <p>Hi,</p> <p>I was going through this bug to fix same. <br/> Can you please elaborate more on this bug (like where is base schema context, bit more on ietf notifications that needs to be added, etc).</p> <p>Are you looking for the addition of all notifications as defined in "ietf-netconf-notifications" module, in the existing augmentation of odl-sal-netconf-connector-cfg.yang ?</p> <p>Thanks<br/> Rashmi</p> <p>Hi, </p> <p>base schema context is built here: <a href="https://github.com/opendaylight/netconf/blob/c84df3c3b3ccd14022c4e452eedcd9c54c8c928e/opendaylight/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfDevice.java#L78-L84" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/netconf/blob/c84df3c3b3ccd14022c4e452eedcd9c54c8c928e/opendaylight/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfDevice.java#L78-L84</a></p> <p>you should be able to just add it in the same way as ietf-netconf, you would just use the generated $YangModuleInfoImpl for the ietf-netconf-notifications binding.<br/> Please take the bug and put it's status as in progress if you are working on it so there's no duplicate work. If you have any more questions ask <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/>.</p> <p>Tomas</p> <p>Hi,</p> <p>I have pushed in the patch in.<br/> Could you please review it and revert back if anything I missed.</p> <p>Here is the link :<br/> <a href="https://git.opendaylight.org/gerrit/#/c/28935/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/28935/</a></p> <p>Thanks,<br/> Rashmi</p> <p>The fix should be ported to lithium as well. </p> <p>Also I think the schema should only be included if the device exposes standard notification capability.</p> <p>Patch 3 submitted on the link below, so that the schema should only be included if the device exposes standard notification capability.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/28935/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/28935/</a></p> <p>I have created another context INIT_SCHEMA_CTX_WITH_IETF_NOTIFICATION for above scenario and it will be loaded only when the device have isNotificationsSupported true, when onRemoteSessionUp is invoked.</p> <p>Please review it and let me know if the approach is fine or suggest me to make it better.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/33758/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33758/</a></p> Development External issue ID 4100 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i01w6v: