https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-579 netconf <p>This is a follow-up to <a href="https://git.opendaylight.org/gerrit/#/c/77273/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/77273/</a> (re. <a href="https://jira.opendaylight.org/browse/NETVIRT-1460" title="websocket failing: causes instance creation failures" class="issue-link" data-issue-key="NETVIRT-1460">NETVIRT-1460</a> &amp; <a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-1039" title="Not able to set SLAVE role on device openflow:97702827111235, reason: Was not able to propagate SLAVE role on device. Error: org.opendaylight.openflowplugin.impl.role.RoleChangeException: Can&#39;t commit a completed message." class="issue-link" data-issue-key="OPNFLWPLUG-1039"><del>OPNFLWPLUG-1039</del></a>) :</p> <p>It seems strange to me that in that <a href="https://git.opendaylight.org/gerrit/#/c/77273/10/northbound-api/src/main/java/org/opendaylight/neutron/northbound/impl/PortStatusUpdateInitializer.java" class="external-link" target="_blank" rel="nofollow noopener">PortStatusUpdateInitializer</a>, <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=jhershbe" class="user-hover" rel="jhershbe">jhershbe</a> apparently had to use <tt>JSONRestconfService</tt>'s <tt>invokeRpc()</tt> on <tt>sal-remote:create-data-change-event-subscription</tt> with a <tt>SUBSCRIBE_JSON</tt> String.</p> <p>We'll merge that, but wouldn't be better if there was a clean strongly typed internal (Java) API for that instead of this weird architecture where neutron uses restconf to invoke an RPC like this?</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=JMorvay" class="user-hover" rel="JMorvay">JMorvay</a> is this something you would consider adding?</p> NETCONF-579

Add a strongly typed internal (Java) RPC API for JSONRestconfService's subscribeToStream()

Improvement Medium Open Unresolved Josh Hershberg Michael Vorburger Thu, 1 Nov 2018 11:39:56 +0000 Tue, 19 Mar 2019 13:44:02 +0000 0 1 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=jhershbe" class="user-hover" rel="jhershbe">jhershbe</a> hey wait a second ... so this <tt>sal-remote:create-data-change-event-subscription</tt> RPC is from netconf/restconf/restconf-common-models/src/main/yang/opendaylight-md-sal-remote.yang. And so the <tt>org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.remote.rev140114.SalRemoteService</tt> has a <tt>createDataChangeEventSubscription</tt>. So ... why did you do that handstand hoop via <tt>JSONRestconfService</tt>'s <tt>invokeRpc()</tt> instead of just calling that RPC "as always" ?</p> <p>So <a href="https://git.opendaylight.org/gerrit/77410" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/77410</a> uses the Java RPC for sal-remote:create-data-change-event-subscription ...</p> <p>BUT the <tt>subscribeToStream()</tt> (of <tt>JSONRestconfService</tt> is still lacking a Java RPC, and that's what this issues is really about (I initially got confused) .. <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=JMorvay" class="user-hover" rel="JMorvay">JMorvay</a> (or <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=tpantelis" class="user-hover" rel="tpantelis">tpantelis</a>) is that something you would like to add in restconf, some time?</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/77410/" class="external-link" target="_blank" rel="nofollow noopener">c/77410</a> can probably be restored when this is made available.</p> Development Rank 0|i03k47: