[NETCONF-615] Callhome throws NPEs in DTCL

Tue, 21 May 2019 10:41:23 +0000
A successful test at https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netconf-csit-1node-gate-callhome-only-neon/8/odl_1/odl1_karaf.log.gz shows callhome is throwing NPEs in two separate paths:
2019-01-28T20:58:15,836 | INFO  | nioEventLoopGroup-4-3 | CallhomeStatusReporter           | 271 - org.opendaylight.netconf.callhome-provider - 1.6.0.SNAPSHOT | Setting auth failed status for callhome device id:netopeer.
2019-01-28T20:58:18,486 | INFO  | opendaylight-cluster-data-notification-dispatcher-73 | IetfZeroTouchCallHomeServerProvider | 271 - org.opendaylight.netconf.callhome-provider - 1.6.0.SNAPSHOT | Deleting the entry for callhome device InstanceIdentifier{targetType=interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netconf.callhome.server.rev161109.netconf.callhome.server.AllowedDevices, path=[org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netconf.callhome.server.rev161109.NetconfCallhomeServer, org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netconf.callhome.server.rev161109.netconf.callhome.server.AllowedDevices]}
2019-01-28T20:58:39,791 | ERROR | opendaylight-cluster-data-notification-dispatcher-49 | DataTreeChangeListenerActor      | 216 - org.opendaylight.controller.sal-clustering-commons - 1.9.0.SNAPSHOT | member-1-shard-default-config: Error notifying listener org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter@4dc64dcb
java.lang.NullPointerException: null
	at org.opendaylight.netconf.callhome.protocol.AuthorizedKeysDecoder.decodePublicKey(AuthorizedKeysDecoder.java:67) ~[270:org.opendaylight.netconf.callhome-protocol:1.6.0.SNAPSHOT]
	at org.opendaylight.netconf.callhome.mount.CallHomeAuthProviderImpl$DeviceConfig.publicKey(CallHomeAuthProviderImpl.java:180) ~[271:org.opendaylight.netconf.callhome-provider:1.6.0.SNAPSHOT]
	at org.opendaylight.netconf.callhome.mount.CallHomeAuthProviderImpl$DeviceConfig.putDevice(CallHomeAuthProviderImpl.java:162) ~[271:org.opendaylight.netconf.callhome-provider:1.6.0.SNAPSHOT]
	at org.opendaylight.netconf.callhome.mount.CallHomeAuthProviderImpl$DeviceConfig.process(CallHomeAuthProviderImpl.java:148) ~[271:org.opendaylight.netconf.callhome-provider:1.6.0.SNAPSHOT]
	at org.opendaylight.netconf.callhome.mount.CallHomeAuthProviderImpl$DeviceConfig.onDataTreeChanged(CallHomeAuthProviderImpl.java:139) ~[271:org.opendaylight.netconf.callhome-provider:1.6.0.SNAPSHOT]
	at org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:41) ~[233:org.opendaylight.mdsal.binding-dom-adapter:3.0.6]
	at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:81) [224:org.opendaylight.controller.sal-distributed-datastore:1.9.0.SNAPSHOT]
	at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:42) [224:org.opendaylight.controller.sal-distributed-datastore:1.9.0.SNAPSHOT]
	at org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor.onReceive(AbstractUntypedActor.java:40) [216:org.opendaylight.controller.sal-clustering-commons:1.9.0.SNAPSHOT]
	at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:167) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.Actor.aroundReceive(Actor.scala:517) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.Actor.aroundReceive$(Actor.scala:515) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:97) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.ActorCell.receiveMessage(ActorCell.scala:588) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.ActorCell.invoke(ActorCell.scala:557) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:258) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.Mailbox.run(Mailbox.scala:225) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.Mailbox.exec(Mailbox.scala:235) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) [28:com.typesafe.akka.actor:2.5.19]
2019-01-28T20:58:39,796 | ERROR | opendaylight-cluster-data-notification-dispatcher-77 | DataTreeChangeListenerActor      | 216 - org.opendaylight.controller.sal-clustering-commons - 1.9.0.SNAPSHOT | member-1-shard-default-operational: Error notifying listener org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter@7808a8f6
java.lang.NullPointerException: null
	at java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011) ~[?:?]
	at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006) ~[?:?]
	at org.opendaylight.netconf.callhome.mount.CallHomeAuthProviderImpl$DeviceOp.putDevice(CallHomeAuthProviderImpl.java:224) ~[271:org.opendaylight.netconf.callhome-provider:1.6.0.SNAPSHOT]
	at org.opendaylight.netconf.callhome.mount.CallHomeAuthProviderImpl$DeviceOp.process(CallHomeAuthProviderImpl.java:209) ~[271:org.opendaylight.netconf.callhome-provider:1.6.0.SNAPSHOT]
	at org.opendaylight.netconf.callhome.mount.CallHomeAuthProviderImpl$DeviceOp.onDataTreeChanged(CallHomeAuthProviderImpl.java:200) ~[271:org.opendaylight.netconf.callhome-provider:1.6.0.SNAPSHOT]
	at org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:41) ~[233:org.opendaylight.mdsal.binding-dom-adapter:3.0.6]
	at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:81) [224:org.opendaylight.controller.sal-distributed-datastore:1.9.0.SNAPSHOT]
	at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:42) [224:org.opendaylight.controller.sal-distributed-datastore:1.9.0.SNAPSHOT]
	at org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor.onReceive(AbstractUntypedActor.java:40) [216:org.opendaylight.controller.sal-clustering-commons:1.9.0.SNAPSHOT]
	at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:167) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.Actor.aroundReceive(Actor.scala:517) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.Actor.aroundReceive$(Actor.scala:515) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:97) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.ActorCell.receiveMessage(ActorCell.scala:588) [28:com.typesafe.akka.actor:2.5.19]
	at akka.actor.ActorCell.invoke(ActorCell.scala:557) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:258) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.Mailbox.run(Mailbox.scala:225) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.Mailbox.exec(Mailbox.scala:235) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) [28:com.typesafe.akka.actor:2.5.19]
	at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) [28:com.typesafe.akka.actor:2.5.19]
OpenDaylight JIRA

[NETCONF-615] Callhome throws NPEs in DTCL
