OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [NETCONF-657] Support plain PATCH per RFC8040 https://jira.opendaylight.org/browse/NETCONF-657 netconf <p>RFC8040 specifieds plain PATCH requirements that are distinct from Yang PATCH</p> NETCONF-657 Support plain PATCH per RFC8040 Improvement High Resolved Done Allan Clarke Allan Clarke Mon, 24 Feb 2020 19:45:43 +0000 Tue, 21 Apr 2020 21:15:00 +0000 Tue, 21 Apr 2020 15:56:06 +0000 restconf-nb 0 2 <p>Allan's workflow...</p> <ol> <li>Pull NETCONF master code (DONE)</li> <li>Ensure buildable environment (DONE)</li> <li>Ensure debuggable environment (DONE)</li> <li>Review NETCONF user and dev docs (DONE)</li> <li>Install/configure testtool (DONE)</li> <li>Determine simulator or device to use (DONE)</li> <li>Learn Yang Patch versus Plain Patch (DONE)</li> <li>Learn Yangtools programming model (DONE)</li> <li>Figure out how to configure patch response on device (DONE)</li> <li>Estimate implementation and test time (DONE ALREADY IN COMMENT)</li> <li>Confirm expectation (SKIP)</li> <li>Learn NETTCONF code around desired feature (DONE)</li> <li>Propose design and get feedback (SKIP - N+1 with existing implementation)</li> <li>Learn NETCONF unit testing code (DONE)</li> <li>Propose tests for feature and get feedback (SKIP - all unit tests)</li> <li>Implement feature (DONE)</li> <li>Get 3rd party acceptance of implementation (will be done through Jamo and Luis)</li> <li>Implement unit/feature tests (DONE)</li> <li>PR and review process (IN-PROGRESS)</li> </ol> <p>Gotchas...</p> <ul> <li>Could not build older versions because SNAPSHOTS no longer on Nexus -&gt; had to move up to Neon.</li> <li>Failure on build due to Java 8 version -&gt; installed Java 11 (via homebrew on OSX)</li> <li>NETCONF build failure on javax/annotation/PostConstruct -&gt; solved by moving to Maven 3.6</li> <li>Use 127.0.0.1 instead of localhost in URLs and payloads (may be an OSX port-forwarding issue)</li> <li>Watch out for copy/paste putting "smart quotes" in payloads - gives hard to spot errors</li> <li>Yang Patch aggressively deletes data beyond scope of affected data (probable bug)</li> </ul> <p>Helpfuls...</p> <p>karaf/target/assembly/bin/karaf debug</p> <p>feature:install odl-netconf-connector-all<br/> feature:install odl-resconf<br/> feature:install odl-netconf-topology<br/> feature:install odl-restconf-nb-rfc8040</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> curl -s -u admin:admin http:<span class="code-comment">//localhost:8181/rests/data/network-topology:network-topology | python -mjson.tool</span> </pre> </div></div> <p>karaf&gt; log:set TRACE org.opendaylight.controller.sal.connect.netconf</p> <p>// launch testtool using the jukebox schema</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> java -jar ./netconf/tools/netconf-testtool/target/netconf-testtool-*-SNAPSHOT-executable.jar --device-count 1 --schemas-dir ./restconf/restconf-nb-rfc8040/target/test-classes/jukebox/ </pre> </div></div> <p>See attached POSTMAN for both bierrman02 and RfC8040 CRUD operations. It has a bierman02 and rfc8040 set of operations (not symmetrical due to my laziness). Ignore the netopeer operations.</p> <p>Errata...<br/> <a href="https://docs.opendaylight.org/projects/netconf/en/latest/user-guide.html#_spawning_additional_netconf_connectors_while_the_controller_is_running" class="external-link" target="_blank" rel="nofollow noopener">https://docs.opendaylight.org/projects/netconf/en/latest/user-guide.html#_spawning_additional_netconf_connectors_while_the_controller_is_running</a></p> <ul> <li>Add missing - to docker command: docker run -rm -t -p 1831:830 dockeruser/netopeer</li> <li>Change "Now just follow the chapter: Spawning netconf-connector." from chapter to section and fix broken link (multiple on this page)</li> </ul> <p>Upstream...</p> <p><a href="https://jira.opendaylight.org/browse/NETCONF-657" class="external-link" rel="nofollow">https://jira.opendaylight.org/browse/NETCONF-657</a> (this issue upstream)<br/> <a href="https://jira.opendaylight.org/browse/NETCONF-312" class="external-link" rel="nofollow">https://jira.opendaylight.org/browse/NETCONF-312</a> (potential bug affecting PATCH)<br/> <a href="https://git.opendaylight.org/gerrit/c/netconf/+/88214" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/88214</a> (this work in Gerrit)</p> <p>Resources...</p> <p><a href="https://tools.ietf.org/html/rfc8040#section-1.1.6" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/rfc8040#section-1.1.6</a> (RESTCONF)<br/> <a href="https://tools.ietf.org/html/draft-ietf-netconf-yang-patch-14" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/draft-ietf-netconf-yang-patch-14</a> (Yang Patch)<br/> <a href="https://docs.opendaylight.org/en/latest/developer-guide/yang-tools.html" class="external-link" target="_blank" rel="nofollow noopener">https://docs.opendaylight.org/en/latest/developer-guide/yang-tools.html</a> (YangTools)<br/> <a href="https://tools.ietf.org/html/rfc7950" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/rfc7950</a> (Yang)</p> <p><a href="https://git.opendaylight.org/gerrit/c/netconf/+/88214" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/88214</a><br/> <a href="https://git.opendaylight.org/gerrit/c/netconf/+/88378" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/88378</a><br/> <a href="https://git.opendaylight.org/gerrit/c/netconf/+/88379" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/88379</a></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=allanclarke" class="user-hover" rel="allanclarke">allanclarke</a> for the record: an issue is not resolved until fixes to all target branches are actually merged.</p> <p>Thanks for letting me know. I did not know the workflow so I asked Jamo and followed his advice. <br/> Bad Jamo, bad!</p> Development Rank 0|i03r6n: