https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-703 netconf <p>This can be tracked in this CSIT job:<br/> <a href="https://jenkins.opendaylight.org/releng/view/netconf/job/netconf-csit-1node-userfeatures-all-aluminium/" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/view/netconf/job/netconf-csit-1node-userfeatures-all-aluminium/</a></p> <p>When controller just installs RESTCONF, the new apidocs work fine. However when all compatible features are installed, it produces this exception:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> javax.servlet.ServletException: javax.servlet.ServletException: java.lang.NumberFormatException: For input string: <span class="code-quote">"0xfff8"</span> at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:88) ~[?:?] at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) ~[bundleFile:9.4.22.v20191022] at org.eclipse.jetty.server.Server.handle(Server.java:500) ~[bundleFile:9.4.22.v20191022] at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:386) ~[bundleFile:9.4.22.v20191022] at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:562) ~[bundleFile:9.4.22.v20191022] at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:378) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:270) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:388) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806) [bundleFile:9.4.22.v20191022] at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938) [bundleFile:9.4.22.v20191022] at java.lang.<span class="code-object">Thread</span>.run(<span class="code-object">Thread</span>.java:834) [?:?] </pre> </div></div> <p>To reproduce:</p> <p>1) Install aluminium karaf and do:<br/> feature:repo-add mvn:org.opendaylight.integration/features-test/0.13.0-SNAPSHOT/xml/features<br/> feature:install odl-integration-compatible-with-all</p> <p>2) Open URL: <a href="http://10.1.68.201:8181/apidoc/openapi3/18/apis/single" class="external-link" target="_blank" rel="nofollow noopener">http://10.1.68.201:8181/apidoc/openapi3/18/apis/single</a></p> NETCONF-703

Apidocs does not work in Aluminum

Bug High Verified Done Ilya Igushev Luis Gomez Fri, 19 Jun 2020 21:57:43 +0000 Tue, 14 Jul 2020 20:13:23 +0000 Fri, 26 Jun 2020 03:56:08 +0000 restconf-nb 0 3 <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Caused by: java.lang.NumberFormatException: For input string: "0xfff8" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) ~[?:?] at java.lang.Long.parseLong(Long.java:692) ~[?:?] at java.lang.Long.valueOf(Long.java:1144) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processTypeDef(DefinitionGenerator.java:716) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processLeafNode(DefinitionGenerator.java:622) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChildren(DefinitionGenerator.java:478) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processDataNodeContainer(DefinitionGenerator.java:377) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChoiceNode(DefinitionGenerator.java:563) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChildren(DefinitionGenerator.java:500) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processDataNodeContainer(DefinitionGenerator.java:377) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChildren(DefinitionGenerator.java:488) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processDataNodeContainer(DefinitionGenerator.java:377) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChoiceNode(DefinitionGenerator.java:563) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChildren(DefinitionGenerator.java:500) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processDataNodeContainer(DefinitionGenerator.java:377) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChildren(DefinitionGenerator.java:488) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processDataNodeContainer(DefinitionGenerator.java:377) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChildren(DefinitionGenerator.java:488) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processDataNodeContainer(DefinitionGenerator.java:377) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processChildren(DefinitionGenerator.java:488) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processOperationInputOutput(DefinitionGenerator.java:282) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processOperations(DefinitionGenerator.java:270) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.processRPCs(DefinitionGenerator.java:259) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.convertToJsonSchema(DefinitionGenerator.java:149) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.DefinitionGenerator.convertToJsonSchema(DefinitionGenerator.java:166) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.BaseYangSwaggerGenerator.getSwaggerDocSpec(BaseYangSwaggerGenerator.java:309) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.BaseYangSwaggerGenerator.fillDoc(BaseYangSwaggerGenerator.java:195) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.BaseYangSwaggerGenerator.getAllModulesDoc(BaseYangSwaggerGenerator.java:174) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.BaseYangSwaggerGenerator.getAllModulesDoc(BaseYangSwaggerGenerator.java:154) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.AllModulesDocGenerator.getAllModulesDoc(AllModulesDocGenerator.java:34) ~[?:?] at org.opendaylight.netconf.sal.rest.doc.impl.ApiDocServiceImpl.getAllModulesDoc(ApiDocServiceImpl.java:67) ~[?:?] </pre> </div></div> <p>Which boils down to:</p> <p> </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>./openflowplugin/extension/openflowjava-extension-nicira/src/main/yang/nicira-action.yang-144- leaf in-port { ./openflowplugin/extension/openflowjava-extension-nicira/src/main/yang/nicira-action.yang-145- type uint16; ./openflowplugin/extension/openflowjava-extension-nicira/src/main/yang/nicira-action.yang:146: default 0xfff8; // OFPP_INPORT ./openflowplugin/extension/openflowjava-extension-nicira/src/main/yang/nicira-action.yang-147- } </pre> </div></div> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>./openflowplugin/extension/openflowplugin-extension-nicira/src/main/yang/openflowplugin-extension-nicira-action.yang-427- leaf in-port { ./openflowplugin/extension/openflowplugin-extension-nicira/src/main/yang/openflowplugin-extension-nicira-action.yang-428- type uint16; ./openflowplugin/extension/openflowplugin-extension-nicira/src/main/yang/openflowplugin-extension-nicira-action.yang:429: default 0xfff8; // OFPP_INPORT ./openflowplugin/extension/openflowplugin-extension-nicira/src/main/yang/openflowplugin-extension-nicira-action.yang-430- } </pre> </div></div> <p>This is a YANG violation. <a href="https://jira.opendaylight.org/browse/YANGTOOLS-551" title="yang-model-util: Cross-reference constraints and default value" class="issue-link" data-issue-key="YANGTOOLS-551">YANGTOOLS-551</a> tracks the ability to detect these during parse, but this is an OFP problem.</p> <p> </p> <p>I stand corrected, this is valid according to <a href="https://tools.ietf.org/html/rfc7950#section-9.2.1" class="external-link" target="_blank" rel="nofollow noopener">https://tools.ietf.org/html/rfc7950#section-9.2.1</a></p> <p>The code in DefinitionGenerator needs to be smarter about detecting octal/hex values as per the spec.</p> <p>Issue seems to be fixed but the test reports a timeout (after 30 secs) reading from the api explorer URL <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/><br/> I will check if we need to increase this timeout or there is another issue.</p> <p>yep. <a href="https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netconf-csit-1node-userfeatures-all-aluminium/114/robot-plugin/log.html.gz#s1-s2-s1-t1-k2-k1-k4-k3-k1" class="external-link" target="_blank" rel="nofollow noopener">log here </a></p> <p>30s is a long time though.</p> <p>I see no log messages during the window of the apidocs call. <a href="https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netconf-csit-1node-userfeatures-all-aluminium/114/odl_1/odl1_karaf.log.gz" class="external-link" target="_blank" rel="nofollow noopener">karaf.log </a></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=ecelgp" class="user-hover" rel="ecelgp">ecelgp</a> if you have bandwidth, maybe just pull the distro local and hit that URI to see.</p> <p>It is just a matter of time: <a href="https://git.opendaylight.org/gerrit/c/integration/test/+/90717" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/integration/test/+/90717</a></p> <p>yes, I see. must be a TON of output coming back. I tried to open the step in robot<br/> that logs the response.text and it crashed my browser. Thanks for fixing the apidocs<br/> bug and the test code guys.</p> Duplicate NETCONF-685 Relates YANGTOOLS-551 Development Rank 0|i03t6v: