[NETCONF-755] Commit to non-candidate device

Fri, 19 Feb 2021 06:09:19 +0000

Please find attached karaf log (TRACE)
The interesting part is around line 27392

2021-01-28T11:35:55,158 | TRACE | qtp1820169956-75 | NetconfDeviceCommunicator        | 279 - org.opendaylight.netconf.sal-netconf-connector - 1.12.1 | RemoteDevice{NO-CANDIDATE}: Sending message <rpc message-id="m-24" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
    <edit-config>
        <target>
            <running/>
        </target>
        <error-option>rollback-on-error</error-option>
        <config>
            <control-construct xmlns="urn:onf:yang:core-model-1-4">
                <logical-termination-point>
                    <uuid>cdcd6b3f-1543-0d47-48c5-6132ff3f493a</uuid>
                    <label>
                        <value-name>my-label</value-name>
                        <value xmlns:op="urn:ietf:params:xml:ns:netconf:base:1.0" op:operation="create">works</value>
                    </label>
                </logical-termination-point>
            </control-construct>
        </config>
    </edit-config>
</rpc>

2021-01-28T11:35:55,158 | TRACE | nioEventLoopGroupCloseable-3-1 | NetconfClientSessionImpl         | 281 - org.opendaylight.netconf.shaded-sshd - 1.9.1 | encode(NetconfClientSessionImpl[netconf@/127.0.0.1:18300]) packet #89 [chunk #11](704/785) 20 20 20 20 20 20 20 20 20 20 3c 2f 6c 61 62 65 6c 3e 0a 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 3c 2f 6c 6f 67 69 63 61 6c 2d 74 65 72 6d 69 6e 61 74 69 6f 6e 2d 70 6f 69 6e 74 3e 0a    ..........</label>.................</logical-termination-point>.
2021-01-28T11:35:55,158 | TRACE | qtp1820169956-75 | KeepaliveSalFacade               | 279 - org.opendaylight.netconf.sal-netconf-connector - 1.12.1 | Start to waiting for result.
2021-01-28T11:35:55,159 | TRACE | qtp1820169956-75 | KeepaliveSalFacade               | 279 - org.opendaylight.netconf.sal-netconf-connector - 1.12.1 | RemoteDevice{NO-CANDIDATE}: Resetting netconf keepalive timer
2021-01-28T11:35:55,159 | TRACE | qtp1820169956-75 | KeepaliveSalFacade               | 279 - org.opendaylight.netconf.sal-netconf-connector - 1.12.1 | RemoteDevice{NO-CANDIDATE}: Scheduling keepalives every  120 SECONDS
2021-01-28T11:35:55,159 | TRACE | qtp1820169956-75 | NetconfDeviceCommunicator        | 279 - org.opendaylight.netconf.sal-netconf-connector - 1.12.1 | RemoteDevice{NO-CANDIDATE}: Sending message <rpc message-id="m-25" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
    <commit/>
</rpc>

The NetconfDeviceCommunicator correctly sends the <edit-config> to <running/> - but later also the <commit/>. In case of non candidate devices the <commit/> must not be send.

This functions correctly in Magnesium.

karaf.log

OpenDaylight JIRA

[NETCONF-755] Commit to non-candidate device