https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-794 netconf <p>When Action is invoked through RESTCONF, it will provide wrong DOMDataTreeIdentifier path for specific Action. This path will point to the parent of called Action.</p> <p><a href="https://github.com/opendaylight/mdsal/blob/master/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/DOMRpcRouter.java#L430" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/mdsal/blob/master/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/DOMRpcRouter.java#L546</a><br/> entry.getImplementations(path).get(0).invokeAction(type, path, input)</p> <p>path = DOMDataTreeIdentifier{datastore=OPERATIONAL, root=/(instance:identifier:module?revision=2014-01-17)cont/cont1}</p> <p>Registered implementation key is:<br/> DOMDataTreeIdentifier{datastore=OPERATIONAL, root=/(instance:identifier:module?revision=2014-01-17)cont/cont1/reset}</p> NETCONF-794

RESTCONF provide wrong DOMDataTreeIdentifier path for Actions when is invoke

Bug Medium Resolved Won't Do Ivan Hrasko Peter Suna pt Tue, 27 Jul 2021 13:16:58 +0000 Fri, 6 Aug 2021 13:25:56 +0000 Fri, 6 Aug 2021 13:25:46 +0000 restconf-nb 0 2 <p>According to javadoc of org.opendaylight.mdsal.dom.api.DOMActionService#invokeAction<br/> the path argument expects the "DOMDataTreeIdentifier of parent data node which action attached to".</p> <p>In the next iteration of test patch we were able to register and invoke the Reset action.<br/> But we have found a problem in processing of the action result - there is a mismatch<br/> between RpcResult returned by:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>org.opendaylight.yangtools.yang.binding.Action#invoke </pre> </div></div> <p>and DOMActionResult expected by:<br/> org.opendaylight.mdsal.dom.api.DOMActionImplementation#invokeAction</p> <p>There are two possibilities:<br/> 1. we have to create DOMActionResult from returned RpcResult in:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>org.opendaylight.restconf.nb.rfc8040.rests.utils.ActionResultFactory </pre> </div></div> <p>2. we have to rework org.opendaylight.yangtools.yang.binding.Action class<br/> and possibly other things as well in msal and yangtools.</p> <p>In the third iteration of test we have found a way how to translate RpcResult into DOMActionResult using codec.</p> <p>It a responsibility of action implementation to do so.</p> <p>During testing we have found only issue that exception is thrown when action output is empty. This behavior is not according to RFC 8040 which states that in case of rpc/action with no output response with status code 204 and empty body should be returned without any errors.</p> <p>This bug is invalid. We have created another one for the problem when action has no output: <a href="https://jira.opendaylight.org/browse/NETCONF-799" class="external-link" rel="nofollow">https://jira.opendaylight.org/browse/NETCONF-799</a>.</p> Development Rank 0|i03z0n: