https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-822 netconf <p>Steps to reproduce:</p> <ul> <li>Start Karaf</li> <li>Install RESTCONF and topology features: "<em>feature:install odl-restconf-all odl-netconf-topology</em>"</li> <li>Send get request to retrieve server RPC operations: "curl --request GET '<a href="http://localhost:8181/rests/operations&#39;" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/rests/operations'</a> "</li> </ul> <p> <br/> The request will fail because in SchemaInferenceStack class is trying to find RPC with name "operations" instead of returning all found RPCs operations:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Caused by: java.lang.IllegalArgumentException: Data tree child (urn:ietf:params:xml:ns:yang:ietf-restconf)operations not present at org.opendaylight.yangtools.yang.model.util.SchemaInferenceStack.lambda$pushData$5(SchemaInferenceStack.java:799) ~[?:?] at java.util.Optional.orElseThrow(Optional.java:408) ~[?:?] at org.opendaylight.yangtools.yang.model.util.SchemaInferenceStack.pushData(SchemaInferenceStack.java:798) ~[?:?] at org.opendaylight.yangtools.yang.model.util.SchemaInferenceStack.pushFirstData(SchemaInferenceStack.java:807) ~[?:?] at org.opendaylight.yangtools.yang.model.util.SchemaInferenceStack.pushData(SchemaInferenceStack.java:787) ~[?:?] at org.opendaylight.yangtools.yang.model.util.SchemaInferenceStack.enterDataTree(SchemaInferenceStack.java:473) ~[?:?] at org.opendaylight.yangtools.yang.data.util.NormalizedNodeStreamWriterStack.enterDataTree(NormalizedNodeStreamWriterStack.java:187) ~[?:?] at org.opendaylight.yangtools.yang.data.util.NormalizedNodeStreamWriterStack.startContainerNode(NormalizedNodeStreamWriterStack.java:259) ~[?:?] at org.opendaylight.yangtools.yang.data.codec.gson.JSONNormalizedNodeStreamWriter.startContainerNode(JSONNormalizedNodeStreamWriter.java:305) ~[?:?] at org.opendaylight.restconf.nb.rfc8040.jersey.providers.ParameterAwareNormalizedNodeWriter.wasProcessedAsCompositeNode(ParameterAwareNormalizedNodeWriter.java:265) ~[?:?] at org.opendaylight.restconf.nb.rfc8040.jersey.providers.ParameterAwareNormalizedNodeWriter.write(ParameterAwareNormalizedNodeWriter.java:117) ~[?:?] at org.opendaylight.restconf.nb.rfc8040.jersey.providers.ParameterAwareNormalizedNodeWriter$OrderedParameterAwareNormalizedNodeWriter.write(ParameterAwareNormalizedNodeWriter.java:323) ~[?:?] at org.opendaylight.restconf.nb.rfc8040.jersey.providers.JsonNormalizedNodeBodyWriter.writeNormalizedNode(JsonNormalizedNodeBodyWriter.java:134) ~[?:?] at org.opendaylight.restconf.nb.rfc8040.jersey.providers.JsonNormalizedNodeBodyWriter.writeTo(JsonNormalizedNodeBodyWriter.java:72) ~[?:?] at org.opendaylight.restconf.nb.rfc8040.jersey.providers.JsonNormalizedNodeBodyWriter.writeTo(JsonNormalizedNodeBodyWriter.java:47) ~[?:?]</pre> </div></div> <p>More in attached Karaf logs and debug capture.</p> NETCONF-822

Discover RPC operation through RESTCONF is failing with response 500

Bug Highest Resolved Done Robert Varga Peter Suna pt regression Wed, 29 Sep 2021 13:06:14 +0000 Tue, 5 Oct 2021 13:00:48 +0000 Tue, 5 Oct 2021 13:00:48 +0000 2.0.5 2.0.6 restconf-nb 0 2 <p>So from cursory glance there seems to be a disconnect between OperationsContainerSchemaNode, which reports its SchemaPath as /operations and JsonNormalizedNodeBodyWriter, which uses that to guide the JSON codec, which in turn talks to SchemaInferenceStack. Previously we just passed the OperationsContainerSchemaNode down the codec pipeline, which did its magic and happened to not trip over things like leafrefs (because there none), it's just simple empty leaves.</p> <p>This is rather unfortunate, as there is no straightforward way to fix this while retaining YANG-based codecs. Essentially ietf-restconf.yang forbids those leaves from existing as a baseline, simply because they do not exist in YANG model. The 'description' statement, no matter how long it is, simply is not something YANG parser can use to conjure up the corresponding 'leaf' statements into existence.</p> <p>So there are essentially two things we could do:</p> <ul> <li>ditch codecs for /operations and bypass the issue at least until the time someone else tries to decode things based on yang:data where this appears – essentially do not return NormalizedNodeContext from RestconfOperationsService.getOperations(UriInfo).</li> <li>teach YANG parser about this particular wart, i.e. make it generate the missing leaf statements, so the generated NormalizedNode structure is valid. Since we already have a rfc8040-parser-support, its extension should be able to introduce these leaves as part of the reactor execution. Even if we do that, though, RESTCONF will need to be updated to not do the hack it is now doing and pass a proper EffectiveModelInference, not SchemaPath, down to codec. Everything needed for that should already be in place with <a href="https://jira.opendaylight.org/browse/YANGTOOLS-1297" title="Add support for infering on YangDataEffectiveStatement" class="issue-link" data-issue-key="YANGTOOLS-1297"><del>YANGTOOLS-1297</del></a>.</li> </ul> <p>The second option does not work for bierman02, as it does not have a YANG extension and therefore YANG parser will not do anything for it.</p> <p>So let us:</p> <ul> <li>go with the first option for both bierman02 and rfc8040 first, which will resolve the immediate issue at hand</li> <li>follow up with the rfc8040-parser-support improvement, which feels like something we should do since we explicitly know about the issue (by implementing the rc:yang-data extension)</li> <li>switch rfc8040 back if we feel that is the best way we can do this</li> </ul> <p> </p> <p>So this is a major regression and it warrants a standalone release and perhaps re-spinning the (now 2 weeks late) Phosphorus GA.</p> Relates YANGTOOLS-1337 YANGTOOLS-1336 YANGTOOLS-1338 Development Rank 0|i03zv3: