[NETCONF-85] Inconsistent COMMIT operation handling when no transactions are present

Fri, 15 Mar 2019 22:22:15 +0000

When the COMMIT RPC operation is requested and the "candidate" configuration does not differ from the "running" configuration, the following error is usually reported:

<rpc-reply message-id="MMMM" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<rpc-error>
<error-type>application</error-type>
<error-tag>operation-failed</error-tag>
<error-severity>error</error-severity>
<error-message>No candidateTransaction found for session YYYY</error-message>
</rpc-error>
</rpc-reply>

However when an operation was attempted and the operation fails (such as attempting to delete a nonexistent node), the commit will succeed but it shall fail. This fake success will repeat even when the commit operation is attempted again immediately.

To hit the bug, run freshly extracted ODL, open a NETCONF connection, send the "hello" message (I don't know how to do that from a bash shell script, I always get "java.lang.IllegalArgumentException: Additional header in wrong format [admin;0:0:0:0:0:0:0:1:56415;ssh;client;], expected [(<username>[^;]);(?<address>[0-9\.])[:/](?<port>[0-9]);(?<transport>[a-z])[^\]]+]" after sending my "hello" message, the only way that works for me is using this suite in Gerrit: https://git.opendaylight.org/gerrit/27672, it reports one test failure with reference to this bug) and then send the following (the important thing is that it shall have no <modules> element in its running configuration when you try to do this, use "<get-config><source><running/></source></get-config>" RPC request to verify that) (also beware, the requests here are NOT tested, the correct ones are in the Gerrit change just mentioned):

You will obtain:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<rpc-reply message-id="1" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<rpc-error>
<error-type>protocol</error-type>
<error-tag>data-missing</error-tag>
<error-severity>error</error-severity>
<error-message>Data us missing, cannot execute DELETE operation</error-message>
</rpc-error>
</rpc-reply>
]]>]]>
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<rpc-reply message-id="2" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<ok/>
</rpc-reply>
]]>]]>
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<rpc-reply message-id="3" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<ok/>
</rpc-reply>

Note that the second and third messages are wrong, they should be:

<rpc-reply message-id="2" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<rpc-error>
<error-type>application</error-type>
<error-tag>operation-failed</error-tag>
<error-severity>error</error-severity>
<error-message>No candidateTransaction found for session 1</error-message>
</rpc-error>
</rpc-reply>
]]>]]>
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<rpc-reply message-id="3" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<rpc-error>
<error-type>application</error-type>
<error-tag>operation-failed</error-tag>
<error-severity>error</error-severity>
<error-message>No candidateTransaction found for session 1</error-message>
</rpc-error>
</rpc-reply>

OpenDaylight JIRA

[NETCONF-85] Inconsistent COMMIT operation handling when no transactions are present