https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-857 netconf <p>Multiple netconf components deal with ietf-yang-library. Audit all of them and update them:</p> <ol> <li>when we are creating a view from EffectiveModelContext we need to examine FeatureEffectiveStatements (or FeatureDefinitions) present in a particular module to construct the list of supported features</li> <li>when we are creating an EffectiveModelContext, we need to pass down the set of supported features to the parser</li> </ol> <p>The following need to be updated:</p> <ol> <li>org.opendaylight.netconf.mdsal.yang.library.YangLibraryWriter</li> <li>org.opendaylight.netconf.sal.connect.netconf.NetconfDevice (based on LibraryModulesSchemas)</li> <li>org.opendaylight.yanglib.impl.YangLibProvider (this might be a bit tricky, it seems it's doing multple things)</li> </ol> NETCONF-857

Export supported features to ietf-yang-library

Improvement High Confirmed Unresolved Peter Suna Robert Varga pick-next pt Thu, 3 Feb 2022 08:53:04 +0000 Mon, 22 Jan 2024 21:54:47 +0000 7.0.0 5.0.10 6.0.7 netconf 0 3 <p>YangLibraryWriter is done and merged. Only other two left.</p> <p>I found out that <a href="https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/LibraryModulesSchemas.java" class="external-link" target="_blank" rel="nofollow noopener">LibraryModulesSchemas</a> is not working properly and contains several issues.</p> <p>Wrong initialization of <a href="https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/LibraryModulesSchemas.java#L93" class="external-link" target="_blank" rel="nofollow noopener">LIBRARY_CONTEXT</a> constant could be fixed with this:<br/> <a href="https://git.opendaylight.org/gerrit/c/netconf/+/102761/5" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/102761/5</a></p> <p>Wrong handling response from device could be fixed with this:<br/> <a href="https://git.opendaylight.org/gerrit/c/netconf/+/102827/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/102827/1</a></p> <p>But the bigger problem is that the wrong RPC request is sent to the device. Instead of <a href="https://github.com/opendaylight/netconf/blob/master/model/rfc6241/src/main/yang/ietf-netconf%402011-06-01.yang#L732" class="external-link" target="_blank" rel="nofollow noopener">get</a> RPC from ietf-netconf should be used <a href="https://github.com/opendaylight/netconf/blob/9ab3c42bbf50e2a506f31f641548e06c0681f1e0/model/rfc8526/src/main/yang/ietf-netconf-nmda%402019-01-07.yang#L111" class="external-link" target="_blank" rel="nofollow noopener">get-data</a> from ietf-netconf-nmda in LibraryModulesSchemas#create:<br/> <a href="https://github.com/opendaylight/netconf/blob/9ab3c42bbf50e2a506f31f641548e06c0681f1e0/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/LibraryModulesSchemas.java#L166" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/netconf/blob/9ab3c42bbf50e2a506f31f641548e06c0681f1e0/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/LibraryModulesSchemas.java#L166</a></p> <p><b>YANG Library</b> - <a href="https://www.rfc-editor.org/rfc/rfc8525" class="external-link" target="_blank" rel="nofollow noopener">https://www.rfc-editor.org/rfc/rfc8525</a></p> <blockquote><p>This version of the YANG library supports the Network Management Datastore<br/>    Architecture (NMDA) by listing all datastores supported by a network<br/>    management server and the schema that is used by each of these<br/>    datastores.  </p></blockquote> <p><b>NETCONF Extensions to Support the NMDA</b> <a href="https://www.rfc-editor.org/rfc/rfc8526" class="external-link" target="_blank" rel="nofollow noopener">https://www.rfc-editor.org/rfc/rfc8526</a></p> <blockquote><p>The update to RFC 6241<br/>    adds new &lt;get-data&gt; and &lt;edit-data&gt; operations and augments existing<br/>    &lt;lock&gt;, &lt;unlock&gt;, and &lt;validate&gt; operations.  The update to RFC 7950<br/>    requires the usage of the YANG library (described in RFC 8525) by<br/>    NETCONF servers implementing the NMDA.</p></blockquote> <p>So ietf-yang-library should be used with NMDA because data saved in ietf-yang-library model are visible only in operation data store.<br/> <a href="https://www.rfc-editor.org/rfc/rfc8525#page-6" class="external-link" target="_blank" rel="nofollow noopener">https://www.rfc-editor.org/rfc/rfc8525#page-6</a></p> <blockquote><p>All data nodes in the "ietf-yang-library" module are "config<br/> false" and thus only accessible in the operational state datastore. </p></blockquote> <p>Therefore, data from ietf-yang-library could be retrieved only with <a href="https://github.com/opendaylight/netconf/blob/9ab3c42bbf50e2a506f31f641548e06c0681f1e0/model/rfc8526/src/main/yang/ietf-netconf-nmda%402019-01-07.yang#L111" class="external-link" target="_blank" rel="nofollow noopener">get-data</a> which can specified target data-store.</p> <p>I have added supported features to YangLibProvider. But these changes are not properly tested due to issues I have found.<br/> <a href="https://jira.opendaylight.org/browse/NETCONF-910" class="external-link" rel="nofollow">https://jira.opendaylight.org/browse/NETCONF-910</a><br/> <a href="https://jira.opendaylight.org/browse/NETCONF-909" class="external-link" rel="nofollow">https://jira.opendaylight.org/browse/NETCONF-909</a></p> Blocks NETCONF-909 NETCONF-910 YANGTOOLS-1368 Relates MDSAL-719 Development Rank 0|i041dj: