https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-861 netconf <p>Encountered couple of issues while mounting device to controller using clustered topology features(odl-restconf-all,odl-netconf-clustered-topology):</p> <ol> <li>Mounting a device with invalid ip in the payload -  Payload is not validated and the device is not prevented from mounting. Also no error messages logged</li> <li>Mounting with host name in payload - If we provided host name of the device in &lt;host&gt; field in payload, mounting is not happening.</li> </ol> <p>Want to know if these are expected behavior or do we need to apply fixes for these scenarios.</p> <p>Error logs for 1 &amp; 2: </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>07:24:45.492 ERROR [opendaylight-cluster-data-notification-dispatcher-56] member-1-shard-topology-config: Error notifying listener org.opendaylight.mdsal.binding.dom.adapter.BindingClusteredDOMDataTreeChangeListenerAdapter@8a00d20 java.lang.NullPointerException: null at java.util.Objects.requireNonNull(Objects.java:221) ~[?:?] at org.opendaylight.netconf.topology.singleton.impl.NetconfTopologyManager.startNetconfDeviceContext(NetconfTopologyManager.java:186) ~[?:?] at org.opendaylight.netconf.topology.singleton.impl.NetconfTopologyManager.onDataTreeChanged(NetconfTopologyManager.java:159) ~[?:?] at org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:37) ~[bundleFile:?] at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataTreeChanged(DataTreeChangeListenerActor.java:84) ~[bundleFile:?] at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:45) ~[bundleFile:?] at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:24) [bundleFile:?] at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:20) [bundleFile:?] at scala.PartialFunction.applyOrElse(PartialFunction.scala:189) [bundleFile:?] at scala.PartialFunction.applyOrElse$(PartialFunction.scala:188) [bundleFile:?] at akka.japi.pf.UnitCaseStatement.applyOrElse(CaseStatements.scala:20) [bundleFile:?] at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:244) [bundleFile:?] at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:245) [bundleFile:?] at akka.actor.Actor.aroundReceive(Actor.scala:537) [bundleFile:?] at akka.actor.Actor.aroundReceive$(Actor.scala:535) [bundleFile:?] at akka.actor.AbstractActor.aroundReceive(AbstractActor.scala:220) [bundleFile:?] at akka.actor.ActorCell.receiveMessage(ActorCell.scala:580) [bundleFile:?] at akka.actor.ActorCell.invoke(ActorCell.scala:548) [bundleFile:?] at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:270) [bundleFile:?] at akka.dispatch.Mailbox.run(Mailbox.scala:231) [bundleFile:?] at akka.dispatch.Mailbox.exec(Mailbox.scala:243) [bundleFile:?] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290) [?:?] at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020) [?:?] at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656) [?:?] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594) [?:?] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183) [?:?] </pre> </div></div> NETCONF-861

Netconf device mount with invalid payloads

Bug Medium Resolved Cannot Reproduce Yaroslav Lastivka Rohini Ambika pt Mon, 21 Feb 2022 09:27:33 +0000 Tue, 8 Nov 2022 12:20:34 +0000 Wed, 2 Nov 2022 13:30:04 +0000 0 4 <p>Hi <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rovarga" class="user-hover" rel="rovarga">rovarga</a> , please could you check this issue if this is the expected behavior or we need fixes so that we can look in to it.</p> <p>Added the below error messages in logs if a payload with invalid ip/invalid hostname is munted:</p> <p>            ERROR | opendaylight-cluster-data-notification-dispatcher-34 | NetconfTopologyManager | 289 - org.opendaylight.netconf.topology-singleton - 2.0.14 | Unable to connect to device Uri{_nodeId} ,invalid payload</p> <p>ERROR | opendaylight-cluster-data-notification-dispatcher-55 | NetconfTopologyManager | 289 - org.opendaylight.netconf.topology-singleton - 2.0.14 | Unable to connect to device Uri{_nodeId} ,invalid payload</p> <p> </p> <p>Added error logs if a device is mounted with multiple node id's:</p> <p>ERROR | opendaylight-cluster-data-notification-dispatcher-41 | NetconfTopologyManager | 289 - org.opendaylight.netconf.topology-singleton - 2.0.14 | RemoteDevice{Uri{_nodeId}} was already configured</p> <p>This needs triaging on current master.</p> <p>I have sent a request with the payload as bellow</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> {   <span class="code-quote">"node"</span>: {     <span class="code-quote">"node-id"</span>: <span class="code-quote">"test-node"</span>,     <span class="code-quote">"netconf-node-topology:host"</span>: <span class="code-quote">"192.168.56.28"</span>,     <span class="code-quote">"netconf-node-topology:port"</span>: <span class="code-quote">"17830"</span>,     <span class="code-quote">"netconf-node-topology:username"</span>:<span class="code-quote">"admin"</span>,     <span class="code-quote">"netconf-node-topology:password"</span>:<span class="code-quote">"admin"</span>,     <span class="code-quote">"netconf-node-topology:tcp-only"</span>:<span class="code-quote">"<span class="code-keyword">false</span>"</span>,     <span class="code-quote">"netconf-node-topology:keepalive-delay"</span>: <span class="code-quote">"0"</span>   } }</pre> </div></div> <p>and with the hostname in the payload</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> {   <span class="code-quote">"node"</span>: {     <span class="code-quote">"node-id"</span>: <span class="code-quote">"test-node"</span>,     <span class="code-quote">"netconf-node-topology:host"</span>: <span class="code-quote">"admin4"</span>,     <span class="code-quote">"netconf-node-topology:port"</span>: <span class="code-quote">"17830"</span>,     <span class="code-quote">"netconf-node-topology:username"</span>:<span class="code-quote">"admin"</span>,     <span class="code-quote">"netconf-node-topology:password"</span>:<span class="code-quote">"admin"</span>,     <span class="code-quote">"netconf-node-topology:tcp-only"</span>:<span class="code-quote">"<span class="code-keyword">false</span>"</span>,     <span class="code-quote">"netconf-node-topology:keepalive-delay"</span>: <span class="code-quote">"0"</span>   } } </pre> </div></div> <p>in both cases connection was established successfully, and everything works well</p> <p><em>host</em> in payload is validated according to topology node YANG model, thus:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Mounting a device with invalid ip in the payload -  Payload is not validated and the device is not prevented from mounting. Also no error messages logged</pre> </div></div> <p>is not valid bug report.</p> <p>We were able to mount device using hostname in <em>host</em>, thus:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Mounting with host name in payload - If we provided host name of the device in &lt;host&gt; field in payload, mounting is not happening.</pre> </div></div> <p>is not valid bug report.</p> <p>I was able to create two nodes with the same IP and different node-id</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> {     <span class="code-quote">"network-topology:topology"</span>: [         {             <span class="code-quote">"topology-id"</span>: <span class="code-quote">"topology-netconf"</span>,             <span class="code-quote">"node"</span>: [                 {                     <span class="code-quote">"node-id"</span>: <span class="code-quote">"test-node-1"</span>,                     <span class="code-quote">"netconf-node-topology:connection-status"</span>: <span class="code-quote">"connected"</span>,                     <span class="code-quote">"netconf-node-topology:username"</span>: <span class="code-quote">"admin"</span>,                     <span class="code-quote">"netconf-node-topology:password"</span>: <span class="code-quote">"admin"</span>,                     <span class="code-quote">"netconf-node-topology:available-capabilities"</span>: {                         <span class="code-quote">"available-capability"</span>: [                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:capability:exi:1.0"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:capability:candidate:1.0"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:base:1.0"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:base:1.1"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:opendaylight:params:xml:ns:yang:netconf:monitoring?revision=2022-07-18)odl-netconf-monitoring"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:ietf:params:xml:ns:yang:ietf-yang-types?revision=2013-07-15)ietf-yang-types"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:ietf:params:xml:ns:yang:ietf-inet-types?revision=2013-07-15)ietf-inet-types"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring?revision=2010-10-04)ietf-netconf-monitoring"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             }                         ]                     },                     <span class="code-quote">"netconf-node-topology:host"</span>: <span class="code-quote">"192.168.56.28"</span>,                     <span class="code-quote">"netconf-node-topology:port"</span>: 17830,                     <span class="code-quote">"netconf-node-topology:clustered-connection-status"</span>: {                         <span class="code-quote">"netconf-master-node"</span>: <span class="code-quote">"akka:<span class="code-comment">//opendaylight-cluster-data@192.168.56.25:2550"</span> </span>                    },                     <span class="code-quote">"netconf-node-topology:tcp-only"</span>: <span class="code-keyword">false</span>,                     <span class="code-quote">"netconf-node-topology:keepalive-delay"</span>: 0                 },                 {                     <span class="code-quote">"node-id"</span>: <span class="code-quote">"test-node-2"</span>,                     <span class="code-quote">"netconf-node-topology:connection-status"</span>: <span class="code-quote">"connected"</span>,                     <span class="code-quote">"netconf-node-topology:username"</span>: <span class="code-quote">"admin"</span>,                     <span class="code-quote">"netconf-node-topology:password"</span>: <span class="code-quote">"admin"</span>,                     <span class="code-quote">"netconf-node-topology:available-capabilities"</span>: {                         <span class="code-quote">"available-capability"</span>: [                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:capability:exi:1.0"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:capability:candidate:1.0"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:base:1.0"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"urn:ietf:params:netconf:base:1.1"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:opendaylight:params:xml:ns:yang:netconf:monitoring?revision=2022-07-18)odl-netconf-monitoring"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:ietf:params:xml:ns:yang:ietf-yang-types?revision=2013-07-15)ietf-yang-types"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:ietf:params:xml:ns:yang:ietf-inet-types?revision=2013-07-15)ietf-inet-types"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             },                             {                                 <span class="code-quote">"capability"</span>: <span class="code-quote">"(urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring?revision=2010-10-04)ietf-netconf-monitoring"</span>,                                 <span class="code-quote">"capability-origin"</span>: <span class="code-quote">"device-advertised"</span>                             }                         ]                     },                     <span class="code-quote">"netconf-node-topology:host"</span>: <span class="code-quote">"192.168.56.28"</span>,                     <span class="code-quote">"netconf-node-topology:port"</span>: 17830,                     <span class="code-quote">"netconf-node-topology:clustered-connection-status"</span>: {                         <span class="code-quote">"netconf-master-node"</span>: <span class="code-quote">"akka:<span class="code-comment">//opendaylight-cluster-data@192.168.56.25:2550"</span> </span>                    },                     <span class="code-quote">"netconf-node-topology:tcp-only"</span>: <span class="code-keyword">false</span>,                     <span class="code-quote">"netconf-node-topology:keepalive-delay"</span>: 0                 }             ]         }     ] } </pre> </div></div> <p>the error is caused by patch <a href="https://git.opendaylight.org/gerrit/c/netconf/+/100400" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/100400</a></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rohiniambika" class="user-hover" rel="rohiniambika">rohiniambika</a> Can you please provide steps to reproduce the NullPointerException?</p> <p>NPE is there because </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">final</span> NetconfNode netconfNode = requireNonNull(node.augmentation(NetconfNode.class));</pre> </div></div> <p>The node is not correct NetconfNode for unknown reasons. It can be missing feature installation or cluster misconfiguration. No idea...</p> <p>Cannot reproduce the issue. Config data are validated according to YANG model, devices are connected successfully. In addition, some sort of problems reported here are caused by "patch" provided by bug reporter.</p> Development Rank 0|i041lj: