OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [NETCONF-888] Make netconf maximum chunk size value configurable https://jira.opendaylight.org/browse/NETCONF-888 netconf <p>Now for changing the maximum chunk size value, we have to change and rebuild the netconf package, it will be good if we make the maximum chunk size configurable</p> NETCONF-888 Make netconf maximum chunk size value configurable Improvement Medium Resolved Done Daniel C Viswanathan Daniel C Viswanathan Wed, 29 Jun 2022 07:02:02 +0000 Mon, 22 Aug 2022 08:25:36 +0000 Thu, 18 Aug 2022 21:52:06 +0000 3.0.6 4.0.1 netconf 0 2 <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 2022-07-29T12:39:28,891 | DEBUG | sshd-NetconfSshClient[1aff52ad]-nio2-thread-7 | NettyAwareChannelSubsystem       | 302 - org.opendaylight.netconf.shaded-sshd - 1.13.8 | handleData(NettyAwareChannelSubsystem[id=0, recipient=0]-NetconfClientSessionImpl[0][netconf]) SSH_MSG_CHANNEL_DATA len=88 2022-07-29T12:39:29,022 | DEBUG | sshd-NetconfSshClient[1aff52ad]-nio2-thread-1 | NettyAwareChannelSubsystem       | 302 - org.opendaylight.netconf.shaded-sshd - 1.13.8 | handleData(NettyAwareChannelSubsystem[id=0, recipient=0]-NetconfClientSessionImpl[0][netconf]) SSH_MSG_CHANNEL_DATA len=4096 2022-07-29T12:39:29,022 | DEBUG | nioEventLoopGroupCloseable-3-1 | NetconfChunkAggregator           | 293 - org.opendaylight.netconf.netty-util - 1.13.8 | Parsed chunk size 17916488, maximum allowed is 16777216 2022-07-29T12:39:29,023 | WARN  | nioEventLoopGroupCloseable-3-1 | DefaultChannelPipeline           | 62 - io.netty.common - 4.1.69.Final | An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception. io.netty.handler.codec.DecoderException: java.lang.IllegalStateException: Maximum chunk size exceeded         at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:477) ~[bundleFile:4.1.69.Final]         at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276) ~[bundleFile:4.1.69.Final]         at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [bundleFile:4.1.69.Final]         at io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:61) [bundleFile:4.1.69.Final]         at io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:370) [bundleFile:4.1.69.Final]         at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) [bundleFile:4.1.69.Final]         at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469) [bundleFile:4.1.69.Final]         at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500) [bundleFile:4.1.69.Final]         at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) [bundleFile:4.1.69.Final]         at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [bundleFile:4.1.69.Final]         at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [bundleFile:4.1.69.Final]         at java.lang.<span class="code-object">Thread</span>.run(<span class="code-object">Thread</span>.java:829) [?:?] Caused by: java.lang.IllegalStateException: Maximum chunk size exceeded         at org.opendaylight.netconf.nettyutil.handler.NetconfChunkAggregator.checkChunkSize(NetconfChunkAggregator.java:63) ~[bundleFile:?]         at org.opendaylight.netconf.nettyutil.handler.NetconfChunkAggregator.decode(NetconfChunkAggregator.java:103) ~[bundleFile:?]         at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:507) ~[bundleFile:4.1.69.Final]         at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:446) ~[bundleFile:4.1.69.Final]         ... 11 more 2022-07-29T12:39:29,069 | DEBUG | sshd-NetconfSshClient[1aff52ad]-nio2-thread-2 | NettyAwareChannelSubsystem       | 302 - org.opendaylight.netconf.shaded-sshd - 1.13.8 | handleData(NettyAwareChannelSubsystem[id=0, recipient=0]-NetconfClientSessionImpl[0][netconf]) SSH_MSG_CHANNEL_DATA len=4096 2022-07-29T12:39:29,070 | DEBUG | nioEventLoopGroupCloseable-3-1 | NetconfChunkAggregator           | 293 - org.opendaylight.netconf.netty-util - 1.13.8 | Buffer has 8181 bytes, need 17916488 to complete chunk 2022-07-29T12:39:29,070 | DEBUG | sshd-NetconfSshClient[1aff52ad]-nio2-thread-2 | NettyAwareChannelSubsystem       | 302 - org.opendaylight.netconf.shaded-sshd - 1.13.8 | handleData(NettyAwareChannelSubsystem[id=0, recipient=0]-NetconfClientSessionImpl[0][netconf]) SSH_MSG_CHANNEL_DATA len=4096 2022-07-29T12:39:29,070 | DEBUG | nioEventLoopGroupCloseable-3-1 | NetconfChunkAggregator           | 293 - org.opendaylight.netconf.netty-util - 1.13.8 | Buffer has 8181 bytes, need 17916488 to complete chunk 2022-07-29T12:39:29,070 | DEBUG | nioEventLoopGroupCloseable-3-1 | NetconfChunkAggregator           | 293 - org.opendaylight.netconf.netty-util - 1.13.8 | Buffer has 12277 bytes, need 17916488 to complete chunk 2022-07-29T12:39:29,114 | DEBUG | sshd-NetconfSshClient[1aff52ad]-nio2-thread-3 | NettyAwareChannelSubsystem       | 302 - org.opendaylight.netconf.shaded-sshd - 1.13.8 | handleData(NettyAwareChannelSubsystem[id=0, recipient=0]-NetconfClientSessionImpl[0][netconf]) SSH_MSG_CHANNEL_DATA len=4096</pre> </div></div> <p>Right, so this this chunk size on the inbound side, hence this needs to only touch NetconfChunkAggregator.</p> <p>I have updated the baseline patch, but this needs a lot more work to make complete. The issue is that the system property is a global thing, affecting all sessions, client and server, irrespective of their mature. Remaining items:</p> <ol> <li><a href="https://git.opendaylight.org/gerrit/c/netconf/+/101924" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/netconf/+/101924</a> allows a client's setting to be changed, we need a similar thing for NetconfServerSessionNegotiator</li> <li>netconf-topology and netconf-topology-singleton both need to be updated to have the ability to specify this maximum for each device – i.e. update their configuration .yang file and route that information to netconf-client</li> <li>callhome (not sure where) needs to be updated to take advantage of the facility created in 1.</li> <li>mdsal-netconf-ssh needs to do the same as callhome, except the tuneable needs to go through NetconfConfiguration (and be properly routed from properties, just as other things are)</li> </ol> <p>Thank you for the update, Robert.<br/> I will look into the remaining items.</p> Issue split NETCONF-897 NETCONF-898 Development Rank 0|i042lr: