https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETCONF-967 netconf <ol> <li>run karaf</li> <li>install odl-netconf-topology odl-restconf-nb odl-yanglib</li> <li>connect testtool (it downloads its models to cache/schema)</li> <li>try to access, for example: GET: <a href="http://localhost:8181/yanglib/schemas/ietf-yang-types/2013-07-15" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/yanglib/schemas/ietf-yang-types/2013-07-15</a></li> </ol> <p>The requests fails with the error (see karaf.log). After restart the requests succeeds.</p> NETCONF-967

YangLib: Unable to get schema SourceIdentifier

Bug Medium Confirmed Unresolved Ivan Hrasko Ivan Hrasko pick-next pt Tue, 14 Feb 2023 07:32:45 +0000 Thu, 17 Aug 2023 08:09:40 +0000 0 2 <p>The problem is that <b>YangLibProvider#schemaSourceRegistered()</b> method is invoked only when:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> schemaListenerRegistration = schemaRepository.registerSchemaSourceListener(<span class="code-keyword">this</span>);</pre> </div></div> <p>is invoked. Currently this happens in <b>init()</b> method.</p> <p>We can solve the issue similar way how its done in <b>DefaultSchemaResourceManager#getSchemaResources()</b> where repository, listeners, etc. are registered on demand.</p> <p>Possible there are other problems:</p> <ul> <li><b>YangLibProvider</b> is not registered in <b>AbstractSchemaRepository</b>'s listeners field. In fact, its being registered but it looks that we have multiple <b>AbstractSchemaRepository</b> instances running.</li> <li><b>AbstractSchemaSourceCache</b>#<b>schemaSourceRegistered</b> is being invoked when new files are added dring runtime - but the method does nothing with it.</li> </ul> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> schemaRepository = <span class="code-keyword">new</span> SharedSchemaRepository(<span class="code-quote">"yang-library"</span>, parserFactory); <span class="code-keyword">final</span> <span class="code-keyword">var</span> cache = <span class="code-keyword">new</span> FilesystemSchemaSourceCache&lt;&gt;(schemaRepository, YangTextSchemaSource.class, cacheFolderFile); schemaRepository.registerSchemaSourceListener(cache); schemaListenerRegistration = schemaRepository.registerSchemaSourceListener(<span class="code-keyword">this</span>); </pre> </div></div> <ul> <li>repository uses cache to access the data and to update the data</li> <li>cache is filled on initialization using data from dir then never read</li> <li>cache is a listener for repository, it means cache is only updated on repository event (which never occurs)</li> <li>for yanglib to accept changes from testtool (assuming same dir usage) <ul> <li>these components have to share same repository instance</li> <li>or cache functionality needs update to watch the directory changes</li> </ul> </li> </ul> Blocks NETCONF-968 Development Rank 0|i044bz: