https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETVIRT-1291 netvirt <p>Running performance and scale tests that create 100s of neutron resources like networks, subnets, ports and routers as well as launching VMs on the networks and waiting for the environment to quiesce, we observe some new transaction leaks based on Michael Vorburger's mdsal-trace tool.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">24x transactions opened here, which are not closed:   (...)   org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)   (...)   org.opendaylight.netvirt.fibmanager.VrfEntryListener.lambda$populateFibOnNewDpn$17(VrfEntryListener.java:1575)   org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:416)   org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60)</pre> </div></div> NETVIRT-1291

New transaction leak in netvirt.fibmanager.VrfEntryListener

Bug Medium Resolved Done Stephen Kitt Sai Sindhur Malleni Fri, 1 Jun 2018 14:58:53 +0000 Wed, 25 Jul 2018 15:33:01 +0000 Mon, 23 Jul 2018 09:15:52 +0000 Oxygen Oxygen-SR2 Fluorine 0 3 <p>That is already plugged on master by <a href="https://git.opendaylight.org/gerrit/#/c/71591/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/71591/</a>. The stable/oxygen branch of VrfEntryListener for some reason seems to be quite different from master, and still has some dataBroker.newWriteOnlyTransaction() - or may be recently re-introduced by E// friends.</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> shall I cherry-pick your c/71591 from master to stable/oxygen or do you want to?</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=shague" class="user-hover" rel="shague">shague</a> FYI.</p> <p>I’ll take care of the cherry-pick.</p> <p>closing this one, as both oxygen and master changes are merged now.</p> <p><a href="https://jira.opendaylight.org/browse/NETVIRT-1384" title="Umbrella: Numerous new transaction leaks" class="issue-link" data-issue-key="NETVIRT-1384"><del>NETVIRT-1384</del></a> also has this one (among many others). That is surprising, given this has fix version Oxygen-SR2, isn't it? Perhaps the the fix version is just wrong - I'll change this to SR3 (and Fluorine), and cross fingers.</p> <p>Actually what shows up in <a href="https://jira.opendaylight.org/browse/NETVIRT-1384" title="Umbrella: Numerous new transaction leaks" class="issue-link" data-issue-key="NETVIRT-1384"><del>NETVIRT-1384</del></a> also is also in VrfEntryListener, but not identical - it's 258x VrfEntryListener$CleanupVpnInterfaceWorker.call(VrfEntryListener.java:1295), which uses callWithNewReadWriteTransactionAndSubmit .. already managed. So I'm changing the Fix Version back to SR2 which was probably right. All good then, nothing to see here.</p> Blocks NETVIRT-1384 Development Rank 0|i03f7r: