https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETVIRT-1503 netvirt <p>I'm looking at a Java Flight Recording obtained from (internal) scale lab testing, based on Oxygen SR3 code, and was wondering if the following code path which appears as a big "TLAB allocation" could be optimized:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">void java.util.regex.Matcher.&lt;init&gt;(Pattern, CharSequence) 7491 Matcher java.util.regex.Pattern.matcher(CharSequence) 7491 void org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid.&lt;init&gt;(<span class="code-object">String</span>) 6932 <span class="code-object">Object</span> java.lang.invoke.LambdaForm$DMH.167258716.newInvokeSpecial_L_L(<span class="code-object">Object</span>, <span class="code-object">Object</span>) 6638 <span class="code-object">Object</span> java.lang.invoke.LambdaForm$BMH.900683535.reinvoke(<span class="code-object">Object</span>, <span class="code-object">Object</span>) 6638 <span class="code-object">Object</span> java.lang.invoke.LambdaForm$MH.242644271.invokeExact_MT(<span class="code-object">Object</span>, <span class="code-object">Object</span>, <span class="code-object">Object</span>) 6638 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.EncapsulatedValueCodec.deserialize(<span class="code-object">Object</span>) 6638 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.LeafNodeCodecContext.deserializeObject(NormalizedNode) 6630 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.DataObjectCodecContext.getBindingChildValue(Method, NormalizedNodeContainer) 6630 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.KeyedListNodeCodecContext.getBindingChildValue(Method, NormalizedNodeContainer) 6630 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.LazyDataObject.getBindingData(Method) 6630 <span class="code-object">Object</span> org.opendaylight.mdsal.binding.dom.codec.impl.LazyDataObject.invoke(<span class="code-object">Object</span>, Method, <span class="code-object">Object</span>[]) 6160 Uuid com.sun.proxy.$Proxy453.getRouterId() 3063 Uuid org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.getVpnForRouter(Uuid, <span class="code-object">Boolean</span>) 3063 void org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener.handleRouterInterfaceAdded(Port) 1654 void org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener.add(InstanceIdentifier, Port) 1654 void org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener.add(InstanceIdentifier, DataObject) 1654 void org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run() 1654 void java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor$Worker) 1654 void java.util.concurrent.ThreadPoolExecutor$Worker.run() 1654 void java.lang.<span class="code-object">Thread</span>.run() 1654</pre> </div></div> NETVIRT-1503

Extensive object allocation from Uuid Matcher

Bug Medium Resolved Done Michael Vorburger Michael Vorburger Tue, 13 Nov 2018 13:31:35 +0000 Fri, 23 Nov 2018 13:56:05 +0000 Fri, 23 Nov 2018 13:56:05 +0000 Oxygen-SR3 Fluorine-SR2 Neon 0 2 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=vorburger" class="user-hover" rel="vorburger">vorburger</a> yes, multiple options:</p> <ol> <li>use Stream.anyMatch() instead of full list materialization followed by a List.contains()</li> <li>realize this is a primary key, so issue a read()+exists() requests before doing further processing</li> </ol> <p> </p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> would you be willing to self assign this issue to you, review <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=rovarga" class="user-hover" rel="rovarga">rovarga</a>'s proposed change for this (big Thank You!), take care of pack-porting that (and potentially getting it d/s'd, if we don't rebase) or should we look for someone else to own this one?</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/77904" class="external-link" target="_blank" rel="nofollow noopener">c/77904</a> cherry-picked from Neon to Fluorine. <a href="https://github.com/opendaylight/netvirt/blob/stable/oxygen/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java" class="external-link" target="_blank" rel="nofollow noopener">Oxygen code is quite different</a> (above was found on Oxygen).</p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> on email said he was "looking into the regexes in Uuid", so assigning to him.</p> <p>&gt;  <a href="https://github.com/opendaylight/netvirt/blob/stable/oxygen/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java" class="external-link" target="_blank" rel="nofollow noopener">Oxygen code is quite different</a> (above was found on Oxygen)</p> <p>I'm removing Oxygen from Fix Version for this one (<a href="https://git.opendaylight.org/gerrit/#/c/77904" class="external-link" target="_blank" rel="nofollow noopener">c/77904</a> is in Neon and Fluorine); you win some, loose some!</p> Development Rank 0|i03kfz: