<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 20:21:05 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[NETVIRT-248] Sg - Missing src and dst port in learn rule for All Tcp and All Udp</title>
                <link>https://jira.opendaylight.org/browse/NETVIRT-248</link>
                <project id="10144" key="NETVIRT">netvirt</project>
                    <description>&lt;p&gt;Description:&lt;br/&gt;
*************&lt;br/&gt;
Lunch 2 vms in same network and different Hosts:&lt;br/&gt;
vm_x(Sg1=egress for Tcp 80+ALL tcp),vm_y(Sg2=All protocol - ingress&amp;amp;Egress).&lt;/p&gt;

&lt;p&gt;Action&lt;br/&gt;
*******&lt;br/&gt;
Try to open ssh from vm_x-&amp;gt;vm_y   - succeed &lt;br/&gt;
Try to open ssh from vm_y-&amp;gt;vm_x   - succeed (should fail!!!)&lt;/p&gt;

&lt;p&gt;Defect&lt;br/&gt;
******&lt;br/&gt;
As it can be seen in All Tcp rule in table 42,no src and dst port.&lt;br/&gt;
This cause to condition that packets from external vm can send packets on learn rule.&lt;/p&gt;

&lt;p&gt;Note!!&lt;br/&gt;
*******&lt;br/&gt;
Need to check for both All Tcp and All Icmp&lt;/p&gt;


&lt;p&gt;root@devstack-man21-zan:~# ovs-ofctl dump-flows -OOpenFlow13  br-int  | grep table=42&lt;br/&gt;
cookie=0x6900000, duration=1056.458s, table=42, n_packets=0, n_bytes=0, priority=61010,reg5=0x1 actions=resubmit(,17)&lt;br/&gt;
cookie=0x6900000, duration=446.635s, table=42, n_packets=0, n_bytes=0, priority=61010,tcp,metadata=0x40000000000/0x1fffff0000000000,tp_dst=80 actions=learn(table=252,idle_timeout=18000,fin_idle_timeout=300,priority=61010,cookie=0x6900000,eth_type=0x800,nw_proto=6,NXM_OF_IP_SRC[]=NXM_OF_IP_DST[],NXM_OF_TCP_SRC[]=NXM_OF_TCP_DST[],NXM_OF_IP_DST[]=NXM_OF_IP_SRC[],NXM_OF_TCP_DST[]=NXM_OF_TCP_SRC[],load:0x1-&amp;gt;NXM_NX_REG5&lt;span class=&quot;error&quot;&gt;&amp;#91;0..7&amp;#93;&lt;/span&gt;),resubmit(,17)&lt;br/&gt;
cookie=0x6900000, duration=446.635s, table=42, n_packets=15, n_bytes=2506, priority=61010,tcp,metadata=0x40000000000/0x1fffff0000000000 actions=learn(table=252,idle_timeout=300,priority=61010,cookie=0x6900000,eth_type=0x800,NXM_OF_IP_SRC[]=NXM_OF_IP_DST[],NXM_OF_IP_DST[]=NXM_OF_IP_SRC[],NXM_OF_IP_PROTO[],load:0x1-&amp;gt;NXM_NX_REG5&lt;span class=&quot;error&quot;&gt;&amp;#91;0..7&amp;#93;&lt;/span&gt;),resubmit(,17)&lt;br/&gt;
cookie=0x6900000, duration=1056.615s, table=42, n_packets=15, n_bytes=1418, priority=0 actions=drop&lt;/p&gt;</description>
                <environment>&lt;p&gt;Operating System: All&lt;br/&gt;
Platform: All&lt;/p&gt;</environment>
        <key id="20169">NETVIRT-248</key>
            <summary>Sg - Missing src and dst port in learn rule for All Tcp and All Udp</summary>
                <type id="10104" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10303&amp;avatarType=issuetype">Bug</type>
                                                <status id="5" iconUrl="https://jira.opendaylight.org/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="alonko@hpe.com">Alon Kochba</assignee>
                                    <reporter username="zan.cohen@hpe.com">zan cohen</reporter>
                        <labels>
                    </labels>
                <created>Mon, 7 Nov 2016 15:18:47 +0000</created>
                <updated>Tue, 15 Nov 2016 14:39:30 +0000</updated>
                            <resolved>Tue, 15 Nov 2016 14:39:30 +0000</resolved>
                                    <version>Boron</version>
                                                    <component>General</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="36670" author="zan.cohen@hpe.com" created="Mon, 7 Nov 2016 15:25:29 +0000"  >&lt;p&gt;Attachment port missing in rule.docx has been added with description: Missing information in All tcp rule&lt;/p&gt;</comment>
                            <comment id="36671" author="zan.cohen@hpe.com" created="Mon, 7 Nov 2016 15:28:46 +0000"  >&lt;p&gt;Attachment screen-karaf.zip has been added with description: Karaf logs&lt;/p&gt;</comment>
                            <comment id="36668" author="alonko@hpe.com" created="Tue, 8 Nov 2016 17:35:00 +0000"  >&lt;p&gt;Nice find.&lt;br/&gt;
First major bug (regression) - in LearnIngressAcl/LearnEgressAcl, we check ifTcp or ifUdp according to existence of src/dst port match. This is wrong, we should check if ip_proto = TCP or UDP, since for all ports we dont set a src/dst at all&lt;/p&gt;

&lt;p&gt;This raises another issue, though we might have to live with it as a known issue - if you were to configure an egress ALLOW ALL IP rule, the same would happen, and the above proposal would not fix it.&lt;br/&gt;
Of course this only happens if you already SSHed in from vm_x-&amp;gt;vm_y, and until the idle timeout expires.&lt;/p&gt;</comment>
                            <comment id="36669" author="alonko@hpe.com" created="Tue, 15 Nov 2016 14:39:30 +0000"  >&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/48135/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/48135/&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="12293" name="port missing in rule.docx" size="13559" author="zan.cohen@hpe.com" created="Mon, 7 Nov 2016 15:25:29 +0000"/>
                            <attachment id="12294" name="screen-karaf.zip" size="645039" author="zan.cohen@hpe.com" created="Mon, 7 Nov 2016 15:28:46 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10208" key="com.atlassian.jira.plugin.system.customfieldtypes:textfield">
                        <customfieldname>External issue ID</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7105</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10201" key="com.atlassian.jira.plugin.system.customfieldtypes:url">
                        <customfieldname>External issue URL</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[https://bugs.opendaylight.org/show_bug.cgi?id=7105]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i01qmn:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>