https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NETVIRT-514 netvirt <p>Found in CSIT: <a href="https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-upstream-stateful-carbon/157/archives/odl1_karaf.log.gz" class="external-link" target="_blank" rel="nofollow noopener">https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-upstream-stateful-carbon/157/archives/odl1_karaf.log.gz</a></p> <p>2017-03-06 15:58:07,231 | INFO | pool-53-thread-1 | NeutronvpnManager | 370 - org.opendaylight.netvirt.neutronvpn-impl - 0.4.0.SNAPSHOT | Creating vpn interface VpnInterface [_key=VpnInterfaceKey <span class="error">&#91;_name=79979446175186:br-physnet1-pa:flat&#93;</span>, _name=79979446175186:br-physnet1-pa:flat, _vpnInstanceName=023a3b1a-e4a9-4a32-b985-08890eca2d61, _isRouterInterface=false, augmentation=[]]<br/> 2017-03-06 15:58:07,231 | INFO | pool-53-thread-1 | NeutronvpnManager | 370 - org.opendaylight.netvirt.neutronvpn-impl - 0.4.0.SNAPSHOT | Creating vpn interface VpnInterface [_key=VpnInterfaceKey <span class="error">&#91;_name=52979261036746:br-physnet1-pa:flat&#93;</span>, _name=52979261036746:br-physnet1-pa:flat, _vpnInstanceName=023a3b1a-e4a9-4a32-b985-08890eca2d61, _isRouterInterface=false, augmentation=[]]<br/> 2017-03-06 15:58:07,231 | INFO | pool-53-thread-1 | NeutronvpnManager | 370 - org.opendaylight.netvirt.neutronvpn-impl - 0.4.0.SNAPSHOT | Creating vpn interface VpnInterface [_key=VpnInterfaceKey <span class="error">&#91;_name=198622229657920:br-physnet1-pa:flat&#93;</span>, _name=198622229657920:br-physnet1-pa:flat, _vpnInstanceName=023a3b1a-e4a9-4a32-b985-08890eca2d61, _isRouterInterface=false, augmentation=[]]<br/> 2017-03-06 15:58:07,236 | ERROR | pool-53-thread-1 | QosInterfaceStateChangeListener | 377 - org.opendaylight.netvirt.qosservice-impl - 0.4.0.SNAPSHOT | Qos:Exception caught in Interface Operational State Up event<br/> java.lang.IllegalArgumentException: Supplied value "198622229657920:br-physnet1-pa:flat" does not match required pattern "^<span class="error">&#91;0-9a-fA-F&#93;</span></p> {8}<del><span class="error">&#91;0-9a-fA-F&#93;</span>{4}-<span class="error">&#91;0-9a-fA-F&#93;</span>{4}</del><span class="error">&#91;0-9a-fA-F&#93;</span>{4}-<span class="error">&#91;0-9a-fA-F&#93;</span>{12}$"<br/> at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)<span class="error">&#91;65:com.google.guava:18.0.0&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid.&lt;init&gt;(Uuid.java:55)<span class="error">&#91;81:org.opendaylight.mdsal.model.ietf-yang-types-20130715:2013.7.15.10-SNAPSHOT&#93;</span><br/> at org.opendaylight.netvirt.qosservice.QosInterfaceStateChangeListener.add(QosInterfaceStateChangeListener.java:68)<span class="error">&#91;377:org.opendaylight.netvirt.qosservice-impl:0.4.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netvirt.qosservice.QosInterfaceStateChangeListener.add(QosInterfaceStateChangeListener.java:31)<span class="error">&#91;377:org.opendaylight.netvirt.qosservice-impl:0.4.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run(AsyncDataTreeChangeListenerBase.java:143)<span class="error">&#91;328:org.opendaylight.genius.mdsalutil-api:0.2.0.SNAPSHOT&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.lang.Thread.run(Thread.java:745)<span class="error">&#91;:1.8.0_121&#93;</span><br/> 2017-03-06 15:58:07,237 | INFO | nPool-1-worker-1 | sedEgressServicesStateBindHelper | 358 - org.opendaylight.genius.interfacemanager-impl - 0.2.0.SNAPSHOT | bind all egress services for vlan port: 198622229657920:br-physnet1-pa:flat<br/> 2017-03-06 15:58:07,237 | ERROR | pool-53-thread-1 | QosInterfaceStateChangeListener | 377 - org.opendaylight.netvirt.qosservice-impl - 0.4.0.SNAPSHOT | Qos:Exception caught in Interface Operational State Up event<br/> java.lang.IllegalArgumentException: Supplied value "52979261036746:br-physnet1-pa:flat" does not match required pattern "^<span class="error">&#91;0-9a-fA-F&#93;</span>{8} <p>-<span class="error">&#91;0-9a-fA-F&#93;</span></p> {4}-<span class="error">&#91;0-9a-fA-F&#93;</span>{4} <p>-<span class="error">&#91;0-9a-fA-F&#93;</span></p> {4} <p>-<span class="error">&#91;0-9a-fA-F&#93;</span></p> {12} <p>$"<br/> at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)<span class="error">&#91;65:com.google.guava:18.0.0&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid.&lt;init&gt;(Uuid.java:55)<span class="error">&#91;81:org.opendaylight.mdsal.model.ietf-yang-types-20130715:2013.7.15.10-SNAPSHOT&#93;</span><br/> at org.opendaylight.netvirt.qosservice.QosInterfaceStateChangeListener.add(QosInterfaceStateChangeListener.java:68)<span class="error">&#91;377:org.opendaylight.netvirt.qosservice-impl:0.4.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.netvirt.qosservice.QosInterfaceStateChangeListener.add(QosInterfaceStateChangeListener.java:31)<span class="error">&#91;377:org.opendaylight.netvirt.qosservice-impl:0.4.0.SNAPSHOT&#93;</span><br/> at org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run(AsyncDataTreeChangeListenerBase.java:143)<span class="error">&#91;328:org.opendaylight.genius.mdsalutil-api:0.2.0.SNAPSHOT&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)<span class="error">&#91;:1.8.0_121&#93;</span><br/> at java.lang.Thread.run(Thread.java:745)<span class="error">&#91;:1.8.0_121&#93;</span></p> <p>Operating System: All<br/> Platform: All</p> NETVIRT-514

QosInterfaceStateChangeListener: java.lang.IllegalArgumentException

Bug Resolved Done Vamsi krishna Janki Chhatbar Tue, 7 Mar 2017 10:18:22 +0000 Mon, 30 Oct 2017 16:55:36 +0000 Thu, 30 Mar 2017 13:54:05 +0000 Carbon General 0 6 <p>I've just hit this too, while starting to learn OpenStack with OpenDaylight using my <a href="https://github.com/vorburger/openstack-devstack-opendaylight-vagrant/" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/vorburger/openstack-devstack-opendaylight-vagrant/</a> ..</p> <p>The message a slightly different in my case, but basically same problem:</p> <p>Supplied value "tap61d7aec1-2c" does not match required pattern ...</p> <p>I've had a quick look at the code in QosInterfaceStateChangeListener.add, and basically that code assumes that it can do new Uuid(Interface.getName()) which is most probably wrong - Interface.getName() clearly is NOT, always, guaranteed, to be a valid UUID (above it's "198622229657920:br-physnet1-pa:flat", in my case it's "tap61d7aec1-2c") .. </p> <p>Obviously I don't understand anything of this code, but I do see that INeutronVpnManager's Port getNeutronPort(Uuid portId) has an alternative Port getNeutronPort(String name) variant - should that be used instead? Is that "name" an Interface.getName() ? Or could you get the UUID from the Interface's getPhysAddress(), somehow?</p> <p>PS: In general, these kind of conversions to String are a bad idea .. ideally, everything should be "strongly typed" - should INeutronVpnManager perhaps directly have a getNeutronPort taken an Interface arg?</p> <p>&gt; INeutronVpnManager's Port getNeutronPort(Uuid portId) has an alternative Port &gt; getNeutronPort(String name) variant - should that be used instead? </p> <p>no that was a stupid idea - org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.getNeutronPort(String) internally just does a new Uuid(name), so this would not solve the problem.</p> <p>&gt; Or could you get the UUID from the Interface's getPhysAddress(), somehow?</p> <p>that's probably the right fix here - but how to you obtain that UUID from an Interface?</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/53118/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/53118/</a></p> <p>Possible future enhancement (not short term) resulting from this code in <a href="https://git.opendaylight.org/gerrit/#/c/53363/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/53363/</a> &amp; <a href="https://jira.opendaylight.org/browse/MDSAL-239" title="YANG gen. binding classes with Optional&lt;XYZ&gt; newXYZIfValidPattern() kind of utility factory method" class="issue-link" data-issue-key="MDSAL-239"><del>MDSAL-239</del></a> and <a href="https://jira.opendaylight.org/browse/MDSAL-238" title="YANG gen. binding classes should offer a matches(CharSequence input) [or expose Pattern[] patterns public instead private]" class="issue-link" data-issue-key="MDSAL-238"><del>MDSAL-238</del></a>.</p> <p>Could you cherry-pick this fix to stable/boron also?</p> <p>&gt; Could you cherry-pick this fix to stable/boron also?</p> <p>==&gt; <a href="https://git.opendaylight.org/gerrit/#/c/53975/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/53975/</a></p> <p>It was more of a "manual reconstruct" than an actual simple technical git cherry-pick, as (apparently) the code has moved to another bundle (vpnservice/qosservice VS vpnservice/neutronvpn/neutronvpn-impl), and looked quite different in stable/boron, you may want to carefully review c/53975 ...</p> Duplicate GENIUS-63 Development External issue ID 7913 External issue URL Rank 0|i01s9r: Status Whiteboard csit:exception