https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NEUTRON-116 neutron <p>The problem occur when working with liberty devstack.</p> <p>How to reproduce:</p> <p>1)<br/> create a security-group<br/> remove one of it's default rule</p> <p>neutron security-group-create sg1<br/> neutron security-group-rule-delete &lt;uuid&gt; # one of the dafault rules</p> <p>When deleting neutron security group rules, NeutronSecurityRule object is null in neutronSecurityRuleDeleted method.</p> <p>2)<br/> create a security-group<br/> remove the security-group (securityRules list will contain null values)</p> <p>neutron security-group-create sg1<br/> neutron security-group-delete sg1</p> <p>This also happens when deleting security groups. Security rules in NeutronSecurityGroup object are also null in neutronSecurityGroupDeleted method.</p> <p>Operating System: All<br/> Platform: All</p> NEUTRON-116

Null values received on neutron security-group-rule-delete and security-group-delete

Bug Resolved Done Unassigned Tomas Cechvala Wed, 9 Mar 2016 09:45:30 +0000 Thu, 19 Oct 2017 21:24:59 +0000 Wed, 3 Aug 2016 15:00:27 +0000 Multiple neutron-spi 0 3 <p>on #2<br/> securityRules in NeutronSecurityGroup is a list with null values in it.</p> <p>This seems like related to <a href="https://bugs.opendaylight.org/show_bug.cgi?id=4550" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=4550</a></p> <p>So can you please try <br/> <a href="https://git.opendaylight.org/gerrit/#/c/33957" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33957</a></p> <p>For Boron, the direction is to delete securitygroup::securitygrouprules because<br/> it's backpointer instead of maintaining data integrity.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/35837/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/35837/</a><br/> The patch isn't ready for merge yet, though.</p> <p>The patch was merged into master branch.<br/> The expected result is</p> <ul class="alternate" type="square"> <li>on I*Aware interface, security-group:security-rules should be populated.</li> <li>on MD-SAL model, security-group:security-rules is always [] (empty list).</li> </ul> <p>If your code is using MD-SAL, you need to listen to data change notification of security rules in addition to security-group rules. and check security-rule:security-group-id.</p> <p>In boron cycle, security-group:security-rules will be deleted.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/35837/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/35837/</a></p> <p>Attachment command sequence.txt has been added with description: Devstack commands</p> <p>Attachment mikita-beryllium_karaflog.log has been added with description: karaf.log</p> <p>Attachment mikita-master_karaflog.log has been added with description: karaf.log</p> <p>Attachment mikita-master_karaflog_patch33957.log has been added with description: karaf log</p> <p>I'm not quite sure if I follow, let me attach karaf.log for more info.<br/> Neutron mapper was set on trace.<br/> log:set TRACE org.opendaylight.groupbasedpolicy.neutron.mapper</p> <p>When removing a security-group, it’s rules are missing in NeutronSecurityGroup object. Please notice canDeleteNeutronSecurityGroup message<br/> in master:<br/> securityRules=[]<br/> in beryllium:<br/> securityRules=<span class="error">&#91;null, null&#93;</span></p> <p>When removing just a rule, it comes to us as null. Please notice canDeleteNeutronSecurityRule. It behaves the same in master and beryllium.</p> <p>Unfortunately patch <a href="https://git.opendaylight.org/gerrit/#/c/33957" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/33957</a> didn't change this behavior.</p> <p>what version of networking-odlare you using?</p> <p>Does it include the merged patch into master?<br/> <a href="https://review.openstack.org/#/c/281621/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/281621/</a></p> <p>Can you please provide the packet capture between networking-odl and ODL?</p> <p>With Beryllium, did you apply the patch to beryllium branch?<br/> the log doesn't seem so.</p> <p>Can you please check it?</p> <p>For beryllium, the proposed patch is found at<br/> <a href="https://git.opendaylight.org/gerrit/#/c/34586" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/34586</a></p> <p>Patch for handling the default rules associated with a security group<br/> <a href="https://git.opendaylight.org/gerrit/#/c/36466/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/36466/</a></p> <p>The problem still persits,</p> <p>I checked out neutron beryllium patch <a href="https://git.opendaylight.org/gerrit/#/c/34586" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/34586</a></p> <p>Networking-odl master patch was included as well<br/> <a href="https://review.openstack.org/#/c/281621/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/281621/</a></p> <p>I'm not sure if packet capture can get us closer, but i'm going to attach it.<br/> Is there a package for which setting log to TRACE would help? Were you gents able to replicate this with GBP?</p> <p>The following features should be installed<br/> odl-groupbasedpolicy-neutronmapper<br/> odl-restconf<br/> and log set to trace<br/> log:set TRACE org.opendaylight.groupbasedpolicy.neutron.mapper</p> <p>What i've tried</p> <p>neutron net-create net1 (just to test logging)<br/> neutron security-group-create sg1<br/> neutron security-group-delete sg1 (no rules in NeutronSecurityGroup object and no other notification about removing the rules)<br/> neutron security-group-create sg2<br/> neutron security-group-rule-list (to find one of defaults for sg2)<br/> neutron security-group-rule-delete &lt;rule_uuid&gt; (NeutronSecurityRule object is null)</p> <p>logs looks the same as before.</p> <p>192.168.50.1 - ODL, 192.168.50.20 - Devstack Control Node</p> <p>Attachment testing_sg.pcap has been added with description: Wireshark capture on devstack-control</p> <p>Thanks, the remaining issues is null as NeutornSecurityRule.<br/> There are </p> <ul class="alternate" type="square"> <li>one patches for boron,</li> <li>two patches for stable/beryllium(will be SR2)</li> <li>one patch for networking-odl mitaka.</li> </ul> <p>details: </p> <p>It will be addressed by the following patch.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/36467/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/36467/</a><br/> This is for master branch.(and also picked for beryllium SR2)<br/> There is an issue for networking-odl that it doesn't send request to create/delete default rules on group creation/deletion.<br/> It is being addressed now.<br/> <a href="https://review.openstack.org/#/c/294451/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/294451/</a><br/> The fix will goes in networking-odl Mitaka</p> <p>As stable/beryllium which support liberty, the work around patch will be needed.<br/> The patch is at<br/> <a href="https://git.opendaylight.org/gerrit/#/c/36466/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/36466/</a></p> <p>I've tested mitaka-boron with</p> <p>neutron patch (already in master):<br/> <a href="https://git.opendaylight.org/gerrit/#/c/36467/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/36467/</a></p> <p>networking-odl patch:<br/> <a href="https://review.openstack.org/#/c/294451/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/294451/</a></p> <p>I don't recommend to merge networking-odl patch. An exception occurred in ODL everytime security-group was created (neutron security-group-create sg-name). Please, see error message.</p> <p>I tried to test again but without networking-odl patch.<br/> The only difference is that no notification came to ODL when default security-group-rule was removed.</p> <p>Attachment error_in_log.txt has been added with description: error after neutron security-group-create sg123</p> <p>I've just tested again with<br/> <a href="https://review.openstack.org/#/c/294451/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/294451/</a><br/> <a href="https://review.openstack.org/#/c/294423/" class="external-link" target="_blank" rel="nofollow noopener">https://review.openstack.org/#/c/294423/</a><br/> and everything seem to be working, thanks.</p> <p>@Tomas, thank you for test.<br/> Once those patches are merged, let's close it.</p> <p>As it's tested and there is no further comments. let's close this.<br/> If there is anything, feel free to re-open this.</p> Development External issue ID 5478 External issue URL Issue Type ODL SR Target Milestone Priority Rank 0|i02ut3: