https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NEUTRON-185 neutron NEUTRON-185

SFC PortPairGroup dependency checking (NeutronSFCPortPairGroupInterface)

Sub-task NEUTRON-158 Medium Open Unresolved Unassigned Michael Vorburger Tue, 31 Jul 2018 16:16:29 +0000 Mon, 13 Aug 2018 12:43:14 +0000 0 1 <p>as discussed today, based on <a href="https://github.com/openstack/networking-odl/blob/179fa53a8e6f60609068df5c1f4f058181b2f928/networking_odl/journal/dependency_validations.py#L121" class="external-link" target="_blank" rel="nofollow noopener">dependency_validations.py</a> :</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>def _generate_sfc_port_pair_deps(data): object_ids = [] ingress_port = data.get('ingress') if ingress_port is not None: object_ids.append(ingress_port) egress_port = data.get('egress') if egress_port is not None: object_ids.append(egress_port) return object_ids</pre> </div></div> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=thapar" class="user-hover" rel="thapar">thapar</a>, <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=mpeterson" class="user-hover" rel="mpeterson">mpeterson</a>, <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=jhershbe" class="user-hover" rel="jhershbe">jhershbe</a>, <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=mkolesni%40redhat.com" class="user-hover" rel="mkolesni@redhat.com">mkolesni@redhat.com</a> anything else to consider for this entity?</p> <p>there seems to be a mismatch between the title and the code you put in the comment.</p> <p>The right one for this would be  _generate_sfc_port_pair_group_deps of the same file.</p> <p>Oups, yeah - above is for <a href="https://jira.opendaylight.org/browse/NEUTRON-186" title="SFC PortPair dependency checking (NeutronSFCPortPairInterface)" class="issue-link" data-issue-key="NEUTRON-186">NEUTRON-186</a> wherewas for this (port pair GROUP) it's just:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>def _generate_sfc_port_pair_group_deps(data): return data['port_pairs']</pre> </div></div> <p>In general also deletion deps need to be considered</p> <p>FYI we agreed that we first want to finally make progress for create/update, and then do delete after - watch <a href="https://jira.opendaylight.org/browse/NEUTRON-195" title="Framework for delete dependency checking" class="issue-link" data-issue-key="NEUTRON-195">NEUTRON-195</a>.</p> <p>gotcha, missed that bit. Thanks</p> Blocks NEUTRON-186 Development Rank 0|i03hh3: