https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NEUTRON-205 neutron <p>The Neutron build fails in <tt>integration-test-standalone</tt> due to <tt>junit.framework.AssertionFailedError: Classpath duplicates detected: javax/inject/Inject.class</tt>.</p> <p>This is from the (infrautils) <a href="https://javadocs.opendaylight.org/org.opendaylight.infrautils/neon/org/opendaylight/infrautils/testutils/ClasspathHellDuplicatesCheckRule.html" class="external-link" target="_blank" rel="nofollow noopener">ClasspathHellDuplicatesCheckRule</a> used in the <tt>NeutronE2ETest</tt>.</p> <p>Fixing this properly is important in light of <a href="https://github.com/vorburger/opendaylight-simple/" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/vorburger/opendaylight-simple/</a> where a clean "flat" classpath is even more critical tomorrow than it is today in standalone tests.</p> NEUTRON-205

Classpath duplicates detected: javax/inject/Inject.class

Bug Medium Resolved Done Michael Vorburger Michael Vorburger Fri, 9 Nov 2018 13:57:01 +0000 Fri, 9 Nov 2018 21:38:43 +0000 Fri, 9 Nov 2018 21:38:43 +0000 Neon Neon 0 1 <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> fixed (worked around) this with <a href="https://git.opendaylight.org/gerrit/#/c/77327/1/integration/test-standalone/pom.xml" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/77327/1/integration/test-standalone/pom.xml</a> but then it regressed again .. I suspect that was probably <a href="https://git.opendaylight.org/gerrit/#/c/76625/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/76625/</a> for <a href="https://jira.opendaylight.org/browse/INFRAUTILS-52" title="jHades doesn’t support JDK 9+" class="issue-link" data-issue-key="INFRAUTILS-52"><del>INFRAUTILS-52</del></a> - which is now doing classpath duplicate analysis a little differently, but better, than before. Because it's right to point out that this isn't clean:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>junit.framework.AssertionFailedError: Classpath duplicates detected: javax/inject/Inject.class jar:file:/home/vorburger/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar!/javax/inject/Inject.class jar:file:/home/vorburger/.m2/repository/org/glassfish/hk2/external/javax.inject/2.5.0-b32/javax.inject-2.5.0-b32.jar!/javax/inject/Inject.class</pre> </div></div> <p>We could add more exclusions in the POM of integration-test-standalone, but let's try to fix this up at source...</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/77654/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/77654/</a> fixes this problem (locally tested).</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/77655/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/77655/</a> adds non-regression testing for this problem.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/77654/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/77654/</a> <a href="https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/aaa-distribution-check-neon/65/console.log.gz" class="external-link" target="_blank" rel="nofollow noopener">fails in aaa-distribution-check-neon</a> due to:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>missing requirement [org.glassfish.jersey.containers.jersey-container-servlet-core/2.25.1] osgi.wiring.package; filter:="(&amp;(osgi.wiring.package=javax.inject)(version&gt;=1.0.0)(!(version&gt;=2.0.0)))"</pre> </div></div> <p>I think that's probably because the OSGi bundle org.glassfish.jersey.containers.jersey-container-servlet-core (2.25.1) has a non-optional Package-Import for javax.inject, but we made javax.inject:javax.inject &lt;optional&gt;true in odlparent, and somewhere excluded it? (But we do include org.glassfish.hk2.external:javax.inject, so that whole optional and exclusion is really a bit useless after all.)</p> <p>This isn't really worth my time to dig more into and somehow fix more properly... let's just add javax.inject to ClasspathHellDuplicatesCheckRule's ignore white list; so proposed in <a href="https://git.opendaylight.org/gerrit/#/c/77658/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/77658/</a> now.</p> <p>I suspect the previous JHades instead of ClassGraph based implementation probably ignored it because it had the same size (<a href="https://git.opendaylight.org/gerrit/#/c/76625/8/testutils/src/main/java/org/opendaylight/infrautils/testutils/ClasspathHellDuplicatesCheckRule.java" class="external-link" target="_blank" rel="nofollow noopener">note boolean excludeSameSizeDups = true</a>); if we have a lot more problems like this, we would have to re-emulate that size checking behaviour in the ClasspathHellDuplicatesChecker...</p> Relates INFRAUTILS-52 Development Rank 0|i03kaf: