https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/NEUTRON-54 neutron <p>in neutron-spi/src/main/java/org/opendaylight/neutron/spi/NeutronNetwork.java, Null Pointer Exception while converting from Boolean to Boolean as:</p> <p>example:</p> <p> public boolean isAdminStateUp() </p> { return adminStateUp; } <p>//Null Pointer Exception when adminStateUp is null.</p> <p>Test Case:</p> <p>vagrant@node1:~/neutron$ cat TestA.java; javac TestA.java ; java TestA<br/> public class TestA {<br/> Boolean adminStateUp;</p> <p> public boolean isAdminStateUp() </p> { return adminStateUp; } <p> public static void main(String[] args) {<br/> TestA a = new TestA();<br/> if (a.isAdminStateUp()) </p> { System.out.println("here"); } <p> }<br/> }<br/> Exception in thread "main" java.lang.NullPointerException<br/> at TestA.isAdminStateUp(TestA.java:5)<br/> at TestA.main(TestA.java:10)</p> <p>Operating System: All<br/> Platform: All</p> NEUTRON-54

Null Pointer Exception while converting from Boolean to boolean

Bug Resolved Won't Do Ruijing Guo Ruijing Guo Thu, 9 Jul 2015 03:47:19 +0000 Thu, 11 Feb 2016 14:05:31 +0000 Thu, 11 Feb 2016 14:05:31 +0000 master neutron-spi 0 2 <p>This applies to other classes in the directory.<br/> We should address consistently as a whole. </p> <p>There is two interfaces</p> <ul class="alternate" type="square"> <li>boolean isXXX() with implicit conversion<br/> It may results in null pointer exception.</li> <li>Boolean getXXX() may return null pointer with the current implementation.<br/> Is null pointer check the responsibility of the caller?</li> </ul> <p>possible approach I can think of would be</p> <ul class="alternate" type="square"> <li>add default initialization value.<br/> i.e. Boolean adminStateUp = false</li> </ul> <p> This changes the semantics of Boolean getXXX(). it doesn't return null anymore.<br/> If we go for this route, other T getXXX() should have same semantics.<br/> (where T = String, Interger etc.)</p> <ul class="alternate" type="square"> <li>add null pointer check to all of boolean isXXX()</li> </ul> <ul class="alternate" type="square"> <li>Drop all of boolean isXXX()</li> </ul> <ul class="alternate" type="square"> <li>any other better way?</li> </ul> <p>thoughts?</p> <p>in NeutronNetwork.java, I like to change:</p> <p>1. Change public initDefaults to private function and construction call initDefaults</p> <p>2. deprecated instead of drop isXXX or getXXX.</p> <p>The following would work, too:</p> <p> public boolean isAdminStateUp() </p> { return Boolean.TRUE.equals(adminStateUp); } <p>The question is whether you need to differentiate the tri-state nature (up, down, unknown?). If not, I would suggest also changing the field type to 'boolean', as that is more memory-efficient.</p> <p>Since this issue was hit during Ruijing was working on his modification and there is no actual impact on the existing code.<br/> So we won't fix this bug.</p> <p>If this is hit as actual bug, please re-open this bug.</p> Development External issue ID 3968 External issue URL Rank 0|i02ufb: