https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-1 odlparent <p>we want to be able to add JVM args to the controller like gc:verbose, but currently we can only add -X args</p> <p>Operating System: All<br/> Platform: PC</p> ODLPARENT-1

allow adding non -X JVM args

Improvement Verified Done Vratko Polak David Goldberg Wed, 2 Apr 2014 09:09:52 +0000 Mon, 6 Sep 2021 09:27:57 +0000 Mon, 6 Sep 2021 09:27:57 +0000 General 0 6 <p>We do support -D options as well. Though it seems the "help" (usage) message for run.sh lies. it states that all extra parameters will be passed to the JVM, but in reality if it is a matching argument, and doesn't start with -D or -X then it fails the run.</p> <p>Sounds like we should just make the run.sh/run.bat do what the usage says - any non-special opts get passed to the JVM directly instead of failing to run.</p> <p><a href="https://jira.opendaylight.org/browse/CONTROLLER-303" title="Set additional OOB JVM Settings in Run.sh scripts" class="issue-link" data-issue-key="CONTROLLER-303"><del>CONTROLLER-303</del></a> was created to add more OOB parameters to the scripts. Consider doing these defects at the same time.</p> <p>This needs to be revisited for Karaf based distribution if we still have problem with it.</p> <p>Added as blocking issue for Topic: Decrease Technical Debt.</p> <p>Is this really a bug for "controller" project (as opposed to "integration project)?</p> <p>The Karaf way of changing JVM parameters seem to be Service Wrapper.<br/> karaf.apache.org/manual/latest/users-guide/wrapper.html</p> <p>We should pick one way of setting JVM parameters, document it in Developer Guide (or somewhere else) and deprecate workarounds as those described in <a href="https://jira.opendaylight.org/browse/INTDIST-20" title="When starting karaf with arguments meant for jvm they are ignored" class="issue-link" data-issue-key="INTDIST-20"><del>INTEGRAT-20</del></a>.</p> <p>And finally, current Karaf defaults seem to be a little low for current ODL needs, so it would be good idea to add something to ODL build process that would override or edit various Karaf files.</p> <p>&gt; Is this really a bug for "controller" project (as opposed to "integration<br/> &gt; project)?</p> <p>Oh, now I see that for some reason, Karaf resources are located in "distribution" subdirectory in controller repository. So until they are moved to integration, this remains to be a controller bug.</p> <p>Back to JVM args. Quick patch for stable/helium branch: <a href="https://git.opendaylight.org/gerrit/#/c/13685/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/13685/</a></p> <p>Not sure if such patch suffices for Lithium.</p> <p>This bug is part of the project to Move all ADSAL associated component bugs to ADSAL</p> <p>Moving to karaf as it is really about modifying the karaf start scripts to allow other arguments be passed to JVM, and not anything specifically tied to ADSAL.</p> <p>Check with karaf to see if karaf passes environment variables to JVM.</p> <p>&gt; if karaf passes environment variables to JVM</p> <p>It does pass some of them, mainly JAVA_OPTS.<br/> But I believe this Bug refers to command-line arguments. Currently all arguments to bin/karaf are understood as arguments to Karaf (as opposed to JVM). Even the -X* arguments do not work now.<br/> On the other hand, there is bin/setenv as another place users can edit in their options.</p> <p>I believe most user are now familiar with Karaf ways, so this may be set to WONTFIX. Especially considering that Version is specified to be Helium.</p> <p>Agreed; setting to "RESOLVED", "WONTFIX".</p> <p>Resurrecting this as a contribution is available: <a href="https://git.opendaylight.org/gerrit/47062" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/47062</a></p> <p>Since Nitrogen, realized by patching the karaf script, for example see <span class="error">&#91;1&#93;</span>.</p> <p><span class="error">&#91;1&#93;</span> <a href="https://github.com/opendaylight/odlparent/blob/release/nitrogen/karaf/opendaylight-karaf-resources/src/main/patches/karaf-karaf-4.0.9.patch#L67-L70" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/odlparent/blob/release/nitrogen/karaf/opendaylight-karaf-resources/src/main/patches/karaf-karaf-4.0.9.patch#L67-L70</a></p> Blocks MDSAL-55 Development External issue ID 647 External issue URL Issue Type Priority Rank 0|i022p3: