https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-101 odlparent <p>Would be better to document that "patch" needs to be on execution path for building on windows</p> <p><span class="error">&#91;INFO&#93;</span> ODL :: genius :: fcapsapplication .................. SUCCESS [ 0.863 s]<br/> <span class="error">&#91;INFO&#93;</span> ODL :: genius :: resourcemanager-aggregator ........ SUCCESS [ 0.839 s]<br/> <span class="error">&#91;INFO&#93;</span> ODL :: genius :: genius-karaf4 ..................... FAILURE <span class="error">&#91;34:46 min&#93;</span><br/> <span class="error">&#91;INFO&#93;</span> ODL :: genius :: genius-it ......................... SKIPPED<br/> <span class="error">&#91;INFO&#93;</span> genius ............................................. SKIPPED<br/> <span class="error">&#91;INFO&#93;</span> ------------------------------------------------------------------------<br/> <span class="error">&#91;INFO&#93;</span> BUILD FAILURE<br/> <span class="error">&#91;INFO&#93;</span> ------------------------------------------------------------------------<br/> <span class="error">&#91;INFO&#93;</span> Total time: 45:54 min<br/> <span class="error">&#91;INFO&#93;</span> Finished at: 2017-06-13T05:42:08+05:30<br/> <span class="error">&#91;INFO&#93;</span> Final Memory: 362M/927M<br/> <span class="error">&#91;INFO&#93;</span> ------------------------------------------------------------------------<br/> <span class="error">&#91;ERROR&#93;</span> Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (patch-karaf-scripts) on project genius-karaf4: An Ant BuildException has occured: java.io.IOException: Cannot run progra<br/> m "patch" (in directory "C:\Users\efaseel\odl_boron\genius\karaf4"): CreateProcess error=2, The system cannot find the file specified<br/> <span class="error">&#91;ERROR&#93;</span> around Ant part ...&lt;patch patchfile="C:\Users\efaseel\odl_boron\genius\karaf4\target/assembly/patches/karaf-instance.patch" originalfile="C:\Users\efaseel\odl_boron\genius\karaf4\target/assembly/bi<br/> n/instance" failonerror="true"/&gt;... @ 5:213 in C:\Users\efaseel\odl_boron\genius\karaf4\target\antrun\build-main.xml<br/> <span class="error">&#91;ERROR&#93;</span> -&gt; <span class="error">&#91;Help 1&#93;</span><br/> <span class="error">&#91;ERROR&#93;</span><br/> <span class="error">&#91;ERROR&#93;</span> To see the full stack trace of the errors, re-run Maven with the -e switch.<br/> <span class="error">&#91;ERROR&#93;</span> Re-run Maven using the -X switch to enable full debug logging.<br/> <span class="error">&#91;ERROR&#93;</span><br/> <span class="error">&#91;ERROR&#93;</span> For more information about the errors and possible solutions, please read the following articles:<br/> <span class="error">&#91;ERROR&#93;</span> <span class="error">&#91;Help 1&#93;</span> <a href="http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException" class="external-link" target="_blank" rel="nofollow noopener">http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException</a><br/> <span class="error">&#91;ERROR&#93;</span><br/> <span class="error">&#91;ERROR&#93;</span> After correcting the problems, you can resume the build with the command<br/> <span class="error">&#91;ERROR&#93;</span> mvn &lt;goals&gt; -rf :genius-karaf4</p> <p>Operating System: All<br/> Platform: All</p> ODLPARENT-101

Karaf 4 distribution local build fails on Windows (missing "patch")

Bug Resolved Done Unassigned Faseela K Tue, 13 Jun 2017 10:37:51 +0000 Wed, 24 Jan 2018 14:26:40 +0000 Tue, 4 Jul 2017 09:34:47 +0000 2.0.5 General 0 2 <p>This is because <a href="https://ant.apache.org/manual/Tasks/patch.html" class="external-link" target="_blank" rel="nofollow noopener">https://ant.apache.org/manual/Tasks/patch.html</a> 'requires "patch" to be on the execution path' - which Windows does not have.</p> <p>Running ODL mvn under "Git Bash" &lt;<a href="https://git-for-windows.github.io" class="external-link" target="_blank" rel="nofollow noopener">https://git-for-windows.github.io</a>&gt; on Windows, or Cygwin &lt;<a href="https://www.cygwin.com" class="external-link" target="_blank" rel="nofollow noopener">https://www.cygwin.com</a>&gt; is a workaround to get around this (Bug reporter has confirmed on IRC this works for her).</p> <p>I'm not crystal clear on why this is a Karaf 4 specific problem (or is it not and locally building Karaf distributions never worked on Windows) - didn't we patch configuration files with Karaf 3 already? Or did we do it "earlier" there, during the odlparent build, not each project? (Would it be imaginable to do something similar for Karaf 4 again?)</p> <p>Linking, as Faseela found this in <a href="https://jira.opendaylight.org/browse/GENIUS-82" title="Karaf4 specific problems seen on both boot and during manual testing of genius distribution" class="issue-link" data-issue-key="GENIUS-82"><del>GENIUS-82</del></a> testing. It does not strictly "block" testing, as there is the described workaround - but at the least it's confusing to Windows users - if some day we can find a way to avoid that, it would be better.</p> <p>(In reply to Michael Vorburger from comment #1)<br/> &gt; I'm not crystal clear on why this is a Karaf 4 specific problem (or is it<br/> &gt; not and locally building Karaf distributions never worked on Windows) -<br/> &gt; didn't we patch configuration files with Karaf 3 already? Or did we do it<br/> &gt; "earlier" there, during the odlparent build, not each project? (Would it be<br/> &gt; imaginable to do something similar for Karaf 4 again?)</p> <p>We carried patched Karaf files in our repositories, which isn’t really maintainable in the long term. (Although I’m sure some people would argue over that — it really depends on how comfortable you are with patch management tools.)</p> <p>&gt; if some day we can find a way to avoid that, it would be better</p> <p>I guess "fixing" this would come down to either:</p> <p> (a) doing the 'patch' earlier during the build, like have this happen during odlparent's build and keep the result as an artifact used by projects, without them have to run patch</p> <p> (b) replacing <a href="https://ant.apache.org/manual/Tasks/patch.html" class="external-link" target="_blank" rel="nofollow noopener">https://ant.apache.org/manual/Tasks/patch.html</a> with a pure Java implementation? In <a href="https://github.com/opendaylight/mdsal/blob/af55eed5432a28761ef474175933779de7f3a13e/binding/mdsal-binding-test-utils/src/main/java/org/opendaylight/mdsal/binding/testutils/DiffUtil.java" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/mdsal/blob/af55eed5432a28761ef474175933779de7f3a13e/binding/mdsal-binding-test-utils/src/main/java/org/opendaylight/mdsal/binding/testutils/DiffUtil.java</a> (which is related to <a href="https://github.com/vorburger/xtendbeans" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/vorburger/xtendbeans</a>) I've used a "difflib" found on Maven central which can do "diff" and AFAIK also "patch" in Java, so if someone is motivated to wrap that as an Ant task...</p> <p>&gt; (a) doing the 'patch' earlier during the build</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/59486/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/59486/</a></p> <p><a href="https://git.opendaylight.org/gerrit/#/c/59922/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/59922/</a></p> <p><a href="https://git.opendaylight.org/gerrit/#/c/59923/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/59923/</a></p> Blocks GENIUS-82 Development External issue ID 8677 External issue URL Rank 0|i023bb: