https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-13 odlparent <p>SingleFeatureTests currently can give false positives if:</p> <p>a) Your feature depends on a bundle that is built in your local repo<br/> b) Your features/pom.xml does not contain a dependency for that bundle.</p> <p>Example:</p> <p>example/foo/pom.xml<br/> example/features/pom.xml<br/> example/features/src/main/features/features.xml</p> <p>If your features.xml contains a feature:</p> <p>&lt;feature bar&gt;<br/> &lt;bundle&gt;foo&lt;/bundle&gt;<br/> &lt;/features&gt;</p> <p>and you don't have a dependency for foo in features/pom.xml, then if you build<br/> example/ (as happens on merge and verify) then SingleFeatureTests will succeed, because karaf will be able to find the foo bundle in ~/.m2 because you built it, but downstream projects (like integration) will <b>not</b> get foo pulled into their ~/.m2 and will fail.</p> <p>We need to think up a way to also catch this case.</p> <p>Operating System: All<br/> Platform: All</p> ODLPARENT-13

Increase SingleFeatureTest coverage to insure all dependencies in pom.xml file

Bug Resolved Won't Do Robert Varga Ed Warnicke Thu, 12 Mar 2015 17:31:11 +0000 Wed, 24 Jan 2018 14:27:06 +0000 Thu, 3 Sep 2015 12:16:36 +0000 General 0 2 <p>This actually should not be tested by the test, but rather be part of the feature's build time &#8211; and it actually is. How it works is the following:</p> <p>That bundle declaration needs to contain a version declaration. While you can hard-code one, that really is not the right way to do it, you should use a <tt>VERSION</tt> placeholder.</p> <p>features-parent will notice that placeholder and will reference to the project's dependencies, checking that the specified bundle/feature/configfile is declared, erroring out if it isn't &#8211; see how <a href="https://git.opendaylight.org/gerrit/#/c/23524/4" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/23524/4</a> failed to build due to features-bmp not having a dependency on features-bgp.</p> <p>So the correct way to fix this is to convert features to use features-parent and <tt>VERSION</tt> placeholders.</p> <p>&gt;&gt; We need to think up a way to also catch this case.</p> <p>&gt; So the correct way to fix this is to convert features to use features-parent and <tt>VERSION</tt> placeholders.</p> <p>So, is there a new bug opened (instead of this wontfix one) requesting to automatically catch a case where a project fails to use features-parent and <tt>VERSION</tt> everywhere?</p> Blocks ODLPARENT-14 Development External issue ID 2826 External issue URL Issue Type ODL SR Target Milestone Rank 0|i022rr: