https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-137 odlparent <p>In <a href="https://lists.opendaylight.org/pipermail/dev/2018-January/004449.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/dev/2018-January/004449.html</a> <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=k.faseela" class="user-hover" rel="k.faseela">k.faseela</a> and <a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=thapar" class="user-hover" rel="thapar">thapar</a> raise that, following the odlparent bump from 2.0.6 to 3.0.2, the prompt in Karaf changed:</p> <blockquote><p>FYI, another thing it has changed impacting the CSIT is the karaf console prompt:</p> <ul class="alternate" type="square"> <li>It used to be: opendaylight-user at root&gt;</li> <li>And now it is: karaf at root()&gt;</li> </ul> <p>Because of this, some of the CSIT doing operations in karaf console are taking very long.</p> <p>Is there a way to come back to old format or should we change the tests for the new prompt?</p></blockquote> <p>and:</p> <blockquote><p>+1 to retaining older prompt, as I see genius CSIT failing with newer prompt on the genius only distribution which we are trying to verify locally.</p></blockquote> ODLPARENT-137

Karaf prompt does not start with opendaylight-user@ anymore

Bug High Resolved Done Stephen Kitt Michael Vorburger Wed, 17 Jan 2018 16:09:17 +0000 Wed, 5 Sep 2018 13:30:53 +0000 Wed, 5 Sep 2018 13:30:53 +0000 3.0.2 3.1.0 3.0.3 3.1.1 Karaf 0 4 <p>I've looked into this, and found that this <tt>opendaylight-user</tt> prompt is from our custom ODL Karaf branding, in <tt>odlparent/karaf/karaf-branding/src/main/resources/org/apache/karaf/branding/branding.properties</tt> (which FTR ends up in JAR, not in <tt>etc/branding.properties</tt>; that's why grep didn't immediately find it), whereas <tt>karaf@root()&gt;</tt> is simply the upstream default.</p> <p>That branding stuff hasn't changed in odlparent, and notably that ASCII art ODL logo thing still works... so digging further, I've found that the prompt customization branding support somehow broke upstream - so this is an impact of our Karaf bump. Let's see what they say over on <a href="https://issues.apache.org/jira/browse/KARAF-5570" class="external-link" target="_blank" rel="nofollow noopener">https://issues.apache.org/jira/browse/KARAF-5570</a> .. but even if fixed (by a contribution from me or anyone), the fix will most likely require going through a new Karaf release and bump in odlparent and odlparent release and all projects bumping to new odlparent... <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/wink.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>So in the short term, changing CSIT tests for the new prompt is the way to go IMHO.</p> <p> Not sure whether this is a centralized one line change for whole of integration/test though <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=vorburger" class="user-hover" rel="vorburger">vorburger</a> it would be just a one/few lines change if the prompt was changing across all versions of ODL, but we'd have to account<br/> for the fact that only oxygen+ would have this new prompt, while carbon and nitrogen will still use the old prompt. Not sure how easy it will<br/> be to change at this point. Seems like it might be our only option though.</p> <p> This is fixed by <a href="https://git.opendaylight.org/gerrit/67340" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/67340</a> in integration/distribution.</p> <p>I’ll add a fix in odlparent too (hence not moving this bug and not resolving it yet).</p> <p>At long last, the odlparent patch is ready: <a href="https://git.opendaylight.org/gerrit/70285" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/70285</a></p> <p><a href="https://jira.opendaylight.org/secure/ViewProfile.jspa?name=skitt" class="user-hover" rel="skitt">skitt</a> perhaps it would be useful to set the Fix Version on this appropriately - Flourine and Oxygen SP1, is it?</p> Development Rank 0|i039kv: