https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-262 odlparent <p>Attempting to run mutlple SFTs, i.e. feature.xml builds, on the same machine is going to lead into failures (the dreaded NotBoundException) due to concurrent Karaf invocation (I think, needs to be tested).<br/> Given that SFT is run through SureFire -&gt; Pax-Exam -&gt; Karaf, we may end up needing to rework this pipeline.</p> <p>Note that whatever solution we brew up here needs to be licensed under Apache-2.0 license as we will want to contribute it back to karaf (and not deal with maintaining it).</p> ODLPARENT-262

SingleFeatureTest needs to be safe to execute in parallel

New Feature High In Progress Unresolved Ruslan Kashapov Robert Varga pick-next pt Wed, 29 Sep 2021 01:33:46 +0000 Fri, 19 Jan 2024 08:30:29 +0000 14.0.0 13.0.11 SFT 0 2 <p>Looking at <a href="https://github.com/apache/karaf/blob/e1dde27b88303c78e1d94b3dddaca0ea177e59e5/itests/test/pom.xml#L297-L313" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/karaf/blob/e1dde27b88303c78e1d94b3dddaca0ea177e59e5/itests/test/pom.xml#L297-L313</a> it is clear this is not something solved in upstream and we will need to brew our own solution.</p> <p>In order to control when a Karaf instance is launched and when not, we will need to attach to Maven reactor, hence this will invariantly include a bespoke maven plugin.</p> <p>For maintaining reactor-global state we need to do something along the lines of <a href="https://github.com/fabric8io/docker-maven-plugin/issues/504" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/fabric8io/docker-maven-plugin/issues/504</a> which ends up needing to talk to <a href="https://maven.apache.org/ref/3.8.2/maven-core/apidocs/org/apache/maven/execution/MavenSession.html" class="external-link" target="_blank" rel="nofollow noopener">https://maven.apache.org/ref/3.8.2/maven-core/apidocs/org/apache/maven/execution/MavenSession.html</a> .</p> <p>That in turn gives us complete visibility into what the entirety of build looks like, with things like getCurrentProject() (hence no need for depends-maven-plugin), getProjects() and getPluginContext() – which should give us enough rope to implement what amounts to a Reactor-global lock we need to ensure there is no reactor-level concurrency around launching Karaf.</p> <p>For launching Karaf, that does not look like an involved operation: <a href="https://github.com/ops4j/org.ops4j.pax.exam2/blob/master/containers/pax-exam-container-karaf/src/main/java/org/ops4j/pax/exam/karaf/container/internal/KarafTestContainer.java#L129" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/ops4j/org.ops4j.pax.exam2/blob/master/containers/pax-exam-container-karaf/src/main/java/org/ops4j/pax/exam/karaf/container/internal/KarafTestContainer.java#L129</a> , hence we should be able to brew our own.</p> <p>All we really need for SFT is to install the needed features and then monitor Karaf and wait for it to settle. I thing all the things we collect in <font color="#000000">BundleDiagInfosImpl</font> should also be available through Karaf's serviceability features. Certainly the JMX information provided in osgi.core, org.apache.aries.blueprint and org.apache.karaf looks very promising.</p> <p>As a side note: policy as to whether karaf can be launched concurrently or not depends on networking ports being used.<br/> The first step there would be to reign in opendaylight-karaf-empty's, so that most of odlparent-packaged features can be tested concurrently – which would be an opt-in configured by the SFT-using artifact (based on knowledge of what is being tested). Based on that experience we may provide enough tools for at least some downstreams to the same.</p> <p>That work is out of scope for this issue, though: for now we will serialize all Karaf tests.</p> Blocks ODLPARENT-264 BGPCEP-425 Relates ODLPARENT-257 INFRAUTILS-12 Development Epic Link ODLPARENT-261 Rank 0|i03zrj: