https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-264 odlparent <p>We are getting this splat during parallel -Pq build:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[INFO] -----------&lt; org.opendaylight.odlparent:features-odlparent &gt;------------ [INFO] Building ODL :: odlparent :: features-odlparent 9.0.7-SNAPSHOT   [61/63] [INFO] ------------------------------[ feature ]------------------------------- [WARNING] ***************************************************************** [WARNING] * Your build is requesting parallel execution, but project      * [WARNING] * contains the following plugin(s) that have goals not marked   * [WARNING] * as @threadSafe to support parallel building.                  * [WARNING] * While this /may/ work fine, please look for plugin updates    * [WARNING] * and/or request plugins be made thread-safe.                   * [WARNING] * If reporting an issue, report it against the plugin in        * [WARNING] * question, not against maven-core                              * [WARNING] ***************************************************************** [WARNING] The following plugins are not marked @threadSafe in ODL :: odlparent :: features-odlparent: [WARNING] org.apache.servicemix.tooling:depends-maven-plugin:1.4.0 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe. [WARNING] ***************************************************************** </pre> </div></div> <p>Unfortunately <a href="https://github.com/apache/servicemix-maven-plugins" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/servicemix-maven-plugins</a> seems to be quite dead, so we may need to rework the integration completely.</p> ODLPARENT-264

Fix thread safety around depends-maven-plugin

Improvement Medium Confirmed Unresolved Unassigned Robert Varga pt Wed, 29 Sep 2021 10:10:02 +0000 Tue, 26 Dec 2023 17:34:00 +0000 14.0.0 13.0.11 SFT 0 2 <p>So this affects only SFT, hence may end up being a duplicate of <a href="https://jira.opendaylight.org/browse/ODLPARENT-262" title="SingleFeatureTest needs to be safe to execute in parallel" class="issue-link" data-issue-key="ODLPARENT-262">ODLPARENT-262</a>.</p> <p>It seems all usage of the plugin has to do with launching pax-exam from surefire. Perhaps we should provide a better alternative?</p> <p><b>depends-maven-plugin</b> is only used to determine current version of the SCR feature being preset for SFT.<br/> in code it looks like below (SingleFeatureTest#227)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-comment">// Install SCR </span>features(maven().groupId(<span class="code-quote">"org.apache.karaf.features"</span>).artifactId(<span class="code-quote">"standard"</span>).type(<span class="code-quote">"xml"</span>) .classifier(<span class="code-quote">"features"</span>).versionAsInProject(), <span class="code-quote">"scr"</span>), </pre> </div></div> <p>the <b>versionAsInProject()</b> is a pax-exam logic which relies on data from file <br/> target/classes/META-INF/maven/<b>dependencies.properties</b> generated by depends-maven-plugin</p> <p>in order to rid of dependency on this plugin we just need to provide the version directly<br/> with no invocation of versionAsInProject(). the simple substitution for gaining information about <br/> dependencies could be <b>maven-dependency-plugin:list</b> configured for execution on pre-test stage<br/> (test-compile) with output to a file which then can be parsed by test logic.</p> <p>this is being proposed as apart of solution for <a href="https://jira.opendaylight.org/browse/ODLPARENT-257" title="Allow SFT to use a test-only dependency" class="issue-link" data-issue-key="ODLPARENT-257"><del>ODLPARENT-257</del></a> <br/> see <a href="https://git.opendaylight.org/gerrit/c/odlparent/+/106844/3/abstract-feature-parent/pom.xml#87" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/c/odlparent/+/106844/3/abstract-feature-parent/pom.xml#87</a><br/> it makes sense to handle scr feature preset same way as test dependencies</p> <p>in further perspectives (if SFT is implemented as maven plugin) then dependencies can be handled internally</p> <p>SFT spawns karaf instances, which may access network ports and similar, hence <a href="https://jira.opendaylight.org/browse/ODLPARENT-262" title="SingleFeatureTest needs to be safe to execute in parallel" class="issue-link" data-issue-key="ODLPARENT-262">ODLPARENT-262</a> will introduce better wiring with maven, e.g. we can resolve these dependencies.</p> <p>That will render depends-maven-plugin obsolete.</p> Blocks ODLPARENT-262 Relates ODLPARENT-265 Development Epic Link ODLPARENT-261 Rank 0|i03zuf: