https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-43 odlparent <p>Karaf log has a lot of these kind of errors:</p> <p>2016-08-24 14:46:30,874 | ERROR | ime-limited test | BlueprintContainerImpl | 15 - org.apache.aries.blueprint.core - 1.6.1 | Unable to start blueprint container for bundle org.opendaylight.controller.netty-threadgroup-config/0.6.0.SNAPSHOT<br/> org.osgi.service.blueprint.container.ComponentDefinitionException: java.lang.RuntimeException<br/> at org.apache.aries.blueprint.container.ReferenceRecipe.internalCreate(ReferenceRecipe.java:123)<br/> at org.apache.aries.blueprint.di.AbstractRecipe$1.call(AbstractRecipe.java:79)<br/> at java.util.concurrent.FutureTask.run(FutureTask.java:266)<span class="error">&#91;:1.8.0_101&#93;</span><br/> at org.apache.aries.blueprint.di.AbstractRecipe.create(AbstractRecipe.java:88)<br/> at org.apache.aries.blueprint.container.BeanRecipe.setProperty(BeanRecipe.java:955)<br/> at org.apache.aries.blueprint.container.BeanRecipe.setProperties(BeanRecipe.java:929)<br/> at org.apache.aries.blueprint.container.BeanRecipe.setProperties(BeanRecipe.java:910)<br/> at org.apache.aries.blueprint.container.BeanRecipe.internalCreate2(BeanRecipe.java:844)<br/> at org.apache.aries.blueprint.container.BeanRecipe.internalCreate(BeanRecipe.java:811)<br/> at org.apache.aries.blueprint.di.AbstractRecipe$1.call(AbstractRecipe.java:79)<br/> at java.util.concurrent.FutureTask.run(FutureTask.java:266)<span class="error">&#91;:1.8.0_101&#93;</span><br/> at org.apache.aries.blueprint.di.AbstractRecipe.create(AbstractRecipe.java:88)<br/> at org.apache.aries.blueprint.container.BlueprintRepository.createInstances(BlueprintRepository.java:255)<br/> at org.apache.aries.blueprint.container.BlueprintRepository.createInstance(BlueprintRepository.java:233)<br/> at org.apache.aries.blueprint.container.BlueprintRepository.create(BlueprintRepository.java:158)<br/> at org.apache.aries.blueprint.container.BlueprintContainerImpl.processProcessors(BlueprintContainerImpl.java:568)<br/> at org.apache.aries.blueprint.container.BlueprintContainerImpl.doRun(BlueprintContainerImpl.java:395)<br/> at org.apache.aries.blueprint.container.BlueprintContainerImpl.run(BlueprintContainerImpl.java:276)<br/> at org.apache.aries.blueprint.container.BlueprintExtender.createContainer(BlueprintExtender.java:300)<br/> at org.apache.aries.blueprint.container.BlueprintExtender.createContainer(BlueprintExtender.java:269)<br/> at org.apache.aries.blueprint.container.BlueprintExtender.access$900(BlueprintExtender.java:68)<br/> at org.apache.aries.blueprint.container.BlueprintExtender$BlueprintContainerServiceImpl.createContainer(BlueprintExtender.java:602)<br/> at org.opendaylight.controller.blueprint.BlueprintBundleTracker.modifiedBundle(BlueprintBundleTracker.java:178)<br/> at org.opendaylight.controller.blueprint.BlueprintBundleTracker.addingBundle(BlueprintBundleTracker.java:159)<br/> at org.opendaylight.controller.blueprint.BlueprintBundleTracker.addingBundle(BlueprintBundleTracker.java:51)<br/> at org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:467)<span class="error">&#91;karaf-org.osgi.core.jar:&#93;</span><br/> at org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:414)<span class="error">&#91;karaf-org.osgi.core.jar:&#93;</span><br/> at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)<span class="error">&#91;karaf-org.osgi.core.jar:&#93;</span><br/> at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)<span class="error">&#91;karaf-org.osgi.core.jar:&#93;</span><br/> at org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:443)<span class="error">&#91;karaf-org.osgi.core.jar:&#93;</span><br/> at org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:868)<br/> at org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:789)<br/> at org.apache.felix.framework.util.EventDispatcher.fireBundleEvent(EventDispatcher.java:514)<br/> at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4403)<br/> at org.apache.felix.framework.Felix.startBundle(Felix.java:2092)<br/> at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:955)<br/> at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:942)<br/> at org.apache.karaf.features.internal.FeaturesServiceImpl.startBundle(FeaturesServiceImpl.java:516)<br/> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:474)<br/> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:415)<br/> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:390)<br/> at Proxy6f850cc9_21fb_49f2_a56b_4bdf6d389f68.installFeature(Unknown Source)<br/> at org.opendaylight.odlparent.featuretest.SingleFeatureTest.installFeature(SingleFeatureTest.java:308)<br/> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<span class="error">&#91;:1.8.0_101&#93;</span><br/> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)<span class="error">&#91;:1.8.0_101&#93;</span><br/> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<span class="error">&#91;:1.8.0_101&#93;</span><br/> at java.lang.reflect.Method.invoke(Method.java:498)<span class="error">&#91;:1.8.0_101&#93;</span><br/> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)<span class="error">&#91;53:org.ops4j.pax.tipi.junit:4.12.0.1&#93;</span><br/> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)<span class="error">&#91;53:org.ops4j.pax.tipi.junit:4.12.0.1&#93;</span><br/> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)<span class="error">&#91;53:org.ops4j.pax.tipi.junit:4.12.0.1&#93;</span><br/> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)<span class="error">&#91;53:org.ops4j.pax.tipi.junit:4.12.0.1&#93;</span><br/> at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)<span class="error">&#91;53:org.ops4j.pax.tipi.junit:4.12.0.1&#93;</span><br/> at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)<span class="error">&#91;53:org.ops4j.pax.tipi.junit:4.12.0.1&#93;</span><br/> at java.util.concurrent.FutureTask.run(FutureTask.java:266)<span class="error">&#91;:1.8.0_101&#93;</span><br/> at java.lang.Thread.run(Thread.java:745)<span class="error">&#91;:1.8.0_101&#93;</span><br/> Caused by: java.lang.RuntimeException<br/> at org.objectweb.asm.MethodVisitor.visitParameter(Unknown Source)<br/> at org.objectweb.asm.ClassReader.b(Unknown Source)<br/> at org.objectweb.asm.ClassReader.accept(Unknown Source)<br/> at org.objectweb.asm.ClassReader.accept(Unknown Source)<br/> at org.apache.aries.proxy.impl.common.AbstractWovenProxyAdapter.readClass(AbstractWovenProxyAdapter.java:683)<br/> at org.apache.aries.proxy.impl.interfaces.InterfaceCombiningClassAdapter.generateBytes(InterfaceCombiningClassAdapter.java:109)<br/> at org.apache.aries.proxy.impl.interfaces.ProxyClassLoader.createProxyClass(ProxyClassLoader.java:156)<br/> at org.apache.aries.proxy.impl.interfaces.InterfaceProxyGenerator.getProxyInstance(InterfaceProxyGenerator.java:95)<br/> at org.apache.aries.proxy.impl.AsmProxyManager.createNewProxy(AsmProxyManager.java:80)<br/> at org.apache.aries.proxy.impl.AbstractProxyManager.createDelegatingInterceptingProxy(AbstractProxyManager.java:75)<br/> at org.apache.aries.proxy.impl.AbstractProxyManager.createDelegatingProxy(AbstractProxyManager.java:40)<br/> at org.apache.aries.blueprint.container.AbstractServiceReferenceRecipe.createProxy(AbstractServiceReferenceRecipe.java:332)<br/> at org.apache.aries.blueprint.container.ReferenceRecipe.internalCreate(ReferenceRecipe.java:107)<br/> ... 54 more</p> <p>Operating System: All<br/> Platform: All</p> ODLPARENT-43

org.osgi.service.blueprint.container.ComponentDefinitionException Caused by: java.lang.RuntimeException at org.objectweb.asm.MethodVisitor.visitParameter

Bug Resolved Done Vratko Polak Michael Vorburger Wed, 24 Aug 2016 13:06:42 +0000 Wed, 24 Jan 2018 14:27:03 +0000 Tue, 7 Mar 2017 14:51:45 +0000 General 0 4 <p>I've analysed this; it seems to have something to do with (likely an older version of) the ASM bytecode manipulation library used by Apache Aries in Karaf (not directly OpenDaylight...) not being able to deal with the Java 8 javac -parameters option, introduced in <a href="https://git.opendaylight.org/gerrit/#/c/42515/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/42515/</a>.</p> <p>The best solution would be to upgrade to the latest available version of ASM, assuming that they have done a fix to make it Java 8 compliant. It would be to have a reference for this.</p> <p>We can see e.g. in an ODL Karaf's assembly/system/org/ow2/asm/asm-all (e.g. netvirt/vpnservice/distribution/karaf/target/assembly/system/org/ow2/asm/asm-all) that we appear to be on 5.0.3, which isn't that ancient actually; <a href="http://asm.ow2.org" class="external-link" target="_blank" rel="nofollow noopener">http://asm.ow2.org</a> shows a Recent News 5 March 2016: release of ASM 5.1.</p> <p>I've raised issue <a href="http://forge.ow2.org/tracker/?func=detail&amp;aid=317771&amp;group_id=23&amp;atid=100023" class="external-link" target="_blank" rel="nofollow noopener">http://forge.ow2.org/tracker/?func=detail&amp;aid=317771&amp;group_id=23&amp;atid=100023</a> on <a href="http://forge.ow2.org/tracker/?group_id=23" class="external-link" target="_blank" rel="nofollow noopener">http://forge.ow2.org/tracker/?group_id=23</a> to see if the ASM folks have something to say about support for Java 8 -parameters (either confirm it's fixed in ASM 5.1, and release a new version with a fix for it).</p> <p>I've meanwhile understood, from <a href="https://issues.gradle.org/browse/GRADLE-3157" class="external-link" target="_blank" rel="nofollow noopener">https://issues.gradle.org/browse/GRADLE-3157</a>, that this probably happens when using ASM and passing Opcodes.ASM4 instead of newer Opcodes.ASM5 into ASM (MethodVisitor constructor).</p> <p>As such this problem must be solved in the library calling ASM, as ASM already does support Java 8 javac -parameters, when called correctly.</p> <p>In our case for ODL, this means upgrading not ASM but Apache Aries Blueprint and/or Apache Aries Proxy. This commit <a href="https://github.com/apache/aries/commit/9a9631e98aa1ca30291a77753417432d63fd4c37" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/aries/commit/9a9631e98aa1ca30291a77753417432d63fd4c37</a> for this issue <a href="https://issues.apache.org/jira/browse/ARIES-1280" class="external-link" target="_blank" rel="nofollow noopener">https://issues.apache.org/jira/browse/ARIES-1280</a> looks like it should have taken care of this, a long time ago already. Wonder why we're still hitting it..</p> <p>&gt; We can see e.g. in an ODL Karaf's assembly/system (...) that we appear to be on 5.0.3</p> <p>What doesn't help here to debug this is that somehow we're using an asm-all-5.1.jar on the CP during development and the 5.0.3 during runtime - or are we pulling an ANCIENT ASM 1.5.3, using same packages, from the com.springsource.org.objectweb.asm-1.5.3.jar which we see in system/org/objectweb/asm/com.springsource.org.objectweb.asm/1.5.3 ? That might explain the discrepancy.</p> <p>&gt; Karaf log has a lot of these kind of errors:</p> <p>Actually so far I've only seen this in the Karaf log of SingleFeatureTest runs of features projects; e.g. in netvirt/vpnservice/features/target/surefire-reports/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt</p> <p>Interestingly, a "normal" Karaf distribution does not show this. Priority is thus not quite as blocking as I initially thought. It would still be good to fix though.</p> <p>Suggested next step, try to get rid of com.springsource.org.objectweb.asm-1.5.3.jar to see if that helps. It appears to be pulled by karaf-3.0.6.pom &amp; enterprise-3.0.7-features.xml ?</p> <p><a href="https://issues.jboss.org/browse/ENTESB-5393" class="external-link" target="_blank" rel="nofollow noopener">https://issues.jboss.org/browse/ENTESB-5393</a></p> <p><a href="https://issues.apache.org/jira/browse/ARIES-1186" class="external-link" target="_blank" rel="nofollow noopener">https://issues.apache.org/jira/browse/ARIES-1186</a></p> <p>&gt; Interestingly, a "normal" Karaf distribution does not show this.</p> <p>Is this because Integration/Distribution features-* modules do NOT inherit from features-parent? They use the old way using opendaylight-karaf-empty which is built using karaf-parent which performs explicit hacks related to org.apache.aries.proxy.impl <span class="error">&#91;0&#93;</span>.</p> <p>I checked, the 1.0.4 -&gt; 1.0.5 hack is still relevant for Carbon snapshot builds. Unfortunately I do not recall what happens if the hack is removed, so this issue may be something entirely different.</p> <p><span class="error">&#91;0&#93;</span> <a href="https://git.opendaylight.org/gerrit/gitweb?p=odlparent.git;a=blob;f=karaf/karaf-parent/pom.xml;h=6944d493de907c5c809c569fd8ed99bc04265e70;hb=refs/heads/master#l360" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/gitweb?p=odlparent.git;a=blob;f=karaf/karaf-parent/pom.xml;h=6944d493de907c5c809c569fd8ed99bc04265e70;hb=refs/heads/master#l360</a></p> <p>&gt; I checked, the 1.0.4 -&gt; 1.0.5 hack is still relevant for Carbon snapshot <br/> &gt; builds. Unfortunately I do not recall what happens if the hack is removed</p> <p>Aha. OK, as far as I now understand, that "hack", which replaces org.apache.aries.proxy.impl/1.0.4 with org.apache.aries.proxy.impl/1.0.5 should never be removed, as that is the right thing to do to prevent this problem from occurring. That gets us Apache Aries Proxy 1.0.5 instead of 1.0.4, like issue KARAF-4449 did for Karaf 4, for our ODL Karaf 3, as we need to benefit from the ARIES-1280 fix.</p> <ul> <li><a href="https://issues.apache.org/jira/browse/KARAF-4449" class="external-link" target="_blank" rel="nofollow noopener">https://issues.apache.org/jira/browse/KARAF-4449</a></li> <li><a href="https://github.com/apache/karaf/commit/423a1c21af002e6312cb2e43693e9514128da7b9" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/karaf/commit/423a1c21af002e6312cb2e43693e9514128da7b9</a></li> <li><a href="https://issues.apache.org/jira/browse/ARIES-1280" class="external-link" target="_blank" rel="nofollow noopener">https://issues.apache.org/jira/browse/ARIES-1280</a></li> <li><a href="https://github.com/apache/aries/commit/9a9631e98aa1ca30291a77753417432d63fd4c37" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/aries/commit/9a9631e98aa1ca30291a77753417432d63fd4c37</a></li> </ul> <p>&gt;&gt; only seen this in the Karaf log of SingleFeatureTest runs of features<br/> &gt;&gt; Interestingly, a "normal" Karaf distribution does not show this.<br/> &gt; Is this because Integration/Distribution features-* modules do NOT inherit</p> <p>IMHO the only thing we must thus do here to resolve this is to apply the same (hack) to whatever controls the version of org.apache.aries.proxy.impl in the features projects which run the SingleFeatureTest, and then we're done here. (Or we need to link this issue to some other planned work which would ensure that the same Karaf is used for both?)</p> <p>I'm unclear how / where to do this - Vratko or Stephen, do you know?</p> <p>&gt; apply the same (hack) to whatever controls the version of org.apache.aries.proxy.impl in the features projects which run the SingleFeatureTest</p> <p>Yes, but it may take a while for someone to figure out how that could be done.<br/> Possibly (waiting and) upgrading to karaf 3.0.x which already comes with higher version of org.apache.aries.proxy.impl is easier to do.</p> <p>This now has to be solved in order for everyone to be able to benefit from <a href="https://git.opendaylight.org/gerrit/#/c/48901/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/48901/</a> .. only I alone still don't know to, based on above - #anyone #help - please!</p> <p>An attempt at a sub-optimal but quick Carbon fix:<br/> <a href="https://git.opendaylight.org/gerrit/48934" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/48934</a></p> <p>&gt; An attempt at a sub-optimal but quick Carbon fix:<br/> &gt; <a href="https://git.opendaylight.org/gerrit/48934" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/48934</a></p> <p>I've just tested c/48934 and can confirm this solves the problem above!</p> <p>Workaround merged, this will be fixed properly with the Karaf4 upgrade.</p> <p>FTR: <a href="https://jira.opendaylight.org/browse/ODLPARENT-74" title="pax-web-jetty RuntimeException at org.objectweb.asm.MethodVisitor.visitParameter(Unknown Source)[54:org.objectweb.asm.all:5.0.4]" class="issue-link" data-issue-key="ODLPARENT-74"><del>ODLPARENT-74</del></a> has something vaguely related.</p> Development External issue ID 6523 External issue URL Issue Type ODL SR Target Milestone Rank 0|i022yf: