https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/ODLPARENT-91 odlparent <p>While fixing <a href="https://jira.opendaylight.org/browse/INFRAUTILS-10" title="infrautils-features4 cannot be added to karaf4 distribution" class="issue-link" data-issue-key="INFRAUTILS-10"><del>INFRAUTILS-10</del></a> I've realized that SingleFeatureTest does not actually discover blueprint related problems... <img class="emoticon" src="https://jira.opendaylight.org/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/> Or at the very least it can clearly miss some of them.</p> <p>For example, in that bug there was a BP XML with an invalid ref in a &lt;service&gt; and it missed that.. on looking more closely at the log, I believe what is happening is that TestBundleDiag currently only tests that bundles were installed and are "active", but may be missing to explicitly wait for BP validation?</p> <p>What's curious is that SOMETIMES it hits them (which is was <a href="https://jira.opendaylight.org/browse/INFRAUTILS-10" title="infrautils-features4 cannot be added to karaf4 distribution" class="issue-link" data-issue-key="INFRAUTILS-10"><del>INFRAUTILS-10</del></a> was all about; in <a href="https://git.opendaylight.org/gerrit/#/c/56611/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/56611/</a> the problem was found, but that was in SFT of integration/distribution ... which technically is the same code - but I suspect it may be slower there, and thus hit it? I think we have to await the same even in faster running individual feature tests, somehow.</p> <p>Operating System: All<br/> Platform: All</p> ODLPARENT-91

SingleFeatureTest fails to discover blueprint related problems for features which do not depend on the controller feature with the ODL specific blueprint extender

Bug Resolved Done Unassigned Michael Vorburger Mon, 8 May 2017 09:47:00 +0000 Thu, 25 Jun 2020 06:11:47 +0000 Thu, 25 Jun 2020 06:11:47 +0000 2.0.5 General 0 0 <p>The attached SFT org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt log, as an example from infrautils/common/features/odl-infrautils-jobcoordinator on master (after merge of c/56024, before merge of c/56663/), illustrates the problem... we install e.g. jobcoordinator-impl and TestBundleDiag is happy with "diag: Active </p> {Unknown=0, Starting=0, Active=79, GracePeriod=0, Failure=0, Installed=0, Resolved=2, Stopping=0, Waiting=0} <p>" and ends - but there never even was a "BlueprintContainer for bundle org.opendaylight.infrautils.jobcoordinator-impl" ... we probably have to wait for that, somehow.</p> <p>&gt; The attached SFT org.opendaylight.odlparent.featuretest.SingleFeatureTest</p> <p>I forgot to attach this file and don't actually have it anymore right now.</p> <p>&gt; but may be missing to explicitly wait for BP validation?</p> <p>That wasn't it - this actually works - but the BP XML location can be confusing... normally in standard Karaf it's in OSGI-INF/blueprint/. The ODL specific BP XML has to be in org/opendaylight/blueprint/ - but that, of course, only works if you have the bundle that does the ODL specific BP handling installed and already active in Karaf...</p> <p>... which in the case of <a href="https://jira.opendaylight.org/browse/INFRAUTILS-10" title="infrautils-features4 cannot be added to karaf4 distribution" class="issue-link" data-issue-key="INFRAUTILS-10"><del>INFRAUTILS-10</del></a> it was NOT - it's an infrautils bundle and feature which does not require controller. SFT should still work though.</p> <p>Basically, we have a problem with "modularity" dependencies in this case.</p> <p>&gt; What's curious is that SOMETIMES it hits them</p> <p>This was because during the SFT of integration/distribution, the controller feature which includes the ODL blueprint extender bundle from controller is already installed. In an infrautils SFT it is not, thus this problem.</p> <p>The combination of <a href="https://git.opendaylight.org/gerrit/#/c/54885/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/54885/</a> and <a href="https://git.opendaylight.org/gerrit/#/c/56672/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/56672/</a> together would fix this problem; I've locally played with this and can confirm that if we do (both of) that, then SFT will find issues in such BP XML, as expected.</p> Development External issue ID 8397 External issue URL Issue Type Priority Rank 0|i02393: