OpenDaylight JIRA

OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us

8.20.10

820010

22-06-2022

[OPNFLWJAVA-78] Failed entries not freed from queue, causing superfluous iterations https://jira.opendaylight.org/browse/OPNFLWJAVA-78 openflowjava <p>Entries in StackedSegment failAll method are failed and marked as completed but completeCount of segment is not incremented.</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWJAVA-78

Failed entries not freed from queue, causing superfluous iterations

Bug Resolved Done Michal Polkorab Andrej Leitner Tue, 6 Sep 2016 08:49:08 +0000 Tue, 14 Nov 2017 19:19:20 +0000 Tue, 13 Sep 2016 08:07:47 +0000 unspecified General 0 5 <p>carbon: <a href="https://git.opendaylight.org/gerrit/#/c/45208/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45208/</a><br/> boron: <a href="https://git.opendaylight.org/gerrit/#/c/45210/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/45210/</a></p> <p>merged in carbon</p> <p>To add some more description to this issue:</p> <p>Both succesfull and failed segments in queue are taken as completed, but failed segments are not freed from list of segments.<br/> This can cause slower performance of queue when there are a lot of failed segments present, because of bigger lists to iterate.<br/> This Andrej´s patch fixes this issue and properly marks failed segments as completed.</p> <p>To better assess the impact of this bug and fix, could someone from your team please help us identify the following:<br/> Severity: Could you elaborate on the severity of this bug? Is this a BLOCKER such that we cannot release Boron without it? Is there a workaround such that we can write a release note and fix in future Boron SR1?<br/> Testing: Could you also elaborate on the testing of this patch? How extensively has this patch been tested? Is it covered by any unit tests or system tests? <br/> Impact: Does this fix impact any dependent projects?</p> <p>(In reply to A H from comment #4)<br/> > To better assess the impact of this bug and fix, could someone from your<br/> > team please help us identify the following:<br/> > Severity: Could you elaborate on the severity of this bug? Is this a<br/> > BLOCKER such that we cannot release Boron without it? Is there a workaround<br/> > such that we can write a release note and fix in future Boron SR1?<br/> Yes: it is a blocker - especially looking at the description (that it can impact the performance after some time):<br/> "Both successful and failed segments in queue are taken as completed, but failed segments are not freed from list of segments.</p> <p>This can cause slower performance of queue when there are a lot of failed segments present, because of bigger lists to iterate.</p> <p>Andrej´s patch fixes this issue and properly marks failed segments as completed."</p> <p>> Testing: Could you also elaborate on the testing of this patch? How<br/> > extensively has this patch been tested? Is it covered by any unit tests or<br/> > system tests? <br/> Luis, Andrej & Tomas have tested it well. Luis did not find any negative impact on the other projects. The performance code has good system tests - so it will be covered under the system tests.</p> <p>> Impact: Does this fix impact any dependent projects?<br/> OpenFlow Plugin is the dependent project. It should not impact projects dependent on OpenFlow Plugin.</p> <p>both changes were merged</p> <p>Has this bug been verified as fixed in the latest Boron RC 3.3 Build?</p> <p>yes.</p> Development External issue ID 6638 External issue URL Rank 0|i02g6f: