https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-1102 OpenFlowPlugin <p>Examination of the use of this class shows we can reduce code duplication by sharing simple action case serialize. Furthermore we can reuse objects across deserializeHeader() invocations. Similar is true for others, hence audit and refactor them from performance.</p> OPNFLWPLUG-1102

Refactor OpenFlow protocol serializers/deserializers

Improvement Medium Confirmed Unresolved Unassigned Robert Varga Wed, 2 Sep 2020 14:58:42 +0000 Tue, 2 May 2023 19:04:49 +0000 openflowjava-impl 0 1 <p>A first pass has been made.</p> <p>We still need to deal with registries, which are quite inefficient. All of the lookups go through generalized MessageCodeKey and similar constructs, forcing callers to create these. Rather than exposing keys in this way, we should provide specialized lookup registries, where all required parameters will be supplied to the lookup method, hence instead of this:</p> <p> </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">    <span class="code-keyword">private</span> void writeExperimenterRelatedTableProperty(<span class="code-keyword">final</span> ByteBuf output,            <span class="code-keyword">final</span> TableFeatureProperties property) {        <span class="code-object">long</span> expId = property.augmentation(ExperimenterIdTableFeatureProperty.class).getExperimenter().getValue()            .toJava();        OFSerializer&lt;TableFeatureProperties&gt; serializer = registry.getSerializer(                ExperimenterSerializerKeyFactory.createMultipartRequestTFSerializerKey(                        EncodeConstants.OF13_VERSION_ID, expId));        serializer.serialize(property, output);    } </pre> </div></div> <p>we would do something like:</p> <p> </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">    <span class="code-keyword">private</span> void writeExperimenterRelatedTableProperty(<span class="code-keyword">final</span> ByteBuf output,            <span class="code-keyword">final</span> TableFeatureProperties property) {        <span class="code-object">long</span> expId = property.augmentation(ExperimenterIdTableFeatureProperty.class).getExperimenter().getValue()            .toJava();        OFSerializer&lt;TableFeatureProperties&gt; serializer = registry.getSerializer( EncodeConstants.OF13_VERSION_ID, expId, TableFeatureProperties.class);        serializer.serialize(property, output);    } </pre> </div></div> <p>With this, we can perform a number of internal optimizations to speed up lookup:</p> <ol> <li>have an internal array of per-OF-version registries, i.e. deal with version through a trivial array lookup or through a switch(version) statement</li> <li>deal with the other two parts in whatever way makes sense – either as a fused key-based registry, or two nested registries</li> </ol> <p>Structuring things this way will also allow us to propagate invariants, such as:</p> <ul> <li>peeling the OF versions lookup out of the picture</li> <li>specializing serializer classes, i.e. to have OFSerializer&lt;TableFeatureProperties&gt; have as 'TableFeaturePropertiesSerializer', allowing JIT to perform CHA on potential targets</li> </ul> <p> </p> <p> </p> Development Rank 0|i03upb: