https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-1103 OpenFlowPlugin <p>I am using `pyang` to validate a yang module which I am basing off of openflow. In the process of building it out, I am validating my yang through pyang and I am noticing this error:</p> <p> </p> <p><tt>$ pyang my.yang</tt><br/> <tt>openflow-instruction@2013-07-31.yang:21: error: the list at "openflow-<font color="#ff0000">instruction@2013-07-31.yang:21 (at openflow-action@2015-02-03.yang:32)" needs at least one key because it is used as config</font></tt></p> <p> </p> <p>When looking at the source code for openflow-action I see:</p> <p> grouping actions-grouping {<br/> <tt>   list action {</tt><br/> <tt>      uses action-grouping;</tt><br/> <tt>      leaf experimenter-id {</tt><br/> <tt>        type oft:experimenter-id;</tt><br/> <tt>     </tt>}<br/> }</p> <p>So it is missing a `key`. I can't tell if this is a bug with openflow-action or if pyang is running in some ultra strict mode, but does anyone have insight on this?</p> <ul> <li>CentOS 7</li> <li>pyang 2.3.2</li> </ul> <p> </p> OPNFLWPLUG-1103

Openflow-Action list needs a key?

Bug High Resolved Won't Do dheenadayalan b Eric Sender Fri, 4 Sep 2020 20:21:24 +0000 Wed, 16 Dec 2020 21:44:41 +0000 Wed, 16 Dec 2020 21:44:41 +0000 0 2 <p>A couple github tickets which I am running in parallel confirm that ODL has syntax errors</p> <p><a href="https://github.com/mbj4668/pyang/issues/674" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/mbj4668/pyang/issues/674</a></p> <p><a href="https://github.com/CESNET/libyang/issues/1192#issuecomment-690026975" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/CESNET/libyang/issues/1192#issuecomment-690026975</a></p> <p> </p> <p>Essentially I modified:</p> <ul> <li><tt>opendaylight-port-types@2013-09-25.yang</tt></li> </ul> <ul> <li><tt>openflow-action@2015-02-03.yang</tt>{{}}</li> </ul> <ul> <li><span class="nobr"><a href="mailto:openflow-instruction@2013-07-31.yang" class="external-link" target="_blank" rel="nofollow noopener">openflow-instruction@2013-07-31.yang^{<img class="rendericon" src="https://jira.opendaylight.org/images/icons/mail_small.gif" height="12" width="13" align="absmiddle" alt="" border="0"/>}</a></span><br/> {{}}</li> </ul> <p> </p> <p><tt>And my diff:</tt></p> <p> </p> <p><tt> diff --git a/box/rmbn-yang/src/main/yang/opendaylight-port-types@2013-09-25.yang b/box/rmbn-yang/src/main/yang/opendaylight-port-types@2013-09-25.yang</tt><br/> {{ index fa6e1fc..53f00c5 100644}}<br/> {{ — a/box/rmbn-yang/src/main/yang/opendaylight-port-types@2013-09-25.yang}}<br/> {{ +++ b/box/rmbn-yang/src/main/yang/opendaylight-port-types@2013-09-25.yang}}<br/> {{ @@ -193,6 +193,7 @@ module opendaylight-port-types {}}<br/> {{ augment "/multipart:multipart-reply/multipart:multipart-reply-body" {}}<br/> {{ case multipart-reply-port-desc {}}<br/> {{ list ports}}{{</p> { + key "name"; uses flow-capable-port; } <p>}}<tt>}</tt><br/> {{ diff --git a/box/rmbn-yang/src/main/yang/openflow-action@2015-02-03.yang b/box/rmbn-yang/src/main/yang/openflow-action@2015-02-03.yang}}<br/> {{ index d2ae42f..25abff6 100644}}<br/> {{ — a/box/rmbn-yang/src/main/yang/openflow-action@2015-02-03.yang}}<br/> {{ +++ b/box/rmbn-yang/src/main/yang/openflow-action@2015-02-03.yang}}<br/> {{ @@ -30,6 +30,7 @@}}<tt>grouping actions-grouping {</tt><br/> {{ list action {}}<br/> {{ + key "experimenter-id";}}<br/> {{ uses action-grouping;}}<br/> {{ leaf experimenter-id {}}<br/> {{ type oft:experimenter-id;}}<br/> {{ diff --git a/box/rmbn-yang/src/main/yang/openflow-instruction@2013-07-31.yang b/box/rmbn-yang/src/main/yang/openflow-instruction@2013-07-31.yang}}<br/> {{ index b9e515b..1dfdd14 100644}}<br/> {{ — a/box/rmbn-yang/src/main/yang/openflow-instruction@2013-07-31.yang}}<br/> {{ +++ b/box/rmbn-yang/src/main/yang/openflow-instruction@2013-07-31.yang}}<br/> {{ @@ -23,6 +23,7 @@}}<tt>grouping instructions-grouping {</tt><br/> {{ list instruction {}}<br/> {{ + key "experimenter-id";}}<br/> {{ config false;}}<br/> {{ uses instruction-grouping;}}<br/> {{ leaf experimenter-id {}}</p> <p> </p> <p>can you create a separate issue for this, with the attached patch, please?</p> <p>The pyang error is expected: OpenDaylight's LogicalDatastoreType.CONFIGURATION is more flexible.</p> <p>It comes from pyang's strict reading of RFC6020/7950 when 'config' is involved – it effectively expresses what is a datastore policy for those nodes. RFC8342 fixes this and pyang needs to adapt.</p> Relates OPNFLWPLUG-1104 Development Rank 0|i03uqv: