OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [OPNFLWPLUG-18] Pre-configuration of flows causes exception https://jira.opendaylight.org/browse/OPNFLWPLUG-18 OpenFlowPlugin <p>When trying to add a flow to a node which is not connected (i.e. trying to pre-configure a node), the following exception is thrown:</p> <p>&lt;html&gt;<br/> &lt;head&gt;<br/> &lt;title&gt;Apache Tomcat/7.0.32 - Error report&lt;/title&gt;<br/> &lt;style&gt;<br/> &lt;!--H1 </p> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;} <p> H2 </p> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;} <p> H3 </p> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;} <p> BODY </p> {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;} <p> B </p> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;} <p> P </p> {font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;} <p>A </p> {color : black;} <p>A.name </p> {color : black;} <p>HR </p> {color : #525D76;} <p>--&gt;<br/> &lt;/style&gt;<br/> &lt;/head&gt;<br/> &lt;body&gt;<br/> &lt;h1&gt;HTTP Status 500 - Internal Server Error&lt;/h1&gt;<br/> &lt;HR size="1" noshade="noshade"&gt;<br/> &lt;p&gt;<br/> &lt;b&gt;type&lt;/b&gt; Status report<br/> &lt;/p&gt;<br/> &lt;p&gt;<br/> &lt;b&gt;message&lt;/b&gt;<br/> &lt;u&gt;Internal Server Error&lt;/u&gt;<br/> &lt;/p&gt;<br/> &lt;p&gt;<br/> &lt;b&gt;description&lt;/b&gt;<br/> &lt;u&gt;The server encountered an internal error that prevented it from fulfilling this request.&lt;/u&gt;<br/> &lt;/p&gt;<br/> &lt;HR size="1" noshade="noshade"&gt;<br/> &lt;h3&gt;Apache Tomcat/7.0.32&lt;/h3&gt;<br/> &lt;/body&gt;<br/> &lt;/html&gt;</p> <p>Use, for example:</p> <p>PUT <a href="http://192.168.4.1:8080/restconf/config/opendaylight-inventory:nodes/node/openflow:1/table/2/flow/135" class="external-link" target="_blank" rel="nofollow noopener">http://192.168.4.1:8080/restconf/config/opendaylight-inventory:nodes/node/openflow:1/table/2/flow/135</a></p> <p>Accept: application/xml<br/> Content-type: application/xml</p> <p>&lt;?xml version="1.0" encoding="UTF-8" standalone="no"?&gt;<br/> &lt;flow xmlns="urn:opendaylight:flow:inventory"&gt;<br/> &lt;strict&gt;false&lt;/strict&gt;<br/> &lt;flow-name&gt;FooXf20&lt;/flow-name&gt;<br/> &lt;id&gt;135&lt;/id&gt;<br/> &lt;cookie_mask&gt;255&lt;/cookie_mask&gt;<br/> &lt;cookie&gt;20&lt;/cookie&gt;<br/> &lt;table_id&gt;2&lt;/table_id&gt;<br/> &lt;priority&gt;2&lt;/priority&gt;<br/> &lt;hard-timeout&gt;1200&lt;/hard-timeout&gt;<br/> &lt;idle-timeout&gt;3400&lt;/idle-timeout&gt;<br/> &lt;installHw&gt;false&lt;/installHw&gt;<br/> &lt;instructions&gt;<br/> &lt;instruction&gt;<br/> &lt;order&gt;0&lt;/order&gt;<br/> &lt;apply-actions&gt;<br/> &lt;action&gt;<br/> &lt;order&gt;0&lt;/order&gt;<br/> &lt;dec-nw-ttl/&gt;<br/> &lt;/action&gt;<br/> &lt;/apply-actions&gt;<br/> &lt;/instruction&gt;<br/> &lt;/instructions&gt;<br/> &lt;match&gt;<br/> &lt;metadata&gt;<br/> &lt;metadata&gt;12345&lt;/metadata&gt;<br/> &lt;/metadata&gt;<br/> &lt;/match&gt;<br/> &lt;/flow&gt;</p> <p>Operating System: Mac OS<br/> Platform: Macintosh</p> OPNFLWPLUG-18 Pre-configuration of flows causes exception Bug Resolved Done Vaclav Demcak Jan Medved Sat, 11 Jan 2014 22:21:55 +0000 Mon, 27 Sep 2021 09:01:00 +0000 Mon, 18 Aug 2014 07:58:47 +0000 General 0 10 <p>RESTCONF returns status code 500 because transaction status is FAILED. Restconf has not information why transaction was failed. Bug is moved to mdsal</p> <p>This is log of exception from console:</p> <p>2014-01-14 16:18:56.528 CET <span class="error">&#91;pool-23-thread-2&#93;</span> INFO o.o.c.m.s.c.i.service.TwoPhaseCommit - Transaction: BA-2 Started.<br/> 2014-01-14 16:18:56.538 CET <span class="error">&#91;pool-23-thread-2&#93;</span> ERROR o.o.c.m.s.c.i.service.TwoPhaseCommit - Transaction: BA-2 Finish Commit failed<br/> java.lang.IllegalStateException: No routable provider is processing routed message for InstanceIdentifier [path=[org.opendaylight.yang.gen.v1.urn.open<br/> daylight.inventory.rev130819.Nodes, org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node[key=NodeKey [_id=Uri <span class="error">&#91;_value=openflow:1&#93;</span>]]]]<br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$Router.addFlow(SalFlowService$$Broker$Router.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$DirectProxy.addFlow(SalFlowService$$Broker$DirectProxy.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.flow.FlowTransaction.add(FlowTransaction.java:101) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.AbstractTransaction.callRpcs(AbstractTransaction.java:56) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.AbstractTransaction.finish(AbstractTransaction.java:28) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:94) <span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:31) <span class="error">&#91;bundlefile:na&#93;</span><br/> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.util.concurrent.FutureTask.run(FutureTask.java:166) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.lang.Thread.run(Thread.java:724) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> 2014-01-14 16:18:56.553 CET <span class="error">&#91;pool-22-thread-2&#93;</span> ERROR o.o.c.m.s.c.i.service.TwoPhaseCommit - Transaction: DOM-1 Finish Commit failed<br/> java.lang.IllegalStateException:<br/> at org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentConnector$DomToBindingTransaction.finish(BindingIndependentConnector.java:326) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:94) <span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:31) <span class="error">&#91;bundlefile:na&#93;</span><br/> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.util.concurrent.FutureTask.run(FutureTask.java:166) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.lang.Thread.run(Thread.java:724) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> Caused by: java.util.concurrent.ExecutionException: java.lang.IllegalStateException: No routable provider is processing routed message for InstanceIdentifier [path=[org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes, org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node[key=NodeKey [_id=Uri <span class="error">&#91;_value=openflow:1&#93;</span>]]]]<br/> at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:252) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at java.util.concurrent.FutureTask.get(FutureTask.java:111) ~<span class="error">&#91;na:1.7.0_25&#93;</span><br/> at org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentConnector$DomToBindingTransaction.finish(BindingIndependentConnector.java:321) ~<span class="error">&#91;na:na&#93;</span><br/> ... 7 common frames omitted<br/> Caused by: java.lang.IllegalStateException: No routable provider is processing routed message for InstanceIdentifier [path=[org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes, org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node[key=NodeKey [_id=Uri <span class="error">&#91;_value=openflow:1&#93;</span>]]]]<br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$Router.removeFlow(SalFlowService$$Broker$Router.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$DirectProxy.removeFlow(SalFlowService$$Broker$DirectProxy.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.flow.FlowTransaction.remove(FlowTransaction.java:53) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.AbstractTransaction.rollbackRpcs(AbstractTransaction.java:96) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.AbstractTransaction.rollback(AbstractTransaction.java:38) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.rollback(TwoPhaseCommit.java:147) <span class="error">&#91;bundlefile:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:104) <span class="error">&#91;bundlefile:na&#93;</span><br/> ... 6 common frames omitted</p> <p>This functionality is in the scope of new FRM, not MD-SAL.</p> <p>Should be fixed when "mark and sweep" gets implemented.</p> <p>Per last meeting we wanted to see if this is still an issue. </p> <p>Conclusion:<br/> Seems still an issue-- when tried configuring flow without any switch connected get the following exception </p> <hr /> <p>014-03-26 15:12:16.311 PDT <span class="error">&#91;md-sal-binding-commit-0&#93;</span> ERROR o.o.c.m.s.c.i.service.TwoPhaseCommit - Transaction: BA-171 Finish Commit failed<br/> java.lang.IllegalArgumentException: Session for the cookie is invalid. Reason: the switch has been recently disconnected OR inventory provides outdated information.<br/> at org.opendaylight.openflowplugin.openflow.md.core.session.MessageDispatchServiceImpl.getConnectionAdapter(MessageDispatchServiceImpl.java:92) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.openflowplugin.openflow.md.core.session.MessageDispatchServiceImpl.flowMod(MessageDispatchServiceImpl.java:124) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.openflowplugin.openflow.md.core.sal.ModelDrivenSwitchImpl.addFlow(ModelDrivenSwitchImpl.java:242) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$Router.addFlow(SalFlowService$$Broker$Router.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$DirectProxy.addFlow(SalFlowService$$Broker$DirectProxy.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.flow.FlowTransaction.add(FlowTransaction.java:121) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.AbstractTransaction.callRpcs(AbstractTransaction.java:63) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.AbstractTransaction.finish(AbstractTransaction.java:35) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:110) <span class="error">&#91;bundlefile:na&#93;</span><br/> at <br/> -----------------------</p> <p>Doesn't the ability to support pre-configured flows require the ability to support pre-configure Node &#8211; didn't find any API that helps in doing the same.</p> <p>Basheer, </p> <p>I believe in this case adding a node is not required and also it would be wrong to add a node I believe because it is operational data which should not be set by a client (It is ok for it to be set by the controller code but not the client that is the distinction in my mind).</p> <p>I think the proper way to handle this may be to not add the flow to the open flow plugin when the node is not present in the operational data when addFow is called. Then in the onNodeAdded listener in FRM you must check if flows exist for that node in the configuration and if they do then you must add those flows to the openflowplugin.</p> <p>Other folks can chime in on this if my assessment is incorrect.</p> <p>Hi,<br/> this is more of enhancement than bug. Currently transaction is used in order to write stuff into config context of dataStorage. Then md-sal invokes twoPhaseCommit which involves transaction handlers and here we have FRM.</p> <p>Here is a simple scenario of preconfiguration functionality:</p> <ul class="alternate" type="square"> <li>if FRM finds out there is no corresponding node in operational context, it can still add the flow to config (there might be added "force" flag to addFlow model to better controll that), but application/user should get notified of that</li> <li>NodeUpdated notification later will invoke FRM to check preconfigured stuff and push it to announced device</li> </ul> <p>Wanted to understand the use case here. We are trying to configure the node which is not yet connected to the controller. So how user actually will determine the flow construct without knowing the switch details? Can you please share the use case for doing this?</p> <p>Michal thinks this should be partially working now.</p> <p>Michal thinks this should be partially working now.</p> <p>java.lang.IllegalStateException: Address not found for route [RouteIdentifierImpl{context=null, type=(urn:opendaylight:flow:service?revision=2013-08-19)add-flow, route=(urn:opendaylight:inventory?revision=2013-08-19)nodes/(urn:opendaylight:inventory?revision=2013-08-19)node[</p> {(urn:opendaylight:inventory?revision=2013-08-19)id=openflow:1} <p>]}]<br/> at com.google.common.base.Preconditions.checkState(Preconditions.java:176) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.connector.remoterpc.ClientImpl.lookupRemoteAddressForRpc(ClientImpl.java:211) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.connector.remoterpc.ClientImpl.invokeRpc(ClientImpl.java:126) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.connector.remoterpc.RemoteRpcProvider.invokeRpc(RemoteRpcProvider.java:107) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.dom.broker.impl.SchemaAwareRpcBroker.invokeRpc(SchemaAwareRpcBroker.java:244) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.dom.broker.impl.SchemaAwareRpcBroker$RoutedRpcSelector.invokeRpc(SchemaAwareRpcBroker.java:342) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.dom.broker.impl.SchemaAwareRpcBroker.invokeRpc(SchemaAwareRpcBroker.java:168) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.dom.broker.osgi.RpcProvisionRegistryProxy.invokeRpc(RpcProvisionRegistryProxy.java:67) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.binding.impl.connect.dom.RpcInvocationStrategy.forwardToDomBroker(RpcInvocationStrategy.java:121) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.sal.binding.impl.connect.dom.BindingIndependentConnector$DomToBindingRpcForwarder.invoke(BindingIndependentConnector.java:665) ~<span class="error">&#91;na:na&#93;</span><br/> at com.sun.proxy.$Proxy97.addFlow(Unknown Source) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$Router.addFlow(SalFlowService$$Broker$Router.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowService$$Broker$DirectProxy.addFlow(SalFlowService$$Broker$DirectProxy.java) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.flow.FlowChangeListener.add(FlowChangeListener.java:116) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.frm.AbstractChangeListener.onDataChanged(AbstractChangeListener.java:51) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.ForwardedBackwardsCompatibleDataBroker$BackwardsCompatibleConfigurationDataChangeInvoker.onDataChanged(ForwardedBackwardsCompatibleDataBroker.java:458) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.md.sal.binding.impl.AbstractForwardedDataBroker$TranslatingDataChangeInvoker.onDataChanged(AbstractForwardedDataBroker.java:158) ~<span class="error">&#91;na:na&#93;</span><br/> at org.opendaylight.controller.md.sal.dom.store.impl.ChangeListenerNotifyTask.run(ChangeListenerNotifyTask.java:33) ~<span class="error">&#91;na:na&#93;</span><br/> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) <span class="error">&#91;na:1.7.0_45&#93;</span><br/> at java.util.concurrent.FutureTask.run(FutureTask.java:262) <span class="error">&#91;na:1.7.0_45&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) <span class="error">&#91;na:1.7.0_45&#93;</span><br/> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) <span class="error">&#91;na:1.7.0_45&#93;</span><br/> at java.lang.Thread.run(Thread.java:744) <span class="error">&#91;na:1.7.0_45&#93;</span></p> <p><a href="https://git.opendaylight.org/gerrit/#/c/8174/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8174/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/8175/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/8175/</a></p> <p><a href="https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Backlog:Node_Status_Reconciliation#Prepared_Status" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Backlog:Node_Status_Reconciliation#Prepared_Status</a></p> <p>About Vaclav's last comments:</p> <p>So why is this not merged yet (controller)? What's the status of the merges? The OF plugin gerrit seems to be abandoned as no longer needed. Is the fix no god?</p> Blocks OPNFLWPLUG-115 Development External issue ID 282 External issue URL ODL SR Target Milestone Priority Rank 0|i02yk7: