<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 20:31:22 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[OPNFLWPLUG-24] OF 1.0 statistics are reporting ethernet src/dst mac when none is present</title>
                <link>https://jira.opendaylight.org/browse/OPNFLWPLUG-24</link>
                <project id="10155" key="OPNFLWPLUG">OpenFlowPlugin</project>
                    <description>&lt;p&gt;When running:&lt;/p&gt;

&lt;p&gt; sudo mn --topo tree,2  --controller &apos;remote,ip=10.0.2.2:6633&apos; --switch ovsk,protocols=OpenFlow10&lt;/p&gt;

&lt;p&gt;Against the new openflowplugin, and then running in mininet&lt;/p&gt;

&lt;p&gt;h1 ping h2 &lt;/p&gt;

&lt;p&gt;(which fails, different bug)&lt;/p&gt;

&lt;p&gt;In stats I see:&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;http://localhost:8080/restconf/operational/opendaylight-inventory:nodes/node/openflow:1/table/0&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://localhost:8080/restconf/operational/opendaylight-inventory:nodes/node/openflow:1/table/0&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;&amp;lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot; standalone=&quot;no&quot;?&amp;gt;&lt;br/&gt;
&amp;lt;table &lt;br/&gt;
    xmlns=&quot;urn:opendaylight:flow:inventory&quot;&amp;gt;&lt;br/&gt;
    &amp;lt;aggregate-flow-statistics &lt;br/&gt;
        xmlns=&quot;urn:opendaylight:flow:statistics&quot;&amp;gt;&lt;br/&gt;
        &amp;lt;byte-count&amp;gt;0&amp;lt;/byte-count&amp;gt;&lt;br/&gt;
        &amp;lt;packet-count&amp;gt;0&amp;lt;/packet-count&amp;gt;&lt;br/&gt;
        &amp;lt;flow-count&amp;gt;0&amp;lt;/flow-count&amp;gt;&lt;br/&gt;
    &amp;lt;/aggregate-flow-statistics&amp;gt;&lt;br/&gt;
    &amp;lt;id&amp;gt;0&amp;lt;/id&amp;gt;&lt;br/&gt;
    &amp;lt;flow-table-statistics &lt;br/&gt;
        xmlns=&quot;urn:opendaylight:flow:table:statistics&quot;&amp;gt;&lt;br/&gt;
        &amp;lt;packets-looked-up&amp;gt;36852&amp;lt;/packets-looked-up&amp;gt;&lt;br/&gt;
        &amp;lt;packets-matched&amp;gt;36595&amp;lt;/packets-matched&amp;gt;&lt;br/&gt;
        &amp;lt;active-flows&amp;gt;9&amp;lt;/active-flows&amp;gt;&lt;br/&gt;
    &amp;lt;/flow-table-statistics&amp;gt;&lt;br/&gt;
    &amp;lt;flow&amp;gt;&lt;br/&gt;
        &amp;lt;id&amp;gt;1011&amp;lt;/id&amp;gt;&lt;br/&gt;
        &amp;lt;flow-statistics &lt;br/&gt;
            xmlns=&quot;urn:opendaylight:flow:statistics&quot;&amp;gt;&lt;br/&gt;
            &amp;lt;match&amp;gt;&lt;br/&gt;
                &amp;lt;ipv4-source&amp;gt;0.0.0.0/0&amp;lt;/ipv4-source&amp;gt;&lt;br/&gt;
                &amp;lt;ipv4-destination&amp;gt;0.0.0.0/0&amp;lt;/ipv4-destination&amp;gt;&lt;br/&gt;
                &amp;lt;ip-match&amp;gt;&lt;br/&gt;
                    &amp;lt;ip-protocol&amp;gt;0&amp;lt;/ip-protocol&amp;gt;&lt;br/&gt;
                &amp;lt;/ip-match&amp;gt;&lt;br/&gt;
                &amp;lt;in-port&amp;gt;openflow:1:0&amp;lt;/in-port&amp;gt;&lt;br/&gt;
                &amp;lt;ethernet-match&amp;gt;&lt;br/&gt;
                    &amp;lt;ethernet-source&amp;gt;&lt;br/&gt;
                        &amp;lt;address&amp;gt;00:00:00:00:00:00&amp;lt;/address&amp;gt;&lt;br/&gt;
                    &amp;lt;/ethernet-source&amp;gt;&lt;br/&gt;
                    &amp;lt;ethernet-type&amp;gt;&lt;br/&gt;
                        &amp;lt;type&amp;gt;2048&amp;lt;/type&amp;gt;&lt;br/&gt;
                    &amp;lt;/ethernet-type&amp;gt;&lt;br/&gt;
                    &amp;lt;ethernet-destination&amp;gt;&lt;br/&gt;
                        &amp;lt;address&amp;gt;00:00:00:00:00:00&amp;lt;/address&amp;gt;&lt;br/&gt;
                    &amp;lt;/ethernet-destination&amp;gt;&lt;br/&gt;
                &amp;lt;/ethernet-match&amp;gt;&lt;br/&gt;
                &amp;lt;vlan-match&amp;gt;&lt;br/&gt;
                    &amp;lt;vlan-pcp&amp;gt;0&amp;lt;/vlan-pcp&amp;gt;&lt;br/&gt;
                    &amp;lt;vlan-id&amp;gt;&lt;br/&gt;
                        &amp;lt;vlan-id&amp;gt;0&amp;lt;/vlan-id&amp;gt;&lt;br/&gt;
                    &amp;lt;/vlan-id&amp;gt;&lt;br/&gt;
                &amp;lt;/vlan-match&amp;gt;&lt;br/&gt;
            &amp;lt;/match&amp;gt;&lt;br/&gt;
            &amp;lt;table_id&amp;gt;0&amp;lt;/table_id&amp;gt;&lt;br/&gt;
            &amp;lt;duration&amp;gt;&lt;br/&gt;
                &amp;lt;nanosecond&amp;gt;369000000&amp;lt;/nanosecond&amp;gt;&lt;br/&gt;
                &amp;lt;second&amp;gt;78&amp;lt;/second&amp;gt;&lt;br/&gt;
            &amp;lt;/duration&amp;gt;&lt;br/&gt;
            &amp;lt;cookie&amp;gt;0&amp;lt;/cookie&amp;gt;&lt;br/&gt;
            &amp;lt;packet-count&amp;gt;0&amp;lt;/packet-count&amp;gt;&lt;br/&gt;
            &amp;lt;priority&amp;gt;1&amp;lt;/priority&amp;gt;&lt;br/&gt;
            &amp;lt;byte-count&amp;gt;0&amp;lt;/byte-count&amp;gt;&lt;br/&gt;
            &amp;lt;hard-timeout&amp;gt;0&amp;lt;/hard-timeout&amp;gt;&lt;br/&gt;
            &amp;lt;idle-timeout&amp;gt;0&amp;lt;/idle-timeout&amp;gt;&lt;br/&gt;
        &amp;lt;/flow-statistics&amp;gt;&lt;br/&gt;
    &amp;lt;/flow&amp;gt;&lt;br/&gt;
&amp;lt;/table&amp;gt;&lt;/p&gt;

&lt;p&gt;On the switch I see:&lt;/p&gt;

&lt;p&gt;vagrant@vagrant-ubuntu-trusty-64:~$ sudo ovs-ofctl -O OpenFlow10 dump-flows s1&lt;br/&gt;
NXST_FLOW reply (xid=0x4):&lt;br/&gt;
 cookie=0x0, duration=5.357s, table=0, n_packets=0, n_bytes=0, idle_age=5, priority=1,ip actions=output:1&lt;/p&gt;

&lt;p&gt;And in the config I see:&lt;/p&gt;

&lt;p&gt;&amp;lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot; standalone=&quot;no&quot;?&amp;gt;&lt;br/&gt;
&amp;lt;table &lt;br/&gt;
    xmlns=&quot;urn:opendaylight:flow:inventory&quot;&amp;gt;&lt;br/&gt;
    &amp;lt;flow&amp;gt;&lt;br/&gt;
        &amp;lt;instructions&amp;gt;&lt;br/&gt;
            &amp;lt;instruction&amp;gt;&lt;br/&gt;
                &amp;lt;order&amp;gt;0&amp;lt;/order&amp;gt;&lt;br/&gt;
                &amp;lt;apply-actions&amp;gt;&lt;br/&gt;
                    &amp;lt;action&amp;gt;&lt;br/&gt;
                        &amp;lt;output-action&amp;gt;&lt;br/&gt;
                            &amp;lt;output-node-connector&amp;gt;openflow:1:1&amp;lt;/output-node-connector&amp;gt;&lt;br/&gt;
                        &amp;lt;/output-action&amp;gt;&lt;br/&gt;
                    &amp;lt;/action&amp;gt;&lt;br/&gt;
                &amp;lt;/apply-actions&amp;gt;&lt;br/&gt;
            &amp;lt;/instruction&amp;gt;&lt;br/&gt;
        &amp;lt;/instructions&amp;gt;&lt;br/&gt;
        &amp;lt;table_id&amp;gt;0&amp;lt;/table_id&amp;gt;&lt;br/&gt;
        &amp;lt;id&amp;gt;b80f35b0-ebe9-476a-a36a-3bcb459cee86&amp;lt;/id&amp;gt;&lt;br/&gt;
        &amp;lt;match&amp;gt;&lt;br/&gt;
            &amp;lt;ipv4-destination&amp;gt;10.0.0.1&amp;lt;/ipv4-destination&amp;gt;&lt;br/&gt;
            &amp;lt;ethernet-match&amp;gt;&lt;br/&gt;
                &amp;lt;ethernet-type&amp;gt;&lt;br/&gt;
                    &amp;lt;type&amp;gt;2048&amp;lt;/type&amp;gt;&lt;br/&gt;
                &amp;lt;/ethernet-type&amp;gt;&lt;br/&gt;
            &amp;lt;/ethernet-match&amp;gt;&lt;br/&gt;
        &amp;lt;/match&amp;gt;&lt;br/&gt;
        &amp;lt;hard-timeout&amp;gt;0&amp;lt;/hard-timeout&amp;gt;&lt;br/&gt;
        &amp;lt;cookie&amp;gt;0&amp;lt;/cookie&amp;gt;&lt;br/&gt;
        &amp;lt;idle-timeout&amp;gt;0&amp;lt;/idle-timeout&amp;gt;&lt;br/&gt;
        &amp;lt;priority&amp;gt;1&amp;lt;/priority&amp;gt;&lt;br/&gt;
    &amp;lt;/flow&amp;gt;&lt;br/&gt;
&amp;lt;/table&amp;gt;&lt;/p&gt;


&lt;p&gt;We are getting spurious eth src/dst matches reported in stats which we shouldn&apos;t.&lt;/p&gt;</description>
                <environment>&lt;p&gt;Operating System: Mac OS&lt;br/&gt;
Platform: PC&lt;/p&gt;</environment>
        <key id="27292">OPNFLWPLUG-24</key>
            <summary>OF 1.0 statistics are reporting ethernet src/dst mac when none is present</summary>
                <type id="10100" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10310&amp;avatarType=issuetype">Improvement</type>
                                                <status id="5" iconUrl="https://jira.opendaylight.org/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="jyotsna.priya1@tcs.com">Jyotsna Priya</assignee>
                                    <reporter username="hagbard">Ed Warnicke</reporter>
                        <labels>
                    </labels>
                <created>Mon, 13 Jan 2014 00:36:17 +0000</created>
                <updated>Mon, 27 Sep 2021 09:01:01 +0000</updated>
                            <resolved>Wed, 22 Jan 2014 10:50:50 +0000</resolved>
                                                                    <component>General</component>
                        <due>Wed, 22 Jan 2014 00:00:00 +0000</due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                                                                <comments>
                            <comment id="55122" author="vishnoianil@gmail.com" created="Mon, 13 Jan 2014 19:33:11 +0000"  >&lt;p&gt;Following values are passed from library to plugin&lt;/p&gt;

&lt;p&gt;&amp;lt;ipv4-source&amp;gt;0.0.0.0/0&amp;lt;/ipv4-source&amp;gt;&lt;br/&gt;
&amp;lt;ipv4-destination&amp;gt;0.0.0.0/0&amp;lt;/ipv4-destination&amp;gt;&lt;/p&gt;

&lt;p&gt;&amp;lt;ethernet-source&amp;gt;&lt;br/&gt;
&amp;lt;address&amp;gt;00:00:00:00:00:00&amp;lt;/address&amp;gt;&lt;br/&gt;
&amp;lt;/ethernet-source&amp;gt;&lt;br/&gt;
&amp;lt;ethernet-destination&amp;gt;&lt;br/&gt;
&amp;lt;address&amp;gt;00:00:00:00:00:00&amp;lt;/address&amp;gt;&lt;br/&gt;
&amp;lt;/ethernet-destination&amp;gt;&lt;/p&gt;

&lt;p&gt;and plugin uses these values to create md-sal flow statistics object which  statistics-manager augment in the data store.&lt;/p&gt;

&lt;p&gt;Library is converting all the zero bytes of mac/ip address to 00:00:00:00:00:00 and 0.0.0.0 respectively while decoding openflow 1.0 flow statistics message and pass it to the plugin.&lt;/p&gt;

&lt;p&gt;Ideally library should look at the &lt;b&gt;wildcard&lt;/b&gt; byte and skip the values those were not set for the match. So if Ethernet src/dst are not set in wildcard, library should return null for both these values.&lt;/p&gt;

&lt;p&gt;Anil&lt;/p&gt;</comment>
                            <comment id="55123" author="michal.polkorab@gmail.com" created="Tue, 14 Jan 2014 08:07:34 +0000"  >&lt;p&gt;Hello,&lt;/p&gt;

&lt;p&gt;I think this is the logical point of view, which should be handled by Openflow Plugin. Because library does what it should do - translates received message. There might be more problems if the library passed nulls to plugin - reason might be unknown.&lt;/p&gt;

&lt;p&gt;I believe that the Openflow Plugin should take care of the addresses and check the wildcarded data.&lt;/p&gt;

&lt;p&gt;Please, feel free to discuss.&lt;/p&gt;

&lt;p&gt;Regards&lt;br/&gt;
Michal Polkorab&lt;/p&gt;</comment>
                            <comment id="55124" author="vishnoianil@gmail.com" created="Sun, 19 Jan 2014 21:16:09 +0000"  >&lt;p&gt;Hi Ed,&lt;/p&gt;

&lt;p&gt;I fixed this issue and pushed code changes through following two commits &lt;/p&gt;

&lt;p&gt;openflowplugin - &lt;a href=&quot;http://git.opendaylight.org/gerrit/4414&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://git.opendaylight.org/gerrit/4414&lt;/a&gt;&lt;br/&gt;
Controller - &lt;a href=&quot;http://git.opendaylight.org/gerrit/4416&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://git.opendaylight.org/gerrit/4416&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Can you please test it in your setup and confirm. I will close the bug afterwards.&lt;/p&gt;

&lt;p&gt;Thanks&lt;br/&gt;
Anil&lt;/p&gt;</comment>
                            <comment id="55125" author="hagbard@gmail.com" created="Tue, 21 Jan 2014 16:51:19 +0000"  >&lt;p&gt;Please verify fixed.&lt;/p&gt;</comment>
                            <comment id="55126" author="jyotsna.priya1@tcs.com" created="Wed, 22 Jan 2014 10:42:32 +0000"  >&lt;p&gt;Verified. The issue is resolved&lt;/p&gt;</comment>
                            <comment id="55127" author="jyotsna.priya1@tcs.com" created="Wed, 22 Jan 2014 10:42:32 +0000"  >&lt;p&gt;Attachment Screenshot from 2014-01-22 15:59:18.png has been added with description: Reolved&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="13840" name="Screenshot from 2014-01-22 15:59:18.png" size="189081" author="jyotsna.priya1@tcs.com" created="Wed, 22 Jan 2014 10:42:32 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10208" key="com.atlassian.jira.plugin.system.customfieldtypes:textfield">
                        <customfieldname>External issue ID</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>288</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10201" key="com.atlassian.jira.plugin.system.customfieldtypes:url">
                        <customfieldname>External issue URL</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[https://bugs.opendaylight.org/show_bug.cgi?id=288]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i02ylj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>