[OPNFLWPLUG-262] OF plugin incorrectly converted a MD-SAL flow which contained SET_VLAN_ID action.

Blocks — Mon, 27 Sep 2021 09:01:18 +0000

This issue was originally reported in ~~OPNFLWPLUG-222~~.

It seems that the patch has a problem.
https://git.opendaylight.org/gerrit/10280

At FlowConvertor.java, you can see how the OpenFlow plugin handles SET_VLAN_ID action.

public static List<FlowModInputBuilder> toFlowModInputs(Flow srcFlow, short version, BigInteger datapathId) {
List<FlowModInputBuilder> list = new ArrayList<>();

if (version >= OFConstants.OFP_VERSION_1_3 && isSetVlanIdActionCasePresent(srcFlow))

{ list.addAll(handleSetVlanIdForOF13(srcFlow, version, datapathId)); }

else

{ list.add(toFlowModInput(srcFlow, version, datapathId)); }

return list;
}

However, handleSetVlanIdForOF13() method ignores original match condition and changes the match condition incorrectly.

For example, when VTN Manager tries to install a flow entry which matches untagged frame, the OF plugin incorrectly deletes in_port match field, source/destination MAC Address match field, and change VLAN match field.

[Flow entry which VTN Mamanager tries to install]

Match
+ source MAC address
+ destination MAC address
+ in_port
+ untagged
Action
+ SET_VLAN_ID(100)
+ OUTPUT:2

[Flow entry which the OF Plugin sets to a switch]

Match
+ vlan_tci=0x1000/0x1000
Action
+ SET_FIELD(4196->vlan_vid)
+ OUTPUT:2

OpenDaylight JIRA

[OPNFLWPLUG-262] OF plugin incorrectly converted a MD-SAL flow which contained SET_VLAN_ID action.