OpenDaylight JIRA https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 [OPNFLWPLUG-270] Cannot set Mac Address in the Action Field https://jira.opendaylight.org/browse/OPNFLWPLUG-270 OpenFlowPlugin <p>code segment</p> <p>ActionBuilder ab = createActionBuilder(order);<br/> SetDlDstActionCaseBuilder caseBuilder = new SetDlDstActionCaseBuilder();<br/> SetDlDstActionBuilder dstBuilder = new SetDlDstActionBuilder();<br/> dstBuilder.setAddress(new MacAddress(mac));<br/> caseBuilder.setSetDlDstAction(dstBuilder.build());<br/> ab.setAction(caseBuilder.build());<br/> ab.build();</p> <p>or:</p> <p> MacAddress addr = new MacAddress(mac);<br/> return new ActionBuilder().setAction(<br/> new SetFieldCaseBuilder().setSetField(<br/> new SetFieldBuilder().setEthernetMatch(<br/> new EthernetMatchBuilder().setEthernetDestination(<br/> new EthernetDestinationBuilder().setAddress(addr).build())<br/> .build()).build()).build()).setKey(new ActionKey(0)).build();</p> <p>Error :</p> <p>&gt;<br/> &gt;<br/> &gt; Unable to serialize MAC address for<br/> &gt; input: MacAddress <span class="error">&#91;_value=00:01:02:03:04:05&#93;</span>.<br/> &gt;</p> <p>java.lang.IllegalArgumentException: Invalid character 'M' encountered<br/> at<br/> org.opendaylight.openflowjava.util.ByteBufUtils.macAddressToBytes(ByteBufUtils.java:260)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.serialization.match.AbstractOxmMacAddressSerializer.serialize(AbstractOxmMacAddressSerializer.java:26)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.serialization.match.AbstractOxmMacAddressSerializer.serialize(AbstractOxmMacAddressSerializer.java:20)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.util.OF13MatchSerializer.serializeMatchEntries(OF13MatchSerializer.java:89)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.util.OF13MatchSerializer.serialize(OF13MatchSerializer.java:50)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.util.OF13MatchSerializer.serialize(OF13MatchSerializer.java:34)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.serialization.factories.MultipartRequestInputFactory.serializeFlowBody(MultipartRequestInputFactory.java:220)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.serialization.factories.MultipartRequestInputFactory.serialize(MultipartRequestInputFactory.java:109)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.serialization.factories.MultipartRequestInputFactory.serialize(MultipartRequestInputFactory.java:70)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.serialization.SerializationFactory.messageToBuffer(SerializationFactory.java:36)<br/> ~<span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.core.OFEncoder.encode(OFEncoder.java:41)<br/> <span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.core.OFEncoder.encode(OFEncoder.java:26)<br/> <span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:111)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at<br/> io.netty.channel.DefaultChannelHandlerContext.invokeWrite(DefaultChannelHandlerContext.java:666)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at<br/> io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:724)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at<br/> io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:659)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at<br/> io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:645)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at<br/> io.netty.channel.DefaultChannelPipeline.write(DefaultChannelPipeline.java:878)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at io.netty.channel.AbstractChannel.write(AbstractChannel.java:231)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.connection.ChannelOutboundQueue.flush(ChannelOutboundQueue.java:184)<br/> <span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.connection.ChannelOutboundQueue.access$000(ChannelOutboundQueue.java:39)<br/> <span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> org.opendaylight.openflowjava.protocol.impl.connection.ChannelOutboundQueue$1.run(ChannelOutboundQueue.java:83)<br/> <span class="error">&#91;bundlefile:na&#93;</span><br/> at<br/> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:341)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:346)<br/> <span class="error">&#91;bundlefile:4.0.19.Final&#93;</span><br/> at<br/> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)</p> <p>Operating System: Linux<br/> Platform: PC</p> OPNFLWPLUG-270 Cannot set Mac Address in the Action Field Bug Resolved Won't Do Shuva Jyoti Kar Shuva Jyoti Kar Tue, 9 Sep 2014 15:32:18 +0000 Mon, 27 Sep 2021 09:01:19 +0000 Tue, 11 Nov 2014 09:43:30 +0000 General 0 11 <p>Attachment Screenshot from 2014-09-02 17:52:32.png has been added with description: Debugged MatchconvertorImplto find the mac address is wrongly set.</p> <p>Assigning it to Prasanna - in the meeting we had discussed this was a user error - but lets see.</p> <p>The Mac address in the addflowinputbuilder is actually set incorrectly</p> <p>Attachment error.JPG has been added with description: The Mac address in the flow input builder is actually set incorrectly</p> <p>Anil,</p> <p>I don't think it will be the case but could this be anything to do with the MAC address comparator bug?</p> <ul class="alternate" type="square"> <li>Abhijit</li> </ul> <p>Hi Abhijit,</p> <p>No, comparator comes to the picture where we fetch statistics data from switch. I believe this issue is happening while sending flow down to the switch.</p> <p>Thanks<br/> Anil</p> <p>Prasanna had sent the following note to Shuva after investigation:</p> <p>Hello,<br/> As discussed please move the bug(Mac address issue) to MD-SAL and assign it to default user.</p> <p>Abhijit:<br/> Shuva bypassed MD-SAL and tested with plugin and library and MAC address provision works.<br/> Rgds<br/> Prasanna</p> <p>Hello - A summary of the problem / solution was request at the MD-SAL status meeting today.</p> <p>Could someone please summarize what the problem is and what the propose solution is? People are just interested in what is going on with this one.</p> <p>Thank you!</p> <p>Devin</p> <p>Can you expand your problem report with the type of "mac" and how it is being initialized?</p> <p>Added testcase which shows this is not bug of MD-SAL.</p> <p><a href="https://git.opendaylight.org/gerrit/11307" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/11307</a></p> <p>Testcase write correctly constructed mac address in flow:<br/> ethernet-match with source mac, source destination and also apply-actions<br/> with set-dl-dst and set-dl-src.</p> <p>Then testcase read it and compares MAC address value with original one.<br/> This showcase MD-SAL did not change mac address as was supplied by user.</p> <p>As Robert mentioned, please show how this flow was constructed, because everything points it is user bug, when some did something as:</p> <p>MacAddress original;<br/> MacAddress mac = new MacAddress(original.toString()) instead of <br/> new MacAddress(original) or new MacAddress(original.getValue()).</p> <p>Returning it back to Openflowplugin, since submitted test case shows it is not Openflowplugin bug.</p> <p>Also integration testsuite <a href="https://jenkins.opendaylight.org/integration/job/integration-master-csit-base-of13/2629/robot/report/log.html" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/integration/job/integration-master-csit-base-of13/2629/robot/report/log.html</a><br/> reports flow with mac address as working.</p> <p>The attachment clearly shows that value of exposed MacAddress contains toString output of some probably internal instance of mac address:</p> <p>getAddress "MacAddressvalue="</p> <p>The attachment clearly shows that value of exposed MacAddress contains toString output of some (probably internal) instance of mac address:</p> <p>getAddress=MacAddress [_value=MacAddress <span class="error">&#91;_value=a0:b1:c2:d3:e4:35&#93;</span>]</p> <p>MacAddress.toString() looks like this:<br/> java.lang.StringBuilder builder = new java.lang.StringBuilder(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev100924.MacAddress.class.getSimpleName()).append(" [");<br/> boolean first = true;</p> <p> if (_value != null) {<br/> if (first) </p> { first = false; } <p> else </p> { builder.append(", "); } <p> builder.append("_value=");<br/> builder.append(_value);<br/> }<br/> return builder.append(']').toString();</p> <p>where _value is of type String and contains mac address in hex-format.</p> <p>Correct dump would look like this:<br/> getAddress=MacAddress <span class="error">&#91;_value=a0:b1:c2:d3:e4:35&#93;</span></p> <p>Assigning to reporter.</p> <p>The anamoly is identified in the org.opendaylight.controller.frm.impl.FlowForwarder which implements the DataChangeListener interface.</p> <p>Is it possible that the issue is in the DataListener code path?</p> <p>The anomaly is identified in the org.opendaylight.controller.frm.impl.FlowForwarder which implements the DataChangeListener interface.</p> <p>Is it possible that the issue is in the DataListener code path?</p> <p>The anomaly is identified in the org.opendaylight.controller.frm.impl.FlowForwarder which implements the DataChangeListener interface.</p> <p>Is it possible that the issue is in the DataListener code path?</p> <p>Hi Mehar,<br/> the attached picture of debug session is reason to believe that corrupted flow was created at the beginning of the pipeline:</p> <p>1. app/user creates flow<br/> 2. send it to datastore/config (using API or restconf)<br/> 3. FlowForwarder is notified and invokes appropriate rpc on corresponding service provider<br/> 4. openflowplugin translates flow from MD-SAL model to OFJava-API model and invokes OFJava rpc<br/> 5. OFJavaRPC encodes the input into flowMod message and writes it to byteBuffer<br/> 6. Netty.io sends content of the buffer to corresponding switch</p> <p>So if:</p> <ul class="alternate" type="square"> <li>the malformed macAddress was observed in FlowForwarder (3.).</li> <li>and there exist flows containing macAddress which successfully pass this pipeline<br/> then the input at the very beginning of the pipeline should be checked. And as it was already noted - there is probably somewhere copy constructor of macAddress invoked with string presentation of macAddress instead of object reference or macAddress.getValue().</li> </ul> <p>Please check input.</p> <p>Moved to Helium 1 as SFC (sfcofl2) is not blocked on this and there is still an opinion from the OpenFlow plugin team that there was an issue with the input (see Michal Rehak's last comment).</p> <p>no response</p> Development External issue ID 1772 External issue URL ODL SR Target Milestone Rank 0|i03047: