[OPNFLWPLUG-280] The return value of sal-compatibility on flow entry update API is always SUCCESS.

Mon, 27 Sep 2021 09:01:20 +0000

The return value of sal-compatibility on flow entry update API was always SUCCESS, even when an AD-SAL application tried to install an inconsistent flow entry with MD-SAL OF plugin via sal-compatibility, but a switch refused the flow entry.

When an AD-SAL application executes synchronous methods of the flow entry update API of the sal-compatibility, the sal-compatibility waits for the completion of the flow entry update, and returns control to the caller.
However, the sal-compatibility does not check the result of the flow entry update, and returns SUCCESS.

Due to this issue, AD-SAL application cannot know if a flow entry update is successful or not.

[How to reproduce the issue]

To reproduce the issue, let's try to install an inconsistent flow entry.

For example, please try to install the following flow entry into OF 1.3 switch using AD-SAL's NB API.

{
"actions": [
"SET_TP_SRC=8"
],
"ingressPort": "1",
"installInHw": "true",
"name": "flow1",
"node":

{ "id": "00:00:00:00:00:00:00:01", "type": "OF" }

,
"priority": "500"
}

http://192.168.2.56:8080/controller/nb/v2/flowprogrammer/default/node/OF/00:00:00:00:00:00:00:01/staticFlow/flow1

The above flow entry is inconsistent, because it does not specify IP protocol in match condition, but it has a SET_TP_SRC action.
Therefore, a switch refuses the flow entry to be installed, and it sends a OFPT_ERROR message whose type is OFPET_BAD_ACTION and whose code is OFPBAC_MATCH_INCONSISTENT.

OpenDaylight JIRA

[OPNFLWPLUG-280] The return value of sal-compatibility on flow entry update API is always SUCCESS.