https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-300 OpenFlowPlugin <p>Originally filed as <a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-263" title="IN_PORT Action flow mod not working" class="issue-link" data-issue-key="OPNFLWPLUG-263"><del>OPNFLWPLUG-263</del></a> <br/> <a href="https://bugs.opendaylight.org/show_bug.cgi?id=1725" class="external-link" target="_blank" rel="nofollow noopener">https://bugs.opendaylight.org/show_bug.cgi?id=1725</a> in Helium, and the request was to make this an enhancement for Lithium.</p> <p>------------------------------------<br/> When I try to create a flow via restconf with IN_PORT as the action I see that no flow mod is sent to the corresponding switch (via pkt capture on mininet vm running OVS). Also in the OSGI console, the following errors are seen:</p> <p>2014-09-05 14:58:33.456 PDT <span class="error">&#91;OFRpc-2&#93;</span> ERROR o.o.o.o.m.c.s.c.ActionConvertor - Invalid Port specified null for Output Action for OF version:OF13<br/> 2014-09-05 14:58:33.456 PDT <span class="error">&#91;OFRpc-2&#93;</span> ERROR o.o.o.o.m.c.s.c.ActionConvertor - Invalid Port specified null for Output Action for OF version:OF13<br/> 2014-09-05 14:58:33.456 PDT <span class="error">&#91;nioEventLoopGroup-12-6&#93;</span> WARN o.o.o.protocol.impl.core.OFEncoder - Message serialization failed: null</p> <p>Here is the flow_mod XML:</p> <p>&lt;flow xmlns="urn:opendaylight:flow:inventory"&gt;&lt;instructions&gt;&lt;instruction&gt;&lt;order&gt;0&lt;/order&gt;&lt;apply-actions&gt;&lt;action&gt;&lt;order&gt;0&lt;/order&gt;&lt;output-action&gt;&lt;output-node-connector&gt;IN_PORT&lt;/output-node-connector&gt;&lt;/output-action&gt;&lt;/action&gt;&lt;/apply-actions&gt;&lt;/instruction&gt;&lt;/instructions&gt;&lt;match&gt;&lt;ethernet-match&gt;&lt;ethernet-type&gt;&lt;type&gt;0x800&lt;/type&gt;&lt;/ethernet-type&gt;&lt;ethernet-source&gt;&lt;address&gt;00:ab:cd:ef:01:23&lt;/address&gt;&lt;/ethernet-source&gt;&lt;ethernet-destination&gt;&lt;address&gt;ff:ff:ff:ff:ff:ff&lt;/address&gt;&lt;/ethernet-destination&gt;&lt;/ethernet-match&gt;&lt;ipv4-source&gt;11.3.0.0/16&lt;/ipv4-source&gt;&lt;ipv4-destination&gt;99.0.0.0/8&lt;/ipv4-destination&gt;&lt;/match&gt;&lt;strict&gt;false&lt;/strict&gt;&lt;hard-timeout&gt;60&lt;/hard-timeout&gt;&lt;idle-timeout&gt;30&lt;/idle-timeout&gt;&lt;flow-name&gt;No Name&lt;/flow-name&gt;&lt;priority&gt;0&lt;/priority&gt;&lt;barrier&gt;false&lt;/barrier&gt;&lt;cookie&gt;0&lt;/cookie&gt;&lt;cookie_mask&gt;0&lt;/cookie_mask&gt;&lt;table_id&gt;22&lt;/table_id&gt;&lt;id&gt;161&lt;/id&gt;&lt;/flow&gt;</p> <p>If it matters, the REST details are a PUT @ /restconf/config/opendaylight-inventory:nodes/node/openflow:1/table/22/flow/161</p> <p>Attached are some robot test logs if it helps.</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-300

change INPORT action to IN_PORT (spec-wise)

Improvement Resolved Done Jamo Luhrsen Jamo Luhrsen Thu, 25 Sep 2014 21:19:36 +0000 Mon, 27 Sep 2021 09:01:21 +0000 Fri, 16 Jun 2017 07:34:56 +0000 General 0 7 <p><a href="https://git.opendaylight.org/gerrit/#/c/13291/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/13291/</a></p> <p>output action for the inport is implemented using the "INPORT" string. So the "IN_PORT" is invalid port no to install the flow.</p> <p>merged</p> <p>re-opening this bug. I think the original bug's intention was lost. The issue I brought up was that spec-wise, ovs-wise the port string is "IN_PORT" and the request was to change opendaylights representation from INPORT to IN_PORT. That was not done here.</p> <p>If it's decided that we have to stay with INPORT for some reason, it's fine.</p> <p>However, we are still throwing NPE's when IN_PORT is used.</p> <p>to summarize:</p> <p>1. we should use IN_PORT instead of INPORT<br/> 2. we should not throw NPEs.</p> <p>I am confused here, is this not implemented through loopback-action in the yang models?</p> <p>Luis,</p> <p>are you saying that you expect that we can use INPORT <del>OR</del> IN_PORT?</p> <p>JamO</p> <p>I am just saying I thought the set-loopback action was in the model to resend a packet to a port but I am not sure anymore. Michal can clarify I guess.</p> <p>(In reply to Luis Gomez from comment #6)<br/> &gt; I am just saying I thought the set-loopback action was in the model to<br/> &gt; resend a packet to a port but I am not sure anymore. Michal can clarify I<br/> &gt; guess.</p> <p>This is a bug just to say that I cannot push a flow if I use the string<br/> "IN_PORT" in the action. the string "INPORT" works fine. It's a syntactical<br/> thing, not a functional thing.</p> <p>Hi Luis - yes - set-loopback action is defined in yang but it is not implemented.</p> <p>We can change INPORT to IN_PORT or IN-PORT or whatever for Beryllium.</p> <p>Regarding NPE - yes - there should be some better explanation and some more appropriate expcetion (like illegalArgumentException).</p> <p>Subhash - are you planning to fix it?</p> <p>no life here, but still reasonable enhancement - updating summary and importance</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/58600/3" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/58600/3</a></p> <p>This issue is at wrong implementation of translation of name from enumeration. This patch fix this but still is possible to use INPORT for legacy reasons. Also fix NPE by using wrong port name.</p> Development External issue ID 2095 External issue URL Priority Rank 0|i030av: