https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-311 OpenFlowPlugin <p>While creating tests for MatchConvertorImpl I discovered few bugs. Bugs can bee seen here <a href="https://git.opendaylight.org/gerrit/#/c/11668/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/11668/</a> as TODO and FIXME and commented lines.</p> <p>1. mask computation of PbbIsid match entry (both ways) - wrong mask lengths</p> <ul class="alternate" type="square"> <li>PbbIsid mask length is 3</li> </ul> <p>2. add mask computation for ArpSpa and ArpTpa match entries</p> <ul class="alternate" type="square"> <li>mask conversion is missing for these fields</li> </ul> <p>3. finish implementation of vlan vid match entry</p> <ul class="alternate" type="square"> <li>isVlanIdPresent() is not set</li> </ul> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-311

MatchConvertorImpl bugs found during test creation

Bug Resolved Done Martin Bobak Michal Polkorab Thu, 30 Oct 2014 14:22:15 +0000 Mon, 27 Sep 2021 09:01:22 +0000 Thu, 28 May 2015 00:18:32 +0000 General 0 3 <p>1st part is solved by this commit : <a href="https://git.opendaylight.org/gerrit/#/c/13450/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/13450/</a></p> <p>patch set for poing 3 is proposed:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/14440/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/14440/</a></p> <p>remark to point 3.</p> <p>it seems that in MatchConvertorImpl.OfMatchToSALMatchConvertor() is in section with VlanVid.class set also _vlanIdPresent attribute.<br/> there is chain vlanBuilder.setVlanId(....).setVlanIdPresent().</p> <p>I agree. Point 3. seems like it has been fixed.</p> <p>I passed throu Michal's commit and searched for commented codes, FIXMEs, TODOs.</p> <p>It was possible to uncomment almost all of them. See patch set:</p> <p><a href="https://git.opendaylight.org/gerrit/14482" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/14482</a></p> <p>In MatchConvertorImplV13Test.testWithMatchEntriesWithMasks() it is necessary remove commented assertsEquals for checking equality masks of ethernet source and destination addresses.</p> <p>Problem from comment 6 (MatchConvertorImplV13Test.testWithMatchEntriesWithMasks() commented test) was fixed with patch:<br/> <a href="https://git.opendaylight.org/gerrit/14545" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/14545</a></p> Blocks CONTROLLER-1342 Development External issue ID 2280 External issue URL ODL SR Target Milestone Rank 0|i030db: