https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-338 OpenFlowPlugin <p>As reported here: <a href="https://lists.opendaylight.org/pipermail/l2switch-dev/2014-November/000347.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/l2switch-dev/2014-November/000347.html</a></p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-338

Buffer ID set to 0 instead of OFP_NO_BUFFER in PACKET_OUT messages

Bug Resolved Done Jamo Luhrsen Colin Dixon Mon, 19 Jan 2015 15:47:10 +0000 Mon, 27 Sep 2021 09:01:24 +0000 Wed, 18 Mar 2015 23:32:30 +0000 General 0 4 <p>Should be fixed by these two patches:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/14253/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/14253/</a></p> <p>re-opening as this was seen in the LLDP packet-outs being used for link discovery.</p> <p>packet capture attached.</p> <p>this patch may fix the issue, but until it's merged or a better one is made I wanted <br/> to open this to track it:</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/16677/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16677/1</a></p> <p>Attachment flow_mod_with_buffer_id_0.pcap has been added with description: flow mod using buffer_id == 0</p> <p>Hi,<br/> your patch is fine but there is later used a default value in case when bufferId is missing (FlowConvertor). </p> <p>I guess that the flow you are referring to is the one with xid=8 from the attached pcap file. This looks like flow from l2switch (table-miss-enforcer currently uses empty match).</p> <p>I tried to find some code and first dive gave me this:<br/> loopremover/implementation/src/main/java/org/opendaylight/l2switch/loopremover/flow/InitialFlowWriter.java; line 215</p> <p>Could you try to fix this locally and if it works, please file new bug to l2switch (and eventually push fix).</p> <p>Thank you.</p> <p>merged</p> <p>Jamo, do you use up-to-date sources? It looks like l2switch is already fixed - see <a href="https://jira.opendaylight.org/browse/L2SWITCH-30" title="Buffer ID set to 0 instead of OFP_NO_BUFFER in PACKET_OUT messages" class="issue-link" data-issue-key="L2SWITCH-30"><del>L2SWITCH-30</del></a>.</p> <p>Michal,</p> <p>I actually never pulled l2switch locally yet, so I have to assume I'm using latest code for that.</p> <p>But, this one issue (I thought) was just missed with the fix for <a href="https://jira.opendaylight.org/browse/L2SWITCH-30" title="Buffer ID set to 0 instead of OFP_NO_BUFFER in PACKET_OUT messages" class="issue-link" data-issue-key="L2SWITCH-30"><del>L2SWITCH-30</del></a> and only applies to the flow_mod for punting LLDP's to controller. I wonder if there is a higher level to make this change that buffer_id takes -1 every time by default (instead of default 0 for Long()) so it's not neccessary to force it to -1.</p> <p>Let me know what I can do though, if anything.</p> <p>Hi Jamo,<br/> I just tried with odl-l2switch-loopremover feature and it looks like the flow covering LLDP contains bufferId = 0xffff. Could you try with latest integration-karaf build? <br/> <a href="https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/distribution-karaf/0.3.0-SNAPSHOT/" class="external-link" target="_blank" rel="nofollow noopener">https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/distribution-karaf/0.3.0-SNAPSHOT/</a></p> <p>Regarding the default value for bufferId - currently if there is null input, we use OFConstants.OFP_NO_BUFFER.</p> <p>I'm pretty sure I hunted this down and fixed it everywhere in L2 Switch.</p> <p>I must have confused my setups with an older (probably Helium) instance when<br/> I found the buffer_id to be 0. I've tried with lithium builds before and after<br/> this patch (<a href="https://git.opendaylight.org/gerrit/#/c/16677/1" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16677/1</a>) was merged and I <b>do</b><br/> see -1 being used in buffer_id.</p> <p>we can back out that patch if you think it's necessary.</p> <p>sorry for adding confusion here. Marking this bug closed.</p> Blocks L2SWITCH-30 Development External issue ID 2608 External issue URL Rank 0|i030jb: