https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-372 OpenFlowPlugin <p>String.split is slow and broken (<a href="https://code.google.com/p/guava-libraries/wiki/StringsExplained#Splitter" class="external-link" target="_blank" rel="nofollow noopener">https://code.google.com/p/guava-libraries/wiki/StringsExplained#Splitter</a>). Guava provides reusable (= faster) and configurable (= not broken, works as configured) implementation.</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-372

Replace all String.split() with guava's Splitter

Improvement Resolved Done Shuva Jyoti Kar Michal Rehak Fri, 27 Feb 2015 12:39:10 +0000 Mon, 27 Sep 2021 09:01:26 +0000 Tue, 15 Aug 2017 18:05:14 +0000 General 0 8 <p><a href="https://git.opendaylight.org/gerrit/#/c/16179/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16179/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/16180/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16180/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/16181/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16181/</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/16183/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16183/</a></p> <p>Michal,</p> <p>Any thoughts on this?</p> <p>Thanks,<br/> Abhijit</p> <p>This is technical depth and does not affect exposed API. As soon as we have settled API-freeze related changes I can finish this.</p> <p>Given that Guava's Splitter doesn't incur the overhead of regular expressions when you don't ask for it, and is very fast as a general rule and it is much more predictable than String.split(), this is indeed a nice enhancement.</p> <p>Patches were not merged and need to be rewritten, cancelling WFR status for now.</p> <p>Some of the patches were merged:</p> <p><a href="https://git.opendaylight.org/gerrit/#/q/project:openflowplugin+message:2771+status:merged" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/q/project:openflowplugin+message:2771+status:merged</a></p> <p>Guava splitter is quicker just only the results it gives back. It is not creating a new string objects. So in long string maybe it will be quicker, but with short string with two or just few substrings it will be slower even when we create a new strings object anyway.</p> <p>So this enhancement is no needed anyway.</p> <p>Closing</p> <p>&gt; in long string maybe it will be quicker,<br/> &gt; but with short string with two or just few substrings it will be slower</p> <p>Can we measure that?<br/> And by the way, the correct status seems to be WORKSFORME.</p> Development External issue ID 2771 External issue URL Issue Type ODL SR Target Milestone Rank 0|i030qv: