https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-385 OpenFlowPlugin <p>Hi controller devs,</p> <p>Our CI System Test has detected a regression in AD-SAL NSF functionality:</p> <ul class="alternate" type="square"> <li>For mininet OF10 devices, switch manager shows no node information</li> <li>For mininet OF13 devices, switch manager misses some nodes (randomly)</li> </ul> <p>Steps to reproduce:</p> <p>1) Start controller, install features: odl-openflowplugin-flow-services-ui, odl-openflowplugin-adsal-compatibility, odl-nsf-all</p> <p>2) start mininet: sudo mn --topo tree,2 --controller 'remote,ip=127.0.0.1'</p> <p>3) Check switch manager at: <a href="http://localhost:8282/controller/nb/v2/switchmanager/default/nodes" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8282/controller/nb/v2/switchmanager/default/nodes</a></p> <p>By tracing back the error, 2 possible patches show up:</p> <p><a href="https://git.opendaylight.org/gerrit/16140" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/16140</a> (controller message bus)<br/> <a href="https://git.opendaylight.org/gerrit/#/c/16821" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16821</a> (yangtool enum)</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-385

AD-SAL switch manager does not work

Bug Resolved Done Tony Tkacik Luis Gomez Mon, 23 Mar 2015 00:35:34 +0000 Mon, 27 Sep 2021 09:01:27 +0000 Tue, 17 Nov 2015 17:45:04 +0000 General 0 5 <p>Messagebus is not present / installed in CSIT so it should not be the cause, since it did not touched any codepath in openflowplugin</p> <p>The second one is more potential, but API contract were preserved, which effectively means ad-sal compatibility was relying on some implementation detail.</p> <p>Hi Tony, I am going to remove the adsal test for now to restore the system test and unblock integration openflow patches, let me know when this is fixed so that I can restore the adsal test.</p> <p>Thanks/Luis</p> <p>It seems to me that the root cause of this issue (<a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-385" title="AD-SAL switch manager does not work" class="issue-link" data-issue-key="OPNFLWPLUG-385"><del>OPNFLWPLUG-385</del></a>) is in the sal-compatibility in the openflowplugin.git. </p> <p>The sal-compatibility registers itself with MD-SAL as a DataChangeListener for "Nodes/Node".<br/> On the registration, the sal-compatibility, however, sets DataChangeScope.BASE as the scope of the data change.</p> <p> <span class="error">&#91;legacy/sal-compatibility/src/main/java/org/opendaylight/openflowplugin/legacy/sal/compatibility/AbstractDataChangeListener.java&#93;</span><br/> 113 protected void registrationListener(final DataBroker db, int i) {<br/> 114 try {<br/> 115 listenerRegistration = db.registerDataChangeListener(LogicalDatastoreType.OPERATIONAL,<br/> 116 getWildCardPath(), this, DataChangeScope.BASE);</p> <p>Since the scope is <b>BASE</b>, MD-SAL does not notify the sal-compatibility of the data change of children and augmentation of "Nodes/Node".<br/> Though the sal-compatibility needs the data in "FlowCapableNode", which is the augmentation of "Nodes/Node", to update Node information.</p> <p> <span class="error">&#91;legacy/sal-compatibility/src/main/java/org/opendaylight/openflowplugin/legacy/sal/compatibility/NodeDataChangeListener.java&#93;</span><br/> 31 protected void add(InstanceIdentifier&lt;Node&gt; createKeyIdent, Node node) {<br/> 32 FlowCapableNode fcn = node.getAugmentation(FlowCapableNode.class);<br/> 33 if(fcn != null) {</p> <p>Why did it work well before?<br/> I <b>guess</b> that MD-SAL wrongly handled the "DataChangeScope.BASE", and it leaked data changes to listeners before the following patch was merged.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/16821" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/16821</a><br/> The leak might cover up the sal-compatibility issue.</p> <p>I've submitted a patch to the openflowplugin.git.<br/> <a href="https://git.opendaylight.org/gerrit/#/c/17727/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17727/</a><br/> The patch changes the scope of the data change from <b>BASE</b> to <b>SUBTREE</b>.</p> <p>In my machine, I observed that the patch fixed the issue (<a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-385" title="AD-SAL switch manager does not work" class="issue-link" data-issue-key="OPNFLWPLUG-385"><del>OPNFLWPLUG-385</del></a>).<br/> By the result, I'm convinced that the root cause of this issue (<a href="https://jira.opendaylight.org/browse/OPNFLWPLUG-385" title="AD-SAL switch manager does not work" class="issue-link" data-issue-key="OPNFLWPLUG-385"><del>OPNFLWPLUG-385</del></a>) is in the sal-compatibility.</p> <p>Michal and Anil have +1-ed the change:</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/17727/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17727/</a></p> <p>Please do not close the bug - see Michal's comments on this (this is a temporary work around &amp; actual fix needs to be done separately):</p> <p><a href="https://lists.opendaylight.org/pipermail/openflowplugin-dev/2015-April/002887.html" class="external-link" target="_blank" rel="nofollow noopener">https://lists.opendaylight.org/pipermail/openflowplugin-dev/2015-April/002887.html</a></p> <p>OK, just let me know when I should restore the adsal tests in the CI. For now I am verifying this patch with new patch test job:</p> <p><a href="https://jenkins.opendaylight.org/releng/view/integration/job/integration-patch-test-master/1/" class="external-link" target="_blank" rel="nofollow noopener">https://jenkins.opendaylight.org/releng/view/integration/job/integration-patch-test-master/1/</a></p> <p>BR/Luis</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/17727/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/17727/</a> merged</p> <p>This bug is part of the project to Move all ADSAL associated component bugs to ADSAL</p> Development External issue ID 2886 External issue URL ODL SR Target Milestone Rank 0|i030tr: