https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-413 OpenFlowPlugin <p>This was masked by 3050 and thus not visible.</p> <p>If you have a match with entriesBuilder.setHasMask(false); </p> <p>(as in some testcases), the following logic in MatchCovertorImpl results in an invalid prefix (ip address instead of prefix)</p> <p>if (maskMatchEntry != null) {<br/> ipv6PrefixStr += PREFIX_SEPARATOR<br/> + MatchConvertorUtil.ipv6NetmaskArrayToCIDRValue(maskMatchEntry.getMask());<br/> }</p> <p>It should be:</p> <p>if (maskMatchEntry != null) {<br/> ipv6PrefixStr += PREFIX_SEPARATOR<br/> + MatchConvertorUtil.ipv6NetmaskArrayToCIDRValue(maskMatchEntry.getMask());<br/> } else {<br/> pv6PrefixStr += PREFIX_SEPARATOR + "128";<br/> }</p> <p>Similar for IPv4 prefixes.</p> <p>I am quoting sources and lines from Helium. I have not looked at master which I suspect is likely to have the same bug.</p> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-413

Incorrect logic in matchbuilder

Bug Resolved Done Unassigned Anton Ivanov Thu, 23 Apr 2015 09:54:17 +0000 Mon, 27 Sep 2021 09:01:29 +0000 Mon, 22 Aug 2016 12:17:56 +0000 General 0 5 <p>There is a fix for v4 in the code already along the same lines. It is just missing for v6 because the regexp matching breakage in the generated Ipv6Prefix.java was not catching it.</p> <p>FlowRemovedTranslator has the same problem.</p> <p>In either case if the user originally specified the flow correctly (/128) this will result in opstate != confstate.</p> <p>Gerrit: </p> <p><a href="https://git.opendaylight.org/gerrit/18917" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/18917</a></p> <p>Gerrit also has the IP addresses in incorrect non-RFC compliant notation fixed (which will probably break it). If it does not pass I will resubmit, but we have to fix those elsewhere. The current notation is bogus as it is pretty much guaranteed to result in a opstate != confstate situation</p> <p>Anton,</p> <p>Are you planning to resubmit the fix? It says abandoned. Also added Michal Rehak to make sure he is aware of the patch.</p> <p>Abhijit</p> <p>I need to reread Li code. I think that was fixed as a part of a different gerrit.</p> <p>Hope this issue is fixed - <a href="https://git.opendaylight.org/gerrit/#/c/19140/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/19140/</a></p> <p>Any reason why its open ?</p> Development External issue ID 3053 External issue URL Rank 0|i030zz: