<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 20:32:26 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[OPNFLWPLUG-423] StatisticsManager misses nodeadded and noderemoved operations when exceptions occur</title>
                <link>https://jira.opendaylight.org/browse/OPNFLWPLUG-423</link>
                <project id="10155" key="OPNFLWPLUG">OpenFlowPlugin</project>
                    <description>&lt;p&gt;Currently the nodeadded and node removed operations are batched along with the stat notification operations.&lt;br/&gt;
On exception in the tx chain, all the operations in teh queue are discarded. &lt;/p&gt;

&lt;p&gt;This design is applicable to the stats but is not suited for node added and node removed.&lt;/p&gt;

&lt;p&gt;Node added and node removed should be applied directly and should not be queued.&lt;/p&gt;

&lt;p&gt;Issue is mostly seen with 250+ switches on a 3 node cluster.&lt;/p&gt;

&lt;p&gt;This might solve many issues with related to node added and node removed being submitted.&lt;/p&gt;</description>
                <environment>&lt;p&gt;Operating System: All&lt;br/&gt;
Platform: All&lt;/p&gt;</environment>
        <key id="27691">OPNFLWPLUG-423</key>
            <summary>StatisticsManager misses nodeadded and noderemoved operations when exceptions occur</summary>
                <type id="10104" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10303&amp;avatarType=issuetype">Bug</type>
                                                <status id="5" iconUrl="https://jira.opendaylight.org/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="kramesha@cisco.com">Kamal Rameshan</assignee>
                                    <reporter username="kramesha@cisco.com">Kamal Rameshan</reporter>
                        <labels>
                    </labels>
                <created>Wed, 29 Apr 2015 21:00:56 +0000</created>
                <updated>Mon, 27 Sep 2021 09:01:29 +0000</updated>
                            <resolved>Tue, 2 Jun 2015 22:17:34 +0000</resolved>
                                                                    <component>General</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="56821" author="kramesha@cisco.com" created="Thu, 30 Apr 2015 02:15:57 +0000"  >&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/19360/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/19360/&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="56822" author="vdemcak@cisco.com" created="Mon, 4 May 2015 14:10:16 +0000"  >&lt;p&gt;Hi Kamal,&lt;/p&gt;

&lt;p&gt;you have right, a tx chain fail could bring a lot of problems. But a queue is holding the operation ordering in general. So please try to thing about next scenario (e.g. device are quickly connect/disconnect, so you are able to add bad statistics from disconnected device to new connected device - because we lost the ordering).&lt;/p&gt;

&lt;p&gt;So could we submit add/remove node as own tx commit ? &lt;br/&gt;
I mean, we could submit tx before every add/remove node operation, wait for result and submit every add/remove like separate submit. But we have to take out all add/remove node operation in cleanDataStoreOperQueue method and we have to try to send it again in same order.&lt;/p&gt;</comment>
                            <comment id="56823" author="kramesha@cisco.com" created="Mon, 4 May 2015 18:08:02 +0000"  >&lt;p&gt;Hi Vaclav,&lt;/p&gt;

&lt;p&gt;I guess writing of stale-stat operations is an issue we still have, since inventory-manager processes the node-removed instantly and stats-manager processes it later. So for that brief period, we do see stale stats.&lt;/p&gt;

&lt;p&gt;I see it as below: we have 2 managers writing to operational. Inv and stats. And i feel there should not be a delay in both of these managers processing the nodeadded and node-removed. As a delay causes problems.&lt;br/&gt;
How to handle the stale stat operations, is a design issue. &lt;br/&gt;
May be we can generate a uid when a node gets added to the stats and we can associate that uid to the stat-ds-operation and feed it to the queue. On removal if the uid is not the one in the nodecollector map, it is a stale operation to be ignored. There can be many design solutions to figure out the stale operations.&lt;/p&gt;

&lt;p&gt;In short, i dont see a value add in queueing the node-added and removed as part of the other non-priority stat operations.&lt;/p&gt;</comment>
                            <comment id="56824" author="kramesha@cisco.com" created="Mon, 4 May 2015 22:09:53 +0000"  >&lt;p&gt;Hi Vaclav,&lt;/p&gt;

&lt;p&gt;I have added a simple fix to mark stat operations via UUIDs to ignore stale operations.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/19360/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/19360/&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Let me know if this addresses the issue.&lt;/p&gt;

&lt;p&gt;Thanks&lt;br/&gt;
Kamal&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10208" key="com.atlassian.jira.plugin.system.customfieldtypes:textfield">
                        <customfieldname>External issue ID</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3085</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10201" key="com.atlassian.jira.plugin.system.customfieldtypes:url">
                        <customfieldname>External issue URL</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[https://bugs.opendaylight.org/show_bug.cgi?id=3085]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i03127:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>