<!-- 
RSS generated by JIRA (8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d) at Wed Feb 07 20:32:36 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>OpenDaylight JIRA</title>
    <link>https://jira.opendaylight.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.20.10</version>
        <build-number>820010</build-number>
        <build-date>22-06-2022</build-date>
    </build-info>


<item>
            <title>[OPNFLWPLUG-478] with switch-features-mandatory set to true, switch without required features should not be allowed to connect</title>
                <link>https://jira.opendaylight.org/browse/OPNFLWPLUG-478</link>
                <project id="10155" key="OPNFLWPLUG">OpenFlowPlugin</project>
                    <description>&lt;p&gt;In the Lithium plugin redesign we now have a configuration to make switch features required:&lt;/p&gt;

&lt;p&gt;~$ egrep features distribution-2182/etc/opendaylight/karaf/42-openflowplugin-Li.xml &lt;br/&gt;
                    &amp;lt;switch-features-mandatory&amp;gt;true&amp;lt;/switch-features-mandatory&amp;gt;&lt;/p&gt;


&lt;p&gt;By default it is false and allows switches (e.g. OVS 2.0.2) that do not support all the&lt;br/&gt;
features to still operate as they have in the past with ODL.&lt;/p&gt;

&lt;p&gt;If that config is set to true, we are currently still holding a connection with an &lt;br/&gt;
unsupported switch.  The switch will be shown in operational store as connected and&lt;br/&gt;
thus will even show up in the GUI.  However, we cannot interact with the switch as &lt;br/&gt;
we&apos;d expect (e.g.pushing flows, reading tables).  A REST call to config store to get flows &lt;br/&gt;
for this connected device will hang for a while and finally give a 500 internal error.&lt;/p&gt;

&lt;p&gt;If there is a good reason to retain the connection of this switch without the mandatory&lt;br/&gt;
features, then we need to make it clear to the user and be able to handle REST interactions&lt;br/&gt;
without hanging.  I don&apos;t know of a good reason, so my current opinion is that we can&lt;br/&gt;
just reject the connection up front.&lt;/p&gt;</description>
                <environment>&lt;p&gt;Operating System: All&lt;br/&gt;
Platform: All&lt;/p&gt;</environment>
        <key id="27746">OPNFLWPLUG-478</key>
            <summary>with switch-features-mandatory set to true, switch without required features should not be allowed to connect</summary>
                <type id="10104" iconUrl="https://jira.opendaylight.org/secure/viewavatar?size=xsmall&amp;avatarId=10303&amp;avatarType=issuetype">Bug</type>
                                                <status id="5" iconUrl="https://jira.opendaylight.org/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="jluhrsen">Jamo Luhrsen</assignee>
                                    <reporter username="jluhrsen">Jamo Luhrsen</reporter>
                        <labels>
                    </labels>
                <created>Tue, 2 Jun 2015 22:52:40 +0000</created>
                <updated>Mon, 27 Sep 2021 09:01:33 +0000</updated>
                            <resolved>Mon, 26 Jun 2017 11:47:09 +0000</resolved>
                                                                    <component>General</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>7</watches>
                                                                                                                <comments>
                            <comment id="57007" author="aivanov@brocade.com" created="Wed, 9 Sep 2015 15:22:17 +0000"  >&lt;p&gt;There is a corresponding FIXME on line 290 in openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/DeviceManagerImpl.java&lt;/p&gt;

&lt;p&gt;The session is indeed not removed - that is the present code behavior.&lt;/p&gt;</comment>
                            <comment id="57008" author="aivanov@brocade.com" created="Fri, 11 Sep 2015 06:58:09 +0000"  >&lt;p&gt;That whole section of the code needs fixing:&lt;/p&gt;

&lt;p&gt;It does not have a FSM for the connected switch. As a result it is likely to show other undefined or erroneous behaviour when a &quot;switch&quot; drops or stalls a connection mid-negotiation.&lt;/p&gt;

&lt;p&gt;This needs a rewrite +  a corresponding torture test (unit test or test using a 3rd party openflow library).&lt;/p&gt;

&lt;p&gt;Please do not mark as resolved until there is a matching test.&lt;/p&gt;</comment>
                            <comment id="57009" author="tomas.slusny@pantheon.tech" created="Fri, 7 Apr 2017 11:42:17 +0000"  >&lt;p&gt;Right now when this happens, entire connection is closed on both carbon and boron in Lithium design, so this should be fixed now, so this one can probably be closed.&lt;/p&gt;</comment>
                            <comment id="57010" author="jluhrsen" created="Fri, 7 Apr 2017 16:47:48 +0000"  >&lt;p&gt;(In reply to Tomas Slusny from comment #3)&lt;br/&gt;
&amp;gt; Right now when this happens, entire connection is closed on both carbon and&lt;br/&gt;
&amp;gt; boron in Lithium design, so this should be fixed now, so this one can&lt;br/&gt;
&amp;gt; probably be closed.&lt;/p&gt;

&lt;p&gt;This is an old bug, but I just tried with ovs 2.0.2 (what I noted originally)&lt;br/&gt;
and the switch connects and seems to function as you&apos;d expect with a &lt;br/&gt;
connected switch (can push flows, view in config/operational, etc)&lt;/p&gt;

&lt;p&gt;the question is then, should this old ovs 2.0.2 be rejected if mandatory&lt;br/&gt;
switch features are configured as true?&lt;/p&gt;</comment>
                            <comment id="57011" author="jozef.bacigal@pantheon.tech" created="Mon, 5 Jun 2017 05:58:45 +0000"  >&lt;p&gt;&lt;a href=&quot;https://git.opendaylight.org/gerrit/#/c/58179/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.opendaylight.org/gerrit/#/c/58179/&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_11400" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10208" key="com.atlassian.jira.plugin.system.customfieldtypes:textfield">
                        <customfieldname>External issue ID</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3549</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10201" key="com.atlassian.jira.plugin.system.customfieldtypes:url">
                        <customfieldname>External issue URL</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[https://bugs.opendaylight.org/show_bug.cgi?id=3549]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10000" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i031ef:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>