https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-513 OpenFlowPlugin <p>This bug is found in stable/lithium and also main.</p> <p>2015-07-07 14:37:15,748 | WARN | ds-oper-thread-0 | StatisticsManagerImpl | 264 - org.opendaylight.openflowplugin.applications.statistics-manager - 0.1.1.SNAPSHOT | Unhandled exception during processing statistics. Restarting transaction chain.<br/> java.lang.NullPointerException<br/> at org.opendaylight.openflowplugin.applications.statistics.manager.impl.StatListenCommitFlow$TableFlowUpdateState.removeUnreportedFlows(StatListenCommitFlow.java:464)<span class="error">&#91;264:org.opendaylight.openflowplugin.applications.statistics-manager:0.1.1.SNAPSHOT&#93;</span><br/> at org.opendaylight.openflowplugin.applications.statistics.manager.impl.StatListenCommitFlow.statsFlowCommitAll(StatListenCommitFlow.java:262)<span class="error">&#91;264:org.opendaylight.openflowplugin.applications.statistics-manager:0.1.1.SNAPSHOT&#93;</span><br/> at org.opendaylight.openflowplugin.applications.statistics.manager.impl.StatListenCommitFlow.access$000(StatListenCommitFlow.java:82)<span class="error">&#91;264:org.opendaylight.openflowplugin.applications.statistics-manager:0.1.1.SNAPSHOT&#93;</span><br/> at org.opendaylight.openflowplugin.applications.statistics.manager.impl.StatListenCommitFlow$2.applyOperation(StatListenCommitFlow.java:208)<span class="error">&#91;264:org.opendaylight.openflowplugin.applications.statistics-manager:0.1.1.SNAPSHOT&#93;</span></p> <p>After the exception, there were side-effect null pointer exceptions whenever there were statistics poll.</p> <p>The fix is simple:<br/> diff --git a/applications/statistics-manager/src/main/java/org/opendaylight/open<br/> index 71d34dc..2180e09 100644<br/> &#8212; a/applications/statistics-manager/src/main/java/org/opendaylight/openflowplu<br/> +++ b/applications/statistics-manager/src/main/java/org/opendaylight/openflowplu<br/> @@ -461,7 +461,7 @@ public class StatListenCommitFlow extends StatAbstractListen<br/> final InstanceIdentifier&lt;Flow&gt; flowRef = tableRef.child(Flow.cl<br/> if (nodeDeleteMap != null &amp;&amp; flowKey.getId().getValue().startsW<br/> final Integer lifeIndex = nodeDeleteMap.get(flowRef);</p> <ul class="alternate" type="square"> <li>if (lifeIndex &gt; 0) {<br/> + if (lifeIndex != null &amp;&amp; lifeIndex &gt; 0) { break; } <p> else {<br/> nodeDeleteMap.remove(flowRef);</p></li> </ul> <p>Operating System: All<br/> Platform: All</p> OPNFLWPLUG-513

Exception at removeUnreportedFlows in StatisticsManagerImpl

Bug Resolved Done Monika Verma Henry Fung Wed, 8 Jul 2015 05:31:19 +0000 Mon, 27 Sep 2021 09:01:36 +0000 Fri, 27 Nov 2015 04:26:31 +0000 General 0 6 <p>Reassigned to sunaina.khanna</p> <p>Hi Henry,<br/> Can you please tell me how to replicate this bug.I tried to replicate the bug but no error is shown on deleting the unreported flow via rest on the karaf window.</p> <p>Hi Sunaina,<br/> I had many flows programmed, deleted, and reprogrammed via FRM. I know it is not easy to reproduce, but by code inspection, we can tell something wrong.</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/25111/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/25111/</a> merged<br/> (would be nice to have unit test proving this right)</p> <p>Sure,but I could not find the test cases for the class.Should I implement the test cases for the same?</p> <p>Well best practices claim that every fix should be accompanied by (unit) test proving that fix right. If such a test already exits then fix the test first so that it fails upon that issue.<br/> If no test exists yet and if sticking to TTD then you can even first write the unit test failing upon the issue. And then add the fix so that your push will contain passing green test and fix.</p> <p>In this case you can create new test class and focus on that particular method (removeUnreportedFlows()).</p> <p>And of course if you feel confident in adding unit test coverage for class StatListenCommitFlow then you are welcome to cover even more of it.</p> <p>Added the unit tests covering the method removeUnreportedFlows() and some part of method statsFlowCommitAll()<br/> Gerrit ID: <a href="https://git.opendaylight.org/gerrit/#/c/30244/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/30244/</a></p> Development External issue ID 3957 External issue URL Rank 0|i031m7: