https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-533 OpenFlowPlugin <p>Rest Post operation is not working for group function.</p> <p>when adding new group, Post operation is not working, getting "400" error code.</p> <p>But Put is working for adding groups to the controller.</p> <p>i have used to add following group action </p> <p>{"group": [{"group-name": "TestFlow-0", "buckets": {"bucket": [{"action": <span class="error">&#91;{&quot;order&quot;: 0, &quot;pop-vlan-action&quot;: {}}&#93;</span>, "bucket-id": 0, "watch_group": 0}]}, "group-type": "group-indirect", "group-id": 9, "barrier": "false"}]}</p> <p>Operating System: Linux<br/> Platform: Other</p> OPNFLWPLUG-533

Rest Post operation is not working for group

Bug Resolved Cannot Reproduce Abbas P Pareedkunju Anpukarasi Muthukumaran Tue, 11 Aug 2015 10:22:04 +0000 Mon, 27 Sep 2021 09:01:37 +0000 Tue, 23 Aug 2016 07:46:07 +0000 General 0 6 <p>(In reply to Anpukarasi Muthukumaran from comment #0)<br/> &gt; Rest Post operation is not working for group function.<br/> &gt; <br/> &gt; when adding new group, Post operation is not working, getting "400" error<br/> &gt; code.<br/> &gt; <br/> &gt; But Put is working for adding groups to the controller.<br/> &gt; <br/> &gt; i have used to add following group action <br/> &gt; <br/> &gt; {"group": [{"group-name": "TestFlow-0", "buckets": {"bucket": [{"action":<br/> &gt; <span class="error">&#91;{&quot;order&quot;: 0, &quot;pop-vlan-action&quot;: {}}&#93;</span>, "bucket-id": 0, "watch_group": 0}]},<br/> &gt; "group-type": "group-indirect", "group-id": 9, "barrier": "false"}]}</p> <p>Hi Anpukarasi Muthukumaran</p> <p>Can you provide the steps to reproduce this ? <br/> If you have solid reproduction step, I can take this up</p> <p>Thanks &amp; Regards,<br/> Dhevendran K</p> <p>Hi Anpukarasi,</p> <p>I would like to have a look in to your issue.<br/> Can you please share the XML file you are trying to use for POST calls, to reproduce this fault?</p> <p>//Abbas</p> <p>(In reply to Abbas P Pareedkunju from comment #2)<br/> &gt; Hi Anpukarasi,<br/> &gt; <br/> &gt; I would like to have a look in to your issue.<br/> &gt; Can you please share the XML file you are trying to use for POST calls, to<br/> &gt; reproduce this fault?<br/> &gt; <br/> &gt; //Abbas</p> <p>Hi Abbas,</p> <p>I used following json for testing this issue.</p> <p>{"group": [{"group-name": "TestFlow-0", "buckets": {"bucket": [{"action": <span class="error">&#91;{&quot;order&quot;: 0, &quot;pop-vlan-action&quot;: {}}&#93;</span>, "bucket-id": 0, "watch_group": 0}]}, "group-type": "group-indirect", "group-id": 9, "barrier": "false"}]}</p> <p>I have raised this issue on almost a year back. Not sure if this issue still there.</p> <p>Thanks<br/> Anpu</p> <p>Thanks for the information. Meantime, I could reproduce the fault with a REST Client, and seeing the same behavior, POST shows "400: Bad Request" <br/> Working on the possibility to fix this.</p> <p>Hi Anpu,</p> <p>I have seen that the ODL code handles the POST operations with an additional check, which causes this problem.<br/> Have sent a email to the Code owner for the suspected area, awaiting his reply to see the feasibility to correct this.</p> <p>Thanks,<br/> Abbas</p> <p>Looking for an a reply on the below queries.</p> <p>On this issue debug, found that the problem lies in the NodeBodyReader classes (JsonNormalizedNodeBodyReader and XmlNormalizedNodeBodyReader).</p> <p>When the JsonParserStream object is created in JsonNormalizedNodeBodyReader, <br/> the value for 'parentSchema' passed is "list group" for the POST operation calls<br/> whereas, for PUT operations the value is "list node".</p> <p>The code to populate 'parentSchema' in JsonNormalizedNodeBodyReader.java has a special check for POST calls as below<br/> If the isPost flag on -&gt; populate parentSchema from getSchemaNode() which returns value of schemaNode <br/> else -&gt; populate from getSchemaContext() which returns value of schemaContext from InstanceIdentifierContext.java</p> <p>Due to this handling, on POST operations, JsonParserStream.read() will try to resolve namespace by resolveNamespace() which throws IllegalStateException since it is not able to find schema node with type group.</p> <p>But for PUT operations, resolveNamespace() gets the valid schema name and hence able to proceed.</p> <p>A similar handling is seen for XML types aswell in XmlNormalizedNodeBodyReader.<br/> Here for both POST and PUT, schemaNode gets a value "list group"<br/> But XmlNormalizedNodeBodyReader has a dedicated check for isPost. <br/> If it is POST, it goes to the method findPathToSchemaNodeByName() where it tries to find the child nodes of schemaNode which would fail.<br/> For PUT, it will never go to this method to check.</p> <p>Bit confused on why this special check would be required for POST. <br/> Looking for some clarity on this.<br/> Also on if it is OK to use the same XML/JSON for both PUT and POST.</p> <p>Thanks,<br/> Abbas</p> <p>POST is for creating new data and PUT is for creating and updating.</p> <p>Try to modify your XML/JSON inputs or URIs. Use different inputs for POST and different for PUT.</p> <p>example (see differences in XML/JSON for POST and PUT):</p> <p>YANG model: <a href="https://github.com/opendaylight/controller/blob/7257dc4ecacf3e4d08273c31accd945fb8f3e769/opendaylight/md-sal/samples/clustering-test-app/model/src/main/yang/car.yang?" class="external-link" target="_blank" rel="nofollow noopener">https://github.com/opendaylight/controller/blob/7257dc4ecacf3e4d08273c31accd945fb8f3e769/opendaylight/md-sal/samples/clustering-test-app/model/src/main/yang/car.yang?</a></p> <p>PUT:</p> <p>URI: <a href="http://localhost:8181/restconf/config/car:cars" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/car:cars</a></p> <p>JSON:</p> <p>{<br/> cars : {<br/> car-entry : </p> { id : "0", year : "2000" } <p> }<br/> }</p> <p>XML:</p> <p>&lt;cars xmlns="urn:opendaylight:params:xml:ns:yang:controller:config:sal-clustering-it:car"&gt;<br/> &lt;car-entry&gt;<br/> &lt;id&gt;0&lt;/id&gt;<br/> &lt;year&gt;2000&lt;/year&gt;<br/> &lt;/car-entry&gt;<br/> &lt;/cars&gt;</p> <p>POST:</p> <p>URI: <a href="http://localhost:8181/restconf/config/car:cars" class="external-link" target="_blank" rel="nofollow noopener">http://localhost:8181/restconf/config/car:cars</a></p> <p>JSON:</p> <p>{<br/> car-entry : </p> { id: "0", model : "Model", manufacturer : "Manufacturer", year : "2000", category : "Category" } <p>}</p> <p>XML:<br/> &lt;car-entry xmlns="urn:opendaylight:params:xml:ns:yang:controller:config:sal-clustering-it:car"&gt;<br/> &lt;id&gt;0&lt;/id&gt;<br/> &lt;model&gt;Model&lt;/model&gt;<br/> &lt;manufacturer&gt;Manufacturer&lt;/manufacturer&gt;<br/> &lt;year&gt;2000&lt;/year&gt;<br/> &lt;category&gt;Category&lt;/category&gt;<br/> &lt;/car-entry&gt;</p> <p>I have tested it. It works. If there are still issues, please reopen.</p> Development External issue ID 4119 External issue URL Rank 0|i031qn: