https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-537 OpenFlowPlugin <p>Today, when I have info for org.opendaylight.openflowplugin, it shows for connection but not for disconnection.<br/> And when I set debug, i see good amount of loggings, but it is difficult to have logs, workspace to find out the given log for which device.</p> <p>1) INFO: A connect and disconnect logs should be there in place <br/> 2) Any openflow plugin log, should print the node id<br/> 3) &lt;please add specific requirements if you think any&gt;</p> <p>Operating System: Linux<br/> Platform: PC</p> OPNFLWPLUG-537

Logging improvement

Improvement Resolved Done Hariharan Sethuraman Hariharan Sethuraman Tue, 18 Aug 2015 04:27:17 +0000 Mon, 27 Sep 2021 09:01:38 +0000 Tue, 16 Aug 2016 08:12:33 +0000 General 0 11 <p>Moving the defect under OFJ from OFP as the fix requires changes in OFJ. We can file a defect for logging improvement in OFP separately.</p> <p>Adding logs on disconnect event and during the flush in OBQ. Taking the defect.</p> <p>I believe that openflowjava's incomming / received connection logs are informative enough.</p> <p>Similarly, it delegates the disconnect event notification into openflowplugin where it can be logged. So what is the concrete information you want to see in openflowjava logs ?</p> <p>(In reply to Michal Polkorab from comment #2)<br/> &gt; I believe that openflowjava's incomming / received connection logs are<br/> &gt; informative enough.<br/> &gt; <br/> &gt; Similarly, it delegates the disconnect event notification into<br/> &gt; openflowplugin where it can be logged. So what is the concrete information<br/> &gt; you want to see in openflowjava logs ?</p> <p>Initially thought to add it in OFJ would help in a centralized place. Later realized the logs are sufficient after going through the OFJ code. I should move back this defect to OFP - reason is, when I enable debug for org.opendaylight.openflowjava, I see the karaf logs being rolled up fast.</p> <p>(In reply to Hariharan Sethuraman from comment #3)<br/> &gt; (In reply to Michal Polkorab from comment #2)<br/> &gt; &gt; I believe that openflowjava's incomming / received connection logs are<br/> &gt; &gt; informative enough.<br/> &gt; &gt; <br/> &gt; &gt; Similarly, it delegates the disconnect event notification into<br/> &gt; &gt; openflowplugin where it can be logged. So what is the concrete information<br/> &gt; &gt; you want to see in openflowjava logs ?<br/> &gt; <br/> &gt; Initially thought to add it in OFJ would help in a centralized place. Later<br/> &gt; realized the logs are sufficient after going through the OFJ code. I should<br/> &gt; move back this defect to OFP - reason is, when I enable debug for<br/> &gt; org.opendaylight.openflowjava, I see the karaf logs being rolled up fast.</p> <p>Moved it. Thanks.</p> <p>We added a lot of logs with node id in clustering optimizations update. On debug level. Is it informative enough now ?</p> <p>for the li-plugin:</p> <p><a href="https://git.opendaylight.org/gerrit/#/c/38274/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38274/</a></p> <p><a href="https://git.opendaylight.org/gerrit/#/c/38254/" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/38254/</a></p> <p>Still working on a couple of more ones..will keep u posted</p> <p>first one merged. second one pending</p> <p>Guys, why we creating errors instead of warnings. I thought we agreed to log errors only in case we can't continue and whole system should be terminated. And anyway we can see all warning in log, so I don't see any good reason to get errors. Many things are good in this patch but I am not sure about those errors.</p> <p>Jozef</p> <p>Hi Jozef,</p> <p>As a guideline i have logged in error on all failures and wherever we are catching exceptions. since in a normal ODL dist running, (in case of warns), we donot see logs. <br/> We need to enable the logs and recreate the scenario in any case of any failures.</p> <p>thanks</p> <p>Do let me know of your comments. Also mostly at all places not too much of context information is available to deduct any conclusion. Hence have added info in those places.</p> <p>another patches:<br/> <a href="https://git.opendaylight.org/gerrit/#/c/36452" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/36452</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/40783" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/40783</a><br/> <a href="https://git.opendaylight.org/gerrit/#/c/42127" class="external-link" target="_blank" rel="nofollow noopener">https://git.opendaylight.org/gerrit/#/c/42127</a></p> <p>Logging improved. If needed more actions, reopen or create new bug.</p> Blocks OPNFLWPLUG-501 Development External issue ID 4148 External issue URL Priority Rank 0|i031rj: