https://jira.opendaylight.org This file is an XML representation of an issue en-us 8.20.10 820010 22-06-2022 https://jira.opendaylight.org/browse/OPNFLWPLUG-59 OpenFlowPlugin <p>We cannot use set-field action for:<br/> ETH_TYPE <br/> ICMPV4_TYPE <br/> ICMPV4_CODE <br/> ARP_OP <br/> ARP_SPA <br/> ARP_TPA <br/> ARP_SHA <br/> ARP_THA <br/> IPV6_FLABEL <br/> ICMPV6_TYPE <br/> ICMPV6_CODE <br/> IPV6_ND_TARGET <br/> IPV6_ND_SLL <br/> IPV6_ND_TLL </p> <p>We were testing using XMLs and the odl_tests.py script, which failed.<br/> When we tried to do it manually over CLI, this is the output:</p> <p>mininet@mininet-vm:~$ sudo ovs-ofctl <del>O OpenFlow13 add-flow s1 "dl_type=0x800,table=2,nw_src=1.2.3.4/24,metadata=12345,actions=set_field:0x86DD</del>&gt;dl_type"<br/> ovs-ofctl: dl_type is read-only</p> <p>mininet@mininet-vm:~$ sudo ovs-ofctl <del>O OpenFlow13 add-flow s1 "table=2,priority=2,dl_type=0x86DD,dl_dst=aa:bb:cc:00:64:00,nw_proto=1,actions=set_field:7</del>&gt;icmp_code"<br/> ovs-ofctl: icmp_code is read-only</p> <p>mininet@mininet-vm:~$ sudo ovs-ofctl <del>O OpenFlow13 add-flow s1 "table=2,priority=2,dl_type=0x86DD,dl_dst=aa:bb:cc:00:64:00,nw_proto=1,actions=set_field:7</del>&gt;icmp_code"<br/> ovs-ofctl: icmp_code is read-only</p> <p>and so on.</p> <p>Version Info:<br/> mininet@mininet-vm:~/removeMDFlow-test-scripts$ ovs-ofctl -V<br/> ovs-ofctl (Open vSwitch) 2.0.0<br/> Compiled Nov 11 2013 12:25:52<br/> OpenFlow versions 0x1:0x4<br/> mininet@mininet-vm:~/removeMDFlow-test-scripts$ mn --version<br/> 2.1.0<br/> krish@krish-Ubuntu32:~/Desktop/shared/E_DRIVE/openflowplugin$ git log<br/> commit 49029e5d7978e4bf9f9c56f1ec98a264f61ff203<br/> Author: Ed Warnicke &lt;eaw@cisco.com&gt;<br/> Date: Sat Jan 25 21:33:22 2014 -0600</p> <p> Turned down logging in ErrorTranslator from ERROR to DEBUG</p> <p> Change-Id: I296451951e41320def91234b67671211948f5908<br/> Signed-off-by: Ed Warnicke &lt;eaw@cisco.com&gt;</p> <p>Operating System: Linux<br/> Platform: PC</p> OPNFLWPLUG-59

Set-field cannot update read-only actions on OVS

Bug Resolved Done Krishnan Iyer Krishnan Iyer Mon, 27 Jan 2014 08:30:35 +0000 Mon, 27 Sep 2021 09:01:04 +0000 Mon, 24 Mar 2014 21:10:19 +0000 General 0 6 <p>If the flow is being written from CLI, what is the role of controller in this? </p> <p>I think the openvswitch code is working as intended and this is an invalid scenario: Try to write the set field that are read-only. </p> <p>The set-field action parameters are set as read-only in openvswitch. In file openvswitch&lt;version&gt;/lib/ofp-parse.c, method set_field_parse(), the code checks for the those variables that are not writable and returns fatal error if they are read-only.</p> <p>Please update that my understanding is correct on this or not?</p> <p>Hi Jyotsna,</p> <p>"If the flow is being written from CLI, what is the role of controller in this?"<br/> I just tested using the CLI, and also with the restconf API.</p> <p>"I think the openvswitch code is working as intended and this is an invalid scenario: Try to write the set field that are read-only. "<br/> The OpenFlow 1.3.2 spec says that we should be able to set the values for these fields.</p> <p>"The set-field action parameters are set as read-only in openvswitch. In file openvswitch&lt;version&gt;/lib/ofp-parse.c, method set_field_parse(), the code checks for the those variables that are not writable and returns fatal error if they are read-only.<br/> Please update that my understanding is correct on this or not?"<br/> So, if this is the case, either OVS needs to make them read-write ot the OF spec should be updated.<br/> Thanks.</p> <p>Also, restconf sends an OK/Success when tested. PUT/GET succeeds.<br/> It should return an error code if the field is read-only.<br/> This part is an OpenflowPlugin bug.</p> <p>&gt;"The OpenFlow 1.3.2 spec says that we should be able to set the values for these fields"<br/> You are right. In openflow 1.3.2 spec, it is mentioned that all fi�elds in<br/> ofp_table_features may be requested to be changed by the controller with the exception of the max_entries_fi�eld, this is read only and returned by the switch.</p> <p>So this is ovs bug and not of openflowplugin. OVS needs to make them read-write.</p> <p>Hi Krishnan,</p> <p>Can you please provide the url and xml file that you used in restclient.</p> <p>Thanks</p> <p>One of the example XML</p> <p>Attachment f129.xml has been added with description: ICMPv4 Type XML</p> <p>On cpqd switch the attached xml works. But on ovs it fails and corresponding error message arrives from switch. This message gets translated into MD-SAL model and published to MD-SAL. </p> <p>I believe that controller is processing this scenario as expected.</p> <p>Krishnan, could you please mark this bug as resolved and eventually file a bug into openvswitch.org?</p> <p>Thank you.</p> <p>Any update on this Krishnan?</p> <p>Abhijit/Michal,<br/> Have marked the bug as fixed.<br/> Am trying to find how to file a bug on openvswitch.org.<br/> Once I file there,will cross-reference it over here.</p> <p>Have emailed bugs@openvswitch.org with the details.</p> <p>(In reply to Krishnan Iyer from comment #2)<br/> &gt;&gt; "I think the openvswitch code is working as intended and this is an invalid<br/> &gt; scenario: Try to write the set field that are read-only. "<br/> &gt; The OpenFlow 1.3.2 spec says that we should be able to set the values for<br/> &gt; these fields.</p> <p>This is some kind of misunderstanding. Here's what OpenFlow 1.3.3 says in section 5.12. Set-Field is clearly optional:</p> <p> Optional Action: Set-Field. The various Set-Field actions are<br/> identified by their field type and mod- ify the values of<br/> respective header fields in the packet. While not strictly<br/> required, the support of rewriting various header fields using<br/> Set-Field actions greatly increase the usefulness of an OpenFlow<br/> implementation.</p> <p>Here's what 7.2.5 Action Structures says:</p> <p> All header fields are valid in the set-field action, as well as<br/> the OXM_OF_TUNNEL_ID pipeline field, and can be used if the switch<br/> support them.</p> <p>(In reply to Jyotsna Priya from comment #4)<br/> &gt; &gt;"The OpenFlow 1.3.2 spec says that we should be able to set the values for these fields"<br/> &gt; You are right. In openflow 1.3.2 spec, it is mentioned that all fi�elds in<br/> &gt; ofp_table_features may be requested to be changed by the controller with the<br/> &gt; exception of the max_entries_fi�eld, this is read only and returned by the<br/> &gt; switch.<br/> &gt; <br/> &gt; So this is ovs bug and not of openflowplugin. OVS needs to make them<br/> &gt; read-write.</p> <p>This is wrong. ofp_table_features allows one to find out the switch's features, including whether it can write various fields, and to request changes to the switch's features. The text in 1.3.2 means that the controller can request a change to any feature, but it doesn't mean that the switch must be able to implement any change that the controller requests.</p> Development External issue ID 381 External issue URL Rank 0|i02ytb: